[2/2] coresight: replicator: Fix missing spin_lock_init()
diff mbox series

Message ID 20191118185207.30441-3-mathieu.poirier@linaro.org
State Mainlined
Commit 9a5d847c0bdadb67892b7d176a028578aaed0c3a
Headers show
  • coresight: next v5.4-rc8
Related show

Commit Message

Mathieu Poirier Nov. 18, 2019, 6:52 p.m. UTC
From: Wei Yongjun <weiyongjun1@huawei.com>

The driver allocates the spinlock but not initialize it.
Use spin_lock_init() on it to initialize it correctly.

This is detected by Coccinelle semantic patch.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Tested-by: Yabin Cui <yabinc@google.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
 drivers/hwtracing/coresight/coresight-replicator.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

diff --git a/drivers/hwtracing/coresight/coresight-replicator.c b/drivers/hwtracing/coresight/coresight-replicator.c
index 43304196a1a6..e7dc1c31d20d 100644
--- a/drivers/hwtracing/coresight/coresight-replicator.c
+++ b/drivers/hwtracing/coresight/coresight-replicator.c
@@ -248,6 +248,7 @@  static int replicator_probe(struct device *dev, struct resource *res)
 	dev->platform_data = pdata;
+	spin_lock_init(&drvdata->spinlock);
 	desc.subtype.link_subtype = CORESIGHT_DEV_SUBTYPE_LINK_SPLIT;
 	desc.ops = &replicator_cs_ops;