diff mbox series

[CI,1/5] drm/i915/guc: Drop leftover preemption code

Message ID 20191118235531.9353-1-daniele.ceraolospurio@intel.com (mailing list archive)
State New, archived
Headers show
Series [CI,1/5] drm/i915/guc: Drop leftover preemption code | expand

Commit Message

Daniele Ceraolo Spurio Nov. 18, 2019, 11:55 p.m. UTC 
Remove unused enums and ctx_save_restore_disabled() function, leftover
from the legacy preemption removal.

Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 22 -------------------
 1 file changed, 22 deletions(-)

Comments

Daniele Ceraolo Spurio Nov. 19, 2019, 1:55 a.m. UTC | #1 
On 11/18/19 5:05 PM, Patchwork wrote:
> == Series Details ==
> 
> Series: series starting with [CI,1/5] drm/i915/guc: Drop leftover preemption code
> URL   : https://patchwork.freedesktop.org/series/69650/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7367 -> Patchwork_15323
> ====================================================
> 
> Summary
> -------
> 
>    **FAILURE**
> 
>    Serious unknown changes coming with Patchwork_15323 absolutely need to be
>    verified manually.
>    
>    If you think the reported changes have nothing to do with the changes
>    introduced in Patchwork_15323, please notify your bug team to allow them
>    to document this new failure mode, which will reduce false positives in CI.
> 
>    External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15323/index.html
> 
> Possible new issues
> -------------------
> 
>    Here are the unknown changes that may have been introduced in Patchwork_15323:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>    * igt@i915_selftest@live_gt_pm:
>      - fi-icl-u2:          [PASS][1] -> [DMESG-FAIL][2]
>     [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7367/fi-icl-u2/igt@i915_selftest@live_gt_pm.html
>     [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15323/fi-icl-u2/igt@i915_selftest@live_gt_pm.html
>      - fi-icl-u3:          [PASS][3] -> [DMESG-FAIL][4]
>     [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7367/fi-icl-u3/igt@i915_selftest@live_gt_pm.html
>     [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15323/fi-icl-u3/igt@i915_selftest@live_gt_pm.html
>      - fi-icl-dsi:         [PASS][5] -> [DMESG-FAIL][6]
>     [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7367/fi-icl-dsi/igt@i915_selftest@live_gt_pm.html
>     [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15323/fi-icl-dsi/igt@i915_selftest@live_gt_pm.html
>      - fi-icl-y:           [PASS][7] -> [DMESG-FAIL][8]
>     [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7367/fi-icl-y/igt@i915_selftest@live_gt_pm.html
>     [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15323/fi-icl-y/igt@i915_selftest@live_gt_pm.html
> 

Those are all https://bugs.freedesktop.org/show_bug.cgi?id=112205

Daniele

>    
> Known issues
> ------------
> 
>    Here are the changes found in Patchwork_15323 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>    * igt@i915_getparams_basic@basic-subslice-total:
>      - fi-icl-dsi:         [PASS][9] -> [DMESG-WARN][10] ([fdo#106107])
>     [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7367/fi-icl-dsi/igt@i915_getparams_basic@basic-subslice-total.html
>     [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15323/fi-icl-dsi/igt@i915_getparams_basic@basic-subslice-total.html
> 
>    * igt@i915_pm_rpm@module-reload:
>      - fi-skl-6770hq:      [PASS][11] -> [DMESG-FAIL][12] ([fdo#108511])
>     [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7367/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
>     [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15323/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
> 
>    * igt@i915_selftest@live_hangcheck:
>      - fi-hsw-4770r:       [PASS][13] -> [DMESG-FAIL][14] ([fdo#111991])
>     [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7367/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html
>     [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15323/fi-hsw-4770r/igt@i915_selftest@live_hangcheck.html
> 
>    
> #### Possible fixes ####
> 
>    * igt@i915_selftest@live_blt:
>      - fi-bsw-n3050:       [DMESG-FAIL][15] ([fdo#112176]) -> [PASS][16]
>     [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7367/fi-bsw-n3050/igt@i915_selftest@live_blt.html
>     [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15323/fi-bsw-n3050/igt@i915_selftest@live_blt.html
>      - fi-hsw-peppy:       [DMESG-FAIL][17] ([fdo#112225]) -> [PASS][18]
>     [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7367/fi-hsw-peppy/igt@i915_selftest@live_blt.html
>     [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15323/fi-hsw-peppy/igt@i915_selftest@live_blt.html
> 
>    
>    {name}: This element is suppressed. This means it is ignored when computing
>            the status of the difference (SUCCESS, WARNING, or FAILURE).
> 
>    [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
>    [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
>    [fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
>    [fdo#111991]: https://bugs.freedesktop.org/show_bug.cgi?id=111991
>    [fdo#112176]: https://bugs.freedesktop.org/show_bug.cgi?id=112176
>    [fdo#112225]: https://bugs.freedesktop.org/show_bug.cgi?id=112225
>    [fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
> 
> 
> Participating hosts (49 -> 44)
> ------------------------------
> 
>    Missing    (5): fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
> 
> 
> Build changes
> -------------
> 
>    * CI: CI-20190529 -> None
>    * Linux: CI_DRM_7367 -> Patchwork_15323
> 
>    CI-20190529: 20190529
>    CI_DRM_7367: db6c0570abdebad7d56bf88eb15ad3b51dad4699 @ git://anongit.freedesktop.org/gfx-ci/linux
>    IGT_5293: 4bb46f08f7cb6485642c4351cecdad93072d27a0 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>    Patchwork_15323: f3a61dfa95bc3b64e7836fc20b9afd31cf3e5eba @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> 
> == Linux commits ==
> 
> f3a61dfa95bc HAX: force enable_guc=2
> 51032ff2cae5 drm/i915/guc: kill the GuC client
> f8ada017ed27 drm/i915/guc: kill doorbell code and selftests
> 194b7f455dd3 drm/i915/guc: add a helper to allocate and map guc vma
> eb4028870663 drm/i915/guc: Drop leftover preemption code
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15323/index.html
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
index 902e25eb6b9d..6d4eb7690db1 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c
@@ -18,15 +18,6 @@ 
 #include "i915_drv.h"
 #include "i915_trace.h"
 
-enum {
-	GUC_PREEMPT_NONE = 0,
-	GUC_PREEMPT_INPROGRESS,
-	GUC_PREEMPT_FINISHED,
-};
-#define GUC_PREEMPT_BREADCRUMB_DWORDS	0x8
-#define GUC_PREEMPT_BREADCRUMB_BYTES	\
-	(sizeof(u32) * GUC_PREEMPT_BREADCRUMB_DWORDS)
-
 /**
  * DOC: GuC-based command submission
  *
@@ -884,19 +875,6 @@  static void guc_client_free(struct intel_guc_client *client)
 	kfree(client);
 }
 
-static inline bool ctx_save_restore_disabled(struct intel_context *ce)
-{
-	u32 sr = ce->lrc_reg_state[CTX_CONTEXT_CONTROL + 1];
-
-#define SR_DISABLED \
-	_MASKED_BIT_ENABLE(CTX_CTRL_ENGINE_CTX_RESTORE_INHIBIT | \
-			   CTX_CTRL_ENGINE_CTX_SAVE_INHIBIT)
-
-	return (sr & SR_DISABLED) == SR_DISABLED;
-
-#undef SR_DISABLED
-}
-
 static int guc_clients_create(struct intel_guc *guc)
 {
 	struct intel_guc_client *client;