thermal: db8500: Depromote debug print
diff mbox series

Message ID 20191119074650.2664-1-linus.walleij@linaro.org
State New, archived
Delegated to: Eduardo Valentin
Headers show
Series
  • thermal: db8500: Depromote debug print
Related show

Commit Message

Linus Walleij Nov. 19, 2019, 7:46 a.m. UTC
We are not interested in getting this debug print on our
console all the time.

Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Stephan Gerhold <stephan@gerhold.net>
Fixes: 6c375eccded4 ("thermal: db8500: Rewrite to be a pure OF sensor")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/thermal/db8500_thermal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stephan Gerhold Nov. 19, 2019, 7:19 p.m. UTC | #1
On Tue, Nov 19, 2019 at 08:46:50AM +0100, Linus Walleij wrote:
> We are not interested in getting this debug print on our
> console all the time.
> 
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Fixes: 6c375eccded4 ("thermal: db8500: Rewrite to be a pure OF sensor")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

I noticed those as well. Thanks for the patch!

FWIW:
Reviewed-by: Stephan Gerhold <stephan@gerhold.net>

> ---
>  drivers/thermal/db8500_thermal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c
> index 372dbbaaafb8..21d4d6e6409a 100644
> --- a/drivers/thermal/db8500_thermal.c
> +++ b/drivers/thermal/db8500_thermal.c
> @@ -152,8 +152,8 @@ static irqreturn_t prcmu_high_irq_handler(int irq, void *irq_data)
>  		db8500_thermal_update_config(th, idx, THERMAL_TREND_RAISING,
>  					     next_low, next_high);
>  
> -		dev_info(&th->tz->device,
> -			 "PRCMU set max %ld, min %ld\n", next_high, next_low);
> +		dev_dbg(&th->tz->device,
> +			"PRCMU set max %ld, min %ld\n", next_high, next_low);
>  	} else if (idx == num_points - 1)
>  		/* So we roof out 1 degree over the max point */
>  		th->interpolated_temp = db8500_thermal_points[idx] + 1;
> -- 
> 2.21.0
>
Daniel Lezcano Dec. 4, 2019, 4:01 p.m. UTC | #2
On 19/11/2019 08:46, Linus Walleij wrote:
> We are not interested in getting this debug print on our
> console all the time.
> 
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Stephan Gerhold <stephan@gerhold.net>
> Fixes: 6c375eccded4 ("thermal: db8500: Rewrite to be a pure OF sensor")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Applied, thanks!

> ---
>  drivers/thermal/db8500_thermal.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c
> index 372dbbaaafb8..21d4d6e6409a 100644
> --- a/drivers/thermal/db8500_thermal.c
> +++ b/drivers/thermal/db8500_thermal.c
> @@ -152,8 +152,8 @@ static irqreturn_t prcmu_high_irq_handler(int irq, void *irq_data)
>  		db8500_thermal_update_config(th, idx, THERMAL_TREND_RAISING,
>  					     next_low, next_high);
>  
> -		dev_info(&th->tz->device,
> -			 "PRCMU set max %ld, min %ld\n", next_high, next_low);
> +		dev_dbg(&th->tz->device,
> +			"PRCMU set max %ld, min %ld\n", next_high, next_low);
>  	} else if (idx == num_points - 1)
>  		/* So we roof out 1 degree over the max point */
>  		th->interpolated_temp = db8500_thermal_points[idx] + 1;
>

Patch
diff mbox series

diff --git a/drivers/thermal/db8500_thermal.c b/drivers/thermal/db8500_thermal.c
index 372dbbaaafb8..21d4d6e6409a 100644
--- a/drivers/thermal/db8500_thermal.c
+++ b/drivers/thermal/db8500_thermal.c
@@ -152,8 +152,8 @@  static irqreturn_t prcmu_high_irq_handler(int irq, void *irq_data)
 		db8500_thermal_update_config(th, idx, THERMAL_TREND_RAISING,
 					     next_low, next_high);
 
-		dev_info(&th->tz->device,
-			 "PRCMU set max %ld, min %ld\n", next_high, next_low);
+		dev_dbg(&th->tz->device,
+			"PRCMU set max %ld, min %ld\n", next_high, next_low);
 	} else if (idx == num_points - 1)
 		/* So we roof out 1 degree over the max point */
 		th->interpolated_temp = db8500_thermal_points[idx] + 1;