tools/acpi: fix compilation error
diff mbox series

Message ID 1574167929-11244-1-git-send-email-liuzhengyuan@kylinos.cn
State Changes Requested, archived
Headers show
Series
  • tools/acpi: fix compilation error
Related show

Commit Message

Zhengyuan Liu Nov. 19, 2019, 12:52 p.m. UTC
From: liuzhengyuan <liuzhengyuan@kylinos.com.cn>

If we compile tools/acpi target in the top source directory, we'd get a
compilation error showing as bellow:

	# make tools/acpi
	  DESCEND  power/acpi
	  DESCEND  tools/acpidbg
	  CC       tools/acpidbg/acpidbg.o
	Assembler messages:
	Fatal error: can't create /home/lzy/kernel-upstream/linux-linus-ubuntu/power\
			/acpi/tools/acpidbg/acpidbg.o: No such file or directory
	../../Makefile.rules:26: recipe for target '/home/lzy/kernel-upstream/linux-\
			linus-ubuntu/power/acpi/tools/acpidbg/acpidbg.o' failed
	make[3]: *** [/home/lzy/kernel-upstream/linux-linus-ubuntu/power/acpi/tools/\
			acpidbg/acpidbg.o] Error 1
	Makefile:19: recipe for target 'acpidbg' failed
	make[2]: *** [acpidbg] Error 2
	Makefile:54: recipe for target 'acpi' failed
	make[1]: *** [acpi] Error 2
	Makefile:1607: recipe for target 'tools/acpi' failed
	make: *** [tools/acpi] Error 2

Fixes: d5a4b1a540b ("tools/power/acpi: Remove direct kernel source include reference")
Signed-off-by: liuzhengyuan <liuzhengyuan@kylinos.com.cn>
---
 tools/power/acpi/Makefile.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rafael J. Wysocki Dec. 12, 2019, 10 p.m. UTC | #1
On Tuesday, November 19, 2019 1:52:09 PM CET Zhengyuan Liu wrote:
> From: liuzhengyuan <liuzhengyuan@kylinos.com.cn>
> 
> If we compile tools/acpi target in the top source directory, we'd get a
> compilation error showing as bellow:
> 
> 	# make tools/acpi
> 	  DESCEND  power/acpi
> 	  DESCEND  tools/acpidbg
> 	  CC       tools/acpidbg/acpidbg.o
> 	Assembler messages:
> 	Fatal error: can't create /home/lzy/kernel-upstream/linux-linus-ubuntu/power\
> 			/acpi/tools/acpidbg/acpidbg.o: No such file or directory
> 	../../Makefile.rules:26: recipe for target '/home/lzy/kernel-upstream/linux-\
> 			linus-ubuntu/power/acpi/tools/acpidbg/acpidbg.o' failed
> 	make[3]: *** [/home/lzy/kernel-upstream/linux-linus-ubuntu/power/acpi/tools/\
> 			acpidbg/acpidbg.o] Error 1
> 	Makefile:19: recipe for target 'acpidbg' failed
> 	make[2]: *** [acpidbg] Error 2
> 	Makefile:54: recipe for target 'acpi' failed
> 	make[1]: *** [acpi] Error 2
> 	Makefile:1607: recipe for target 'tools/acpi' failed
> 	make: *** [tools/acpi] Error 2
> 
> Fixes: d5a4b1a540b ("tools/power/acpi: Remove direct kernel source include reference")
> Signed-off-by: liuzhengyuan <liuzhengyuan@kylinos.com.cn>

You evidently could use the proper English spelling of your full name when
sending the message, so what would be wrong with using it for the sign-off too?

> ---
>  tools/power/acpi/Makefile.config | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config
> index 0111d24..54a2857 100644
> --- a/tools/power/acpi/Makefile.config
> +++ b/tools/power/acpi/Makefile.config
> @@ -15,7 +15,7 @@ include $(srctree)/../../scripts/Makefile.include
>  
>  OUTPUT=$(srctree)/
>  ifeq ("$(origin O)", "command line")
> -	OUTPUT := $(O)/power/acpi/
> +	OUTPUT := $(O)/tools/power/acpi/
>  endif
>  #$(info Determined 'OUTPUT' to be $(OUTPUT))
>  
>

Patch
diff mbox series

diff --git a/tools/power/acpi/Makefile.config b/tools/power/acpi/Makefile.config
index 0111d24..54a2857 100644
--- a/tools/power/acpi/Makefile.config
+++ b/tools/power/acpi/Makefile.config
@@ -15,7 +15,7 @@  include $(srctree)/../../scripts/Makefile.include
 
 OUTPUT=$(srctree)/
 ifeq ("$(origin O)", "command line")
-	OUTPUT := $(O)/power/acpi/
+	OUTPUT := $(O)/tools/power/acpi/
 endif
 #$(info Determined 'OUTPUT' to be $(OUTPUT))