padata: Remove unused padata_remove_cpu
diff mbox series

Message ID 20191119223250.jaefneeatsa52nhh@gondor.apana.org.au
State Accepted
Delegated to: Herbert Xu
Headers show
Series
  • padata: Remove unused padata_remove_cpu
Related show

Commit Message

Herbert Xu Nov. 19, 2019, 10:32 p.m. UTC
The function padata_remove_cpu was supposed to have been removed
along with padata_add_cpu but somehow it remained behind.  Let's
kill it now as it doesn't even have a prototype anymore.

Fixes: 815613da6a67 ("kernel/padata.c: removed unused code")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Comments

Daniel Jordan Nov. 19, 2019, 10:51 p.m. UTC | #1
On Wed, Nov 20, 2019 at 06:32:50AM +0800, Herbert Xu wrote:
> The function padata_remove_cpu was supposed to have been removed
> along with padata_add_cpu but somehow it remained behind.  Let's
> kill it now as it doesn't even have a prototype anymore.

Documentation/padata.txt still has a reference to this function that should be
removed.


I'm just now getting back to this series that I posted--admittedly a long time
ago!  :)

    https://lore.kernel.org/linux-crypto/20190828221425.22701-1-daniel.m.jordan@oracle.com/

Do you plan on posting other fixes in this area?  Asking so I know which to
work on further.  Thanks.
Herbert Xu Nov. 20, 2019, 1:10 a.m. UTC | #2
On Tue, Nov 19, 2019 at 05:51:01PM -0500, Daniel Jordan wrote:
> On Wed, Nov 20, 2019 at 06:32:50AM +0800, Herbert Xu wrote:
> > The function padata_remove_cpu was supposed to have been removed
> > along with padata_add_cpu but somehow it remained behind.  Let's
> > kill it now as it doesn't even have a prototype anymore.
> 
> Documentation/padata.txt still has a reference to this function that should be
> removed.

It also has references to all the other functions that have long
disappeared, such as padata_add_cpu.  Would you like to send a
patch to remove all of them?

> Do you plan on posting other fixes in this area?  Asking so I know which to
> work on further.  Thanks.

Not at this point.  So feel free to rebase your work on top of these
patches.

Thanks,
Daniel Jordan Nov. 20, 2019, 6:56 p.m. UTC | #3
On Wed, Nov 20, 2019 at 09:10:15AM +0800, Herbert Xu wrote:
> On Tue, Nov 19, 2019 at 05:51:01PM -0500, Daniel Jordan wrote:
> > On Wed, Nov 20, 2019 at 06:32:50AM +0800, Herbert Xu wrote:
> > > The function padata_remove_cpu was supposed to have been removed
> > > along with padata_add_cpu but somehow it remained behind.  Let's
> > > kill it now as it doesn't even have a prototype anymore.
> > 
> > Documentation/padata.txt still has a reference to this function that should be
> > removed.
> 
> It also has references to all the other functions that have long
> disappeared, such as padata_add_cpu.  Would you like to send a
> patch to remove all of them?

Ok, sure.
Daniel Jordan Nov. 27, 2019, 11:37 p.m. UTC | #4
On Wed, Nov 20, 2019 at 06:32:50AM +0800, Herbert Xu wrote:
> The function padata_remove_cpu was supposed to have been removed
> along with padata_add_cpu but somehow it remained behind.  Let's
> kill it now as it doesn't even have a prototype anymore.
> 
> Fixes: 815613da6a67 ("kernel/padata.c: removed unused code")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com>

Patch
diff mbox series

diff --git a/kernel/padata.c b/kernel/padata.c
index da56a235a255..fc00f7e64133 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -718,41 +718,6 @@  static int __padata_remove_cpu(struct padata_instance *pinst, int cpu)
 	return 0;
 }
 
- /**
- * padata_remove_cpu - remove a cpu from the one or both(serial and parallel)
- *                     padata cpumasks.
- *
- * @pinst: padata instance
- * @cpu: cpu to remove
- * @mask: bitmask specifying from which cpumask @cpu should be removed
- *        The @mask may be any combination of the following flags:
- *          PADATA_CPU_SERIAL   - serial cpumask
- *          PADATA_CPU_PARALLEL - parallel cpumask
- */
-int padata_remove_cpu(struct padata_instance *pinst, int cpu, int mask)
-{
-	int err;
-
-	if (!(mask & (PADATA_CPU_SERIAL | PADATA_CPU_PARALLEL)))
-		return -EINVAL;
-
-	mutex_lock(&pinst->lock);
-
-	get_online_cpus();
-	if (mask & PADATA_CPU_SERIAL)
-		cpumask_clear_cpu(cpu, pinst->cpumask.cbcpu);
-	if (mask & PADATA_CPU_PARALLEL)
-		cpumask_clear_cpu(cpu, pinst->cpumask.pcpu);
-
-	err = __padata_remove_cpu(pinst, cpu);
-	put_online_cpus();
-
-	mutex_unlock(&pinst->lock);
-
-	return err;
-}
-EXPORT_SYMBOL(padata_remove_cpu);
-
 static inline int pinst_has_cpu(struct padata_instance *pinst, int cpu)
 {
 	return cpumask_test_cpu(cpu, pinst->cpumask.pcpu) ||