| Message ID | 16a90b70638b100afe4b7d68c0db20ffae7ce964.1574207673.git.liu.denton@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | range-diff: learn `--notes` | expand |
On Tue, Nov 19, 2019 at 6:55 PM Denton Liu <liu.denton@gmail.com> wrote: > For shell scripts, the usual convention is for there to be no space > after redirection operators, (e.g. `>file`, not `> file`). Remove the > one instance of this. > > Signed-off-by: Denton Liu <liu.denton@gmail.com> > --- > diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh > @@ -8,7 +8,7 @@ test_description='range-diff tests' > test_expect_success 'setup' ' > - git fast-import < "$TEST_DIRECTORY"/t3206/history.export && > + git fast-import <"$TEST_DIRECTORY"/t3206/history.export && > test_oid_cache <<-EOF > # topic > t1 sha1:4de457d While you're here cleaning style problems, you could also change this here-doc from -EOF to -\EOF. (This is the only here-doc in this script which can use -\EOF; all the others need -EOF.)
diff --git a/t/t3206-range-diff.sh b/t/t3206-range-diff.sh index 0579cd9969..87c6c029db 100755 --- a/t/t3206-range-diff.sh +++ b/t/t3206-range-diff.sh @@ -8,7 +8,7 @@ test_description='range-diff tests' # harm than good. We need some real history. test_expect_success 'setup' ' - git fast-import < "$TEST_DIRECTORY"/t3206/history.export && + git fast-import <"$TEST_DIRECTORY"/t3206/history.export && test_oid_cache <<-EOF # topic t1 sha1:4de457d
For shell scripts, the usual convention is for there to be no space after redirection operators, (e.g. `>file`, not `> file`). Remove the one instance of this. Signed-off-by: Denton Liu <liu.denton@gmail.com> --- t/t3206-range-diff.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)