From patchwork Wed Nov 20 05:25:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "kernelci.org bot" X-Patchwork-Id: 11253199 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2D2D9930 for ; Wed, 20 Nov 2019 05:25:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5AD72240A for ; Wed, 20 Nov 2019 05:25:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernelci-org.20150623.gappssmtp.com header.i=@kernelci-org.20150623.gappssmtp.com header.b="ov0DGKKW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726014AbfKTFZZ (ORCPT ); Wed, 20 Nov 2019 00:25:25 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:50637 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726044AbfKTFZZ (ORCPT ); Wed, 20 Nov 2019 00:25:25 -0500 Received: by mail-wm1-f65.google.com with SMTP id l17so5626948wmh.0 for ; Tue, 19 Nov 2019 21:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:content-transfer-encoding:subject:to :from:cc; bh=v+uBk5IEyaYZ7IF/b+w4lvOtghz7YVivbgrg50na0fw=; b=ov0DGKKWFfs9XQfFjYgGbG8mvNWdUX0PZJC5FicSFBTO+iQBnzhDBYDf0xfmRuuOBr NH2BkVXbo2lWyCvfeEiGRw02G5cV770g6ATNSrTxDBSrdPpvQp1L85Uz7nT/qQxJW5IT xyhtRNPhTqG8zfeU/BCM0G3v0+A3UXpnfHUmdcSugqJ3k5LAmAsa9Q+SgcQAhGHjZ04L EbhorRGcgpqvPHItV7Lsd4FN0lJdIMnjiMPgjXAUFeed0SxhsrEJJfJXJ2TCmg3Slhn4 ehgDN3mBkccZSvgglZnOre1cpxyoKkowLiR/7oCYcHl1Nj25tfUFuuA2Q2ODmhNAgSg0 5LnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version :content-transfer-encoding:subject:to:from:cc; bh=v+uBk5IEyaYZ7IF/b+w4lvOtghz7YVivbgrg50na0fw=; b=M35O2ZDViydYvpzv2lNNo7HKoHHmH8vw6yZR2pCjw7Ld87RVMGyhFaZAP7GTUraYPf D0hQGk4gyJs+OooSU2g8s6MyQ4nN4+W1j+z6h2a9s29M87BV+TcA0ABXpC1ZajhOZoYZ UnCSz5PkGTETdRkX9Zp2Q+sL6HQwkY3UYlV0a9hEKRPZhosv17TWAyRXzqhBfuz2zfXM rNmd9RqjFwGwcNhcnnjvzWt+RPrXZHwbF8wcrrU2apEQUQjEMTXF+xe4cnIY2v4ZxLRB IVca5treWBkS7si4UWEVb6j3ERSBk9+qhiwBmvfEuCh2h/11ZIgEX+T6igMWCI4ecQ8/ ElIw== X-Gm-Message-State: APjAAAXTvRoGJvvotAsQndfvVCfqCO7NlBoCLZ0y45aYWbuIyTyVQeJS uRAfRZUl40tfQ4TzkRPoYL2DugPmdLjVMw== X-Google-Smtp-Source: APXvYqwhgSeFCVt1Z3whNFWM5gl6+qPpSEDUXk3HkahrF6XUVFw/zq5QHpMA127VV0d2Ihak5OT+CQ== X-Received: by 2002:a1c:1fca:: with SMTP id f193mr894882wmf.173.1574227520777; Tue, 19 Nov 2019 21:25:20 -0800 (PST) Received: from [148.251.42.114] ([2a01:4f8:201:9271::2]) by smtp.gmail.com with ESMTPSA id q15sm29863955wrs.91.2019.11.19.21.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2019 21:25:20 -0800 (PST) Message-ID: <5dd4ce40.1c69fb81.548f8.e723@mx.google.com> Date: Tue, 19 Nov 2019 21:25:20 -0800 (PST) MIME-Version: 1.0 X-Kernelci-Lab-Name: lab-collabora X-Kernelci-Branch: clk-next X-Kernelci-Tree: clk X-Kernelci-Report-Type: bisect X-Kernelci-Kernel: clk-fixes-for-linus-196-gcd89054e321a Subject: clk/clk-next bisection: boot on tegra124-nyan-big To: tomeu.vizoso@collabora.com, Stephen Boyd , guillaume.tucker@collabora.com, mgalka@collabora.com, Thierry Reding , broonie@kernel.org, matthew.hart@linaro.org, khilman@baylibre.com, enric.balletbo@collabora.com From: "kernelci.org bot" Cc: Thierry Reding , Jonathan Hunter , linux-kernel@vger.kernel.org, Prashant Gaikwad , Peter De Schrijver , linux-tegra@vger.kernel.org, Michael Turquette , linux-clk@vger.kernel.org Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * * * If you do send a fix, please include this trailer: * * Reported-by: "kernelci.org bot" * * * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * clk/clk-next bisection: boot on tegra124-nyan-big Summary: Start: cd89054e321a Merge branch 'clk-init-leak' into clk-next Details: https://kernelci.org/boot/id/5dd486b059b514415acf54bd Plain log: https://storage.kernelci.org//clk/clk-next/clk-fixes-for-linus-196-gcd89054e321a/arm/tegra_defconfig/gcc-8/lab-collabora/boot-tegra124-nyan-big.txt HTML log: https://storage.kernelci.org//clk/clk-next/clk-fixes-for-linus-196-gcd89054e321a/arm/tegra_defconfig/gcc-8/lab-collabora/boot-tegra124-nyan-big.html Result: 25175c806a68 clk: tegra: Reimplement SOR clock on Tegra124 Checks: revert: PASS verify: PASS Parameters: Tree: clk URL: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git Branch: clk-next Target: tegra124-nyan-big CPU arch: arm Lab: lab-collabora Compiler: gcc-8 Config: tegra_defconfig Test suite: boot Breaking commit found: ------------------------------------------------------------------------------- commit 25175c806a6841149abe46168e0af12593141612 Author: Thierry Reding Date: Thu Jul 25 18:19:00 2019 +0200 clk: tegra: Reimplement SOR clock on Tegra124 In order to allow the display driver to deal uniformly with all SOR generations, implement the SOR clocks in a way that is compatible with Tegra186 and later. Acked-by: Stephen Boyd Signed-off-by: Thierry Reding ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [dafbb1e6473788cb3068eaeddc58f9d88e9c7a62] Merge branch 'clk-ti' into clk-next git bisect good dafbb1e6473788cb3068eaeddc58f9d88e9c7a62 # bad: [cd89054e321a893073de7bb50f48b524a4ff675b] Merge branch 'clk-init-leak' into clk-next git bisect bad cd89054e321a893073de7bb50f48b524a4ff675b # bad: [097064b841b74b137a7672e8daccd1384574ec9c] Merge tag 'tegra-for-5.5-clk-v2' of git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux into clk-tegra git bisect bad 097064b841b74b137a7672e8daccd1384574ec9c # bad: [bc0b3a60fe19610d649a62879dd318d133ed10c0] clk: tegra: pll: Save and restore pll context git bisect bad bc0b3a60fe19610d649a62879dd318d133ed10c0 # good: [991a051ea5f15266903f52acb5832a596dd3da51] clk: tegra: Remove last remains of TEGRA210_CLK_SOR1_SRC git bisect good 991a051ea5f15266903f52acb5832a596dd3da51 # bad: [25175c806a6841149abe46168e0af12593141612] clk: tegra: Reimplement SOR clock on Tegra124 git bisect bad 25175c806a6841149abe46168e0af12593141612 # good: [da8d1a3555406275650b366460c6235f1696bf8b] clk: tegra: Rename sor0_lvds to sor0_out git bisect good da8d1a3555406275650b366460c6235f1696bf8b # first bad commit: [25175c806a6841149abe46168e0af12593141612] clk: tegra: Reimplement SOR clock on Tegra124 ------------------------------------------------------------------------------- diff --git a/drivers/clk/tegra/clk-tegra124.c b/drivers/clk/tegra/clk-tegra124.c index 7d231529c3a5..b3110d5b5a6c 100644 --- a/drivers/clk/tegra/clk-tegra124.c +++ b/drivers/clk/tegra/clk-tegra124.c @@ -1005,20 +1005,24 @@ static struct tegra_devclk devclks[] __initdata = { { .con_id = "hda2hdmi", .dt_id = TEGRA124_CLK_HDA2HDMI }, }; -static const char *mux_pllp_pllm_plld_plla_pllc_plld2_clkm[] = { - "pll_p", "pll_m", "pll_d_out0", "pll_a_out0", "pll_c", - "pll_d2_out0", "clk_m" +static const char * const sor0_parents[] = { + "pll_p_out0", "pll_m_out0", "pll_d_out0", "pll_a_out0", "pll_c_out0", + "pll_d2_out0", "clk_m", }; -#define mux_pllp_pllm_plld_plla_pllc_plld2_clkm_idx NULL -static const char *mux_clkm_plldp_sor0out[] = { - "clk_m", "pll_dp", "sor0_out", +static const char * const sor0_out_parents[] = { + "clk_m", "sor0_pad_clkout", }; -#define mux_clkm_plldp_sor0out_idx NULL static struct tegra_periph_init_data tegra124_periph[] = { - MUX8_NOGATE_LOCK("sor0_out", mux_pllp_pllm_plld_plla_pllc_plld2_clkm, CLK_SOURCE_SOR0, tegra_clk_sor0_out, &sor0_lock), - NODIV("sor0", mux_clkm_plldp_sor0out, CLK_SOURCE_SOR0, 14, 3, 182, 0, tegra_clk_sor0, &sor0_lock), + TEGRA_INIT_DATA_TABLE("sor0", NULL, NULL, sor0_parents, + CLK_SOURCE_SOR0, 29, 0x7, 0, 0, 0, 0, + 0, 182, 0, tegra_clk_sor0, NULL, 0, + &sor0_lock), + TEGRA_INIT_DATA_TABLE("sor0_out", NULL, NULL, sor0_out_parents, + CLK_SOURCE_SOR0, 14, 0x1, 0, 0, 0, 0, + 0, 0, TEGRA_PERIPH_NO_GATE, tegra_clk_sor0_out, + NULL, 0, &sor0_lock), }; static struct clk **clks;