input: misc: Kconfig: use select instead of depends on KEYBOARD_GPIO
diff mbox series

Message ID 20191121132046.11977-1-info@metux.net
State New
Headers show
Series
  • input: misc: Kconfig: use select instead of depends on KEYBOARD_GPIO
Related show

Commit Message

Enrico Weigelt, metux IT consult Nov. 21, 2019, 1:20 p.m. UTC
From: Enrico Weigelt <info@metux.net>

Make selection of the driver a bit easier by replacing depends on
KEYBOARD_GPIO by select, so we don't need to enable KEYBOARD_GPIO
before being able to enable INPUT_SOC_BUTTON_ARRAY.

Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
 drivers/input/misc/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Dmitry Torokhov Nov. 22, 2019, 7:58 p.m. UTC | #1
On Thu, Nov 21, 2019 at 02:20:46PM +0100, Enrico Weigelt, metux IT consult wrote:
> From: Enrico Weigelt <info@metux.net>
> 
> Make selection of the driver a bit easier by replacing depends on
> KEYBOARD_GPIO by select, so we don't need to enable KEYBOARD_GPIO
> before being able to enable INPUT_SOC_BUTTON_ARRAY.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
>  drivers/input/misc/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 7d9ae394e597..99d263177d8d 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -813,7 +813,8 @@ config INPUT_IDEAPAD_SLIDEBAR
>  
>  config INPUT_SOC_BUTTON_ARRAY
>  	tristate "Windows-compatible SoC Button Array"
> -	depends on KEYBOARD_GPIO && ACPI
> +	depends on ACPI
> +	select KEYBOARD_GPIO

KEYBOARD_GPIO depends on GPIOLIB and "select" does not propagate
dependencies, so you may still end up with invalid configs...

Thanks.
Enrico Weigelt, metux IT consult Nov. 28, 2019, 1:03 p.m. UTC | #2
On 22.11.19 20:58, Dmitry Torokhov wrote:

> KEYBOARD_GPIO depends on GPIOLIB and "select" does not propagate
> dependencies, so you may still end up with invalid configs...

Sure that they don't propagate ? In this case, I've got yet
another todo ... :o


--mtx
Dmitry Torokhov Dec. 2, 2019, 6:27 p.m. UTC | #3
On Thu, Nov 28, 2019 at 02:03:40PM +0100, Enrico Weigelt, metux IT consult wrote:
> On 22.11.19 20:58, Dmitry Torokhov wrote:
> 
> > KEYBOARD_GPIO depends on GPIOLIB and "select" does not propagate
> > dependencies, so you may still end up with invalid configs...
> 
> Sure that they don't propagate ? In this case, I've got yet
> another todo ... :o

Yes, I am sure.

Patch
diff mbox series

diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 7d9ae394e597..99d263177d8d 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -813,7 +813,8 @@  config INPUT_IDEAPAD_SLIDEBAR
 
 config INPUT_SOC_BUTTON_ARRAY
 	tristate "Windows-compatible SoC Button Array"
-	depends on KEYBOARD_GPIO && ACPI
+	depends on ACPI
+	select KEYBOARD_GPIO
 	help
 	  Say Y here if you have a SoC-based tablet that originally runs
 	  Windows 8 or a Microsoft Surface Book 2, Pro 5, Laptop 1 or later.