| Message ID | 20191121162340.11049-1-clg@kaod.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ppc/pnv: Create BMC devices at machine init | expand |
On Thu, Nov 21, 2019 at 05:23:40PM +0100, Cédric Le Goater wrote: > The BMC of the OpenPOWER systems monitors the machine state using > sensors, controls the power and controls the access to the PNOR flash > device containing the firmware image required to boot the host. > > QEMU models the power cycle process, access to the sensors and access > to the PNOR device. But, for these features to be available, the QEMU > PowerNV machine needs two extras devices on the command line, an IPMI > BT device for communication and a BMC backend device: > > -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10 > > The BMC properties are then defined accordingly in the device tree and > OPAL self adapts. If a BMC device and an IPMI BT device are not > available, OPAL does not try to communicate with the BMC in any > manner. This is not how real systems behave. > > To be closer to the default behavior, create an IPMI BMC simulator > device and an IPMI BT device at machine initialization time. We loose > the ability to define an external BMC device but there are benefits: > > - a better match with real systems, > - a better test coverage of the OPAL code, > - system powerdown and reset commands that work, > - a QEMU device tree compliant with the specifications (*). > > (*) Still needs a MBOX device. > > Signed-off-by: Cédric Le Goater <clg@kaod.org> Acked-by: Corey Minyard <cminyard@mvista.com> > --- > > Changes since v1: > > - renamed ipmi_bt_init() to pnv_ipmi_bt_init() > > include/hw/ppc/pnv.h | 2 +- > hw/ppc/pnv.c | 33 ++++++++++++++++----------------- > hw/ppc/pnv_bmc.c | 20 +++++++++++++++++--- > 3 files changed, 34 insertions(+), 21 deletions(-) > > diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h > index 07c56c05ad30..90f1343ed07c 100644 > --- a/include/hw/ppc/pnv.h > +++ b/include/hw/ppc/pnv.h > @@ -198,7 +198,7 @@ static inline bool pnv_is_power9(PnvMachineState *pnv) > */ > void pnv_dt_bmc_sensors(IPMIBmc *bmc, void *fdt); > void pnv_bmc_powerdown(IPMIBmc *bmc); > -int pnv_bmc_hiomap(IPMIBmc *bmc); > +IPMIBmc *pnv_bmc_create(void); > > /* > * POWER8 MMIO base addresses > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c > index c3ac0d6d5b4a..f0adb06c8d65 100644 > --- a/hw/ppc/pnv.c > +++ b/hw/ppc/pnv.c > @@ -551,27 +551,10 @@ static void pnv_powerdown_notify(Notifier *n, void *opaque) > > static void pnv_reset(MachineState *machine) > { > - PnvMachineState *pnv = PNV_MACHINE(machine); > void *fdt; > - Object *obj; > > qemu_devices_reset(); > > - /* > - * OpenPOWER systems have a BMC, which can be defined on the > - * command line with: > - * > - * -device ipmi-bmc-sim,id=bmc0 > - * > - * This is the internal simulator but it could also be an external > - * BMC. > - */ > - obj = object_resolve_path_type("", "ipmi-bmc-sim", NULL); > - if (obj) { > - pnv->bmc = IPMI_BMC(obj); > - pnv_bmc_hiomap(pnv->bmc); > - } > - > fdt = pnv_dt_create(machine); > > /* Pack resulting tree */ > @@ -629,6 +612,16 @@ static bool pnv_match_cpu(const char *default_type, const char *cpu_type) > return ppc_default->pvr_match(ppc_default, ppc->pvr); > } > > +static void pnv_ipmi_bt_init(ISABus *bus, IPMIBmc *bmc, uint32_t irq) > +{ > + Object *obj; > + > + obj = OBJECT(isa_create(bus, "isa-ipmi-bt")); > + object_property_set_link(obj, OBJECT(bmc), "bmc", &error_fatal); > + object_property_set_int(obj, irq, "irq", &error_fatal); > + object_property_set_bool(obj, true, "realized", &error_fatal); > +} > + > static void pnv_init(MachineState *machine) > { > PnvMachineState *pnv = PNV_MACHINE(machine); > @@ -751,6 +744,9 @@ static void pnv_init(MachineState *machine) > } > g_free(chip_typename); > > + /* Create the machine BMC simulator */ > + pnv->bmc = pnv_bmc_create(); > + > /* Instantiate ISA bus on chip 0 */ > pnv->isa_bus = pnv_isa_create(pnv->chips[0], &error_fatal); > > @@ -760,6 +756,9 @@ static void pnv_init(MachineState *machine) > /* Create an RTC ISA device too */ > mc146818_rtc_init(pnv->isa_bus, 2000, NULL); > > + /* Create the IPMI BT device for communication with the BMC */ > + pnv_ipmi_bt_init(pnv->isa_bus, pnv->bmc, 10); > + > /* > * OpenPOWER systems use a IPMI SEL Event message to notify the > * host to powerdown > diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c > index aa5c89586c63..07fa1e1c7e45 100644 > --- a/hw/ppc/pnv_bmc.c > +++ b/hw/ppc/pnv_bmc.c > @@ -17,6 +17,8 @@ > */ > > #include "qemu/osdep.h" > +#include "qemu-common.h" > +#include "qapi/error.h" > #include "target/ppc/cpu.h" > #include "qemu/log.h" > #include "hw/ipmi/ipmi.h" > @@ -211,8 +213,20 @@ static const IPMINetfn hiomap_netfn = { > .cmd_handlers = hiomap_cmds > }; > > -int pnv_bmc_hiomap(IPMIBmc *bmc) > +/* > + * Instantiate the machine BMC. PowerNV uses the QEMU internal > + * simulator but it could also be external. > + */ > +IPMIBmc *pnv_bmc_create(void) > { > - return ipmi_sim_register_netfn(IPMI_BMC_SIMULATOR(bmc), > - IPMI_NETFN_OEM, &hiomap_netfn); > + Object *obj; > + > + obj = object_new(TYPE_IPMI_BMC_SIMULATOR); > + object_property_set_bool(obj, true, "realized", &error_fatal); > + > + /* Install the HIOMAP protocol handlers to access the PNOR */ > + ipmi_sim_register_netfn(IPMI_BMC_SIMULATOR(obj), IPMI_NETFN_OEM, > + &hiomap_netfn); > + > + return IPMI_BMC(obj); > } > -- > 2.21.0 >
On Thu, Nov 21, 2019 at 05:23:40PM +0100, Cédric Le Goater wrote: > The BMC of the OpenPOWER systems monitors the machine state using > sensors, controls the power and controls the access to the PNOR flash > device containing the firmware image required to boot the host. > > QEMU models the power cycle process, access to the sensors and access > to the PNOR device. But, for these features to be available, the QEMU > PowerNV machine needs two extras devices on the command line, an IPMI > BT device for communication and a BMC backend device: > > -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10 > > The BMC properties are then defined accordingly in the device tree and > OPAL self adapts. If a BMC device and an IPMI BT device are not > available, OPAL does not try to communicate with the BMC in any > manner. This is not how real systems behave. > > To be closer to the default behavior, create an IPMI BMC simulator > device and an IPMI BT device at machine initialization time. We loose > the ability to define an external BMC device but there are benefits: > > - a better match with real systems, > - a better test coverage of the OPAL code, > - system powerdown and reset commands that work, > - a QEMU device tree compliant with the specifications (*). > > (*) Still needs a MBOX device. > > Signed-off-by: Cédric Le Goater <clg@kaod.org> Applied to ppc-for-5.0. > --- > > Changes since v1: > > - renamed ipmi_bt_init() to pnv_ipmi_bt_init() > > include/hw/ppc/pnv.h | 2 +- > hw/ppc/pnv.c | 33 ++++++++++++++++----------------- > hw/ppc/pnv_bmc.c | 20 +++++++++++++++++--- > 3 files changed, 34 insertions(+), 21 deletions(-) > > diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h > index 07c56c05ad30..90f1343ed07c 100644 > --- a/include/hw/ppc/pnv.h > +++ b/include/hw/ppc/pnv.h > @@ -198,7 +198,7 @@ static inline bool pnv_is_power9(PnvMachineState *pnv) > */ > void pnv_dt_bmc_sensors(IPMIBmc *bmc, void *fdt); > void pnv_bmc_powerdown(IPMIBmc *bmc); > -int pnv_bmc_hiomap(IPMIBmc *bmc); > +IPMIBmc *pnv_bmc_create(void); > > /* > * POWER8 MMIO base addresses > diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c > index c3ac0d6d5b4a..f0adb06c8d65 100644 > --- a/hw/ppc/pnv.c > +++ b/hw/ppc/pnv.c > @@ -551,27 +551,10 @@ static void pnv_powerdown_notify(Notifier *n, void *opaque) > > static void pnv_reset(MachineState *machine) > { > - PnvMachineState *pnv = PNV_MACHINE(machine); > void *fdt; > - Object *obj; > > qemu_devices_reset(); > > - /* > - * OpenPOWER systems have a BMC, which can be defined on the > - * command line with: > - * > - * -device ipmi-bmc-sim,id=bmc0 > - * > - * This is the internal simulator but it could also be an external > - * BMC. > - */ > - obj = object_resolve_path_type("", "ipmi-bmc-sim", NULL); > - if (obj) { > - pnv->bmc = IPMI_BMC(obj); > - pnv_bmc_hiomap(pnv->bmc); > - } > - > fdt = pnv_dt_create(machine); > > /* Pack resulting tree */ > @@ -629,6 +612,16 @@ static bool pnv_match_cpu(const char *default_type, const char *cpu_type) > return ppc_default->pvr_match(ppc_default, ppc->pvr); > } > > +static void pnv_ipmi_bt_init(ISABus *bus, IPMIBmc *bmc, uint32_t irq) > +{ > + Object *obj; > + > + obj = OBJECT(isa_create(bus, "isa-ipmi-bt")); > + object_property_set_link(obj, OBJECT(bmc), "bmc", &error_fatal); > + object_property_set_int(obj, irq, "irq", &error_fatal); > + object_property_set_bool(obj, true, "realized", &error_fatal); > +} > + > static void pnv_init(MachineState *machine) > { > PnvMachineState *pnv = PNV_MACHINE(machine); > @@ -751,6 +744,9 @@ static void pnv_init(MachineState *machine) > } > g_free(chip_typename); > > + /* Create the machine BMC simulator */ > + pnv->bmc = pnv_bmc_create(); > + > /* Instantiate ISA bus on chip 0 */ > pnv->isa_bus = pnv_isa_create(pnv->chips[0], &error_fatal); > > @@ -760,6 +756,9 @@ static void pnv_init(MachineState *machine) > /* Create an RTC ISA device too */ > mc146818_rtc_init(pnv->isa_bus, 2000, NULL); > > + /* Create the IPMI BT device for communication with the BMC */ > + pnv_ipmi_bt_init(pnv->isa_bus, pnv->bmc, 10); > + > /* > * OpenPOWER systems use a IPMI SEL Event message to notify the > * host to powerdown > diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c > index aa5c89586c63..07fa1e1c7e45 100644 > --- a/hw/ppc/pnv_bmc.c > +++ b/hw/ppc/pnv_bmc.c > @@ -17,6 +17,8 @@ > */ > > #include "qemu/osdep.h" > +#include "qemu-common.h" > +#include "qapi/error.h" > #include "target/ppc/cpu.h" > #include "qemu/log.h" > #include "hw/ipmi/ipmi.h" > @@ -211,8 +213,20 @@ static const IPMINetfn hiomap_netfn = { > .cmd_handlers = hiomap_cmds > }; > > -int pnv_bmc_hiomap(IPMIBmc *bmc) > +/* > + * Instantiate the machine BMC. PowerNV uses the QEMU internal > + * simulator but it could also be external. > + */ > +IPMIBmc *pnv_bmc_create(void) > { > - return ipmi_sim_register_netfn(IPMI_BMC_SIMULATOR(bmc), > - IPMI_NETFN_OEM, &hiomap_netfn); > + Object *obj; > + > + obj = object_new(TYPE_IPMI_BMC_SIMULATOR); > + object_property_set_bool(obj, true, "realized", &error_fatal); > + > + /* Install the HIOMAP protocol handlers to access the PNOR */ > + ipmi_sim_register_netfn(IPMI_BMC_SIMULATOR(obj), IPMI_NETFN_OEM, > + &hiomap_netfn); > + > + return IPMI_BMC(obj); > }
Hi Cédric, On Thu, Nov 21, 2019 at 05:23:40PM +0100, Cédric Le Goater wrote: > The BMC of the OpenPOWER systems monitors the machine state using > sensors, controls the power and controls the access to the PNOR flash > device containing the firmware image required to boot the host. > > QEMU models the power cycle process, access to the sensors and access > to the PNOR device. But, for these features to be available, the QEMU > PowerNV machine needs two extras devices on the command line, an IPMI > BT device for communication and a BMC backend device: > > -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10 > > The BMC properties are then defined accordingly in the device tree and > OPAL self adapts. If a BMC device and an IPMI BT device are not > available, OPAL does not try to communicate with the BMC in any > manner. This is not how real systems behave. > > To be closer to the default behavior, create an IPMI BMC simulator > device and an IPMI BT device at machine initialization time. We loose > the ability to define an external BMC device but there are benefits: > > - a better match with real systems, > - a better test coverage of the OPAL code, > - system powerdown and reset commands that work, > - a QEMU device tree compliant with the specifications (*). > > (*) Still needs a MBOX device. > > Signed-off-by: Cédric Le Goater <clg@kaod.org> I just started testing QEMU v5.0.0-rc1 against the little Linux booting framework that I helped set up for ClangBuiltLinux and this commit has caused some problems because we specify the exact same devices as you note in the commit message: https://github.com/ClangBuiltLinux/boot-utils/blob/5d9d3f626940a6a176c080717a367c1599f63680/boot-qemu.sh#L154-L155 $ timeout 3m unbuffer qemu-system-ppc64 -device ipmi-bmc-sim,id=bmc0 \ -device isa-ipmi-bt,bmc=bmc0,irq=10 \ -L images/ppc64le/ \ -bios skiboot.lid \ -machine powernv \ -display none \ -initrd images/ppc64le/rootfs.cpio \ -kernel zImage.epapr \ -m 2G \ -serial mon:stdio qemu-system-ppc64: error creating device tree: node: FDT_ERR_EXISTS It seems to me like if the machine is silently creating these devices, it should just warn that the user is trying to create a device that already exists? If not, then I assume I will just need to hack up a check for QEMU 5.0.0+ and just not add those devices? We use that script with QEMU 3.1.0 in our CI and I use it locally with QEMU 4.2.0 so universally getting rid of them doesn't seem logical. Curious for your thoughts on what to do and cheers, Nathan
On 4/4/20 9:17 AM, Nathan Chancellor wrote: > Hi Cédric, > > On Thu, Nov 21, 2019 at 05:23:40PM +0100, Cédric Le Goater wrote: >> The BMC of the OpenPOWER systems monitors the machine state using >> sensors, controls the power and controls the access to the PNOR flash >> device containing the firmware image required to boot the host. >> >> QEMU models the power cycle process, access to the sensors and access >> to the PNOR device. But, for these features to be available, the QEMU >> PowerNV machine needs two extras devices on the command line, an IPMI >> BT device for communication and a BMC backend device: >> >> -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10 >> >> The BMC properties are then defined accordingly in the device tree and >> OPAL self adapts. If a BMC device and an IPMI BT device are not >> available, OPAL does not try to communicate with the BMC in any >> manner. This is not how real systems behave. >> >> To be closer to the default behavior, create an IPMI BMC simulator >> device and an IPMI BT device at machine initialization time. We loose >> the ability to define an external BMC device but there are benefits: >> >> - a better match with real systems, >> - a better test coverage of the OPAL code, >> - system powerdown and reset commands that work, >> - a QEMU device tree compliant with the specifications (*). >> >> (*) Still needs a MBOX device. >> >> Signed-off-by: Cédric Le Goater <clg@kaod.org> > > I just started testing QEMU v5.0.0-rc1 against the little Linux booting > framework that I helped set up for ClangBuiltLinux and this commit has > caused some problems because we specify the exact same devices as you > note in the commit message: > > https://github.com/ClangBuiltLinux/boot-utils/blob/5d9d3f626940a6a176c080717a367c1599f63680/boot-qemu.sh#L154-L155 > > $ timeout 3m unbuffer qemu-system-ppc64 -device ipmi-bmc-sim,id=bmc0 \ > -device isa-ipmi-bt,bmc=bmc0,irq=10 \ > -L images/ppc64le/ \ > -bios skiboot.lid \ > -machine powernv \ > -display none \ > -initrd images/ppc64le/rootfs.cpio \ > -kernel zImage.epapr \ > -m 2G \ > -serial mon:stdio > qemu-system-ppc64: error creating device tree: node: FDT_ERR_EXISTS sigh ... > It seems to me like if the machine is silently creating these devices, yes. It now does at the machine init time. > it should just warn that the user is trying to create a device that > already exists? That is more complex because the machine only knows very late about the user created devices, at reset time. We could check this specific case (two sets of IPMI devices) and warn the user before exiting. > If not, then I assume I will just need to hack up a check for QEMU > 5.0.0+ and just not add those devices? May be we can improve the behavior. See below. > We use that script with QEMU 3.1.0 in our CI and I use it locally > with QEMU 4.2.0 so universally getting rid of them doesn't seem > logical. > > Curious for your thoughts on what to do and cheers, A solution might be to tie theses default IPMI devices to defaults_enabled(). Which means that to create a custom set of devices you would need to use -nodefaults now. Would that be OK ? Creating these devices at reset would be much easier but it is considered a bad practice to do so. Any other ideas ? Thanks, C.
Hello Nathan, Some comments on the command line. > $ timeout 3m unbuffer qemu-system-ppc64 -device ipmi-bmc-sim,id=bmc0 \ > -device isa-ipmi-bt,bmc=bmc0,irq=10 \ > -L images/ppc64le/ \ > -bios skiboot.lid \ > -machine powernv \ powernv8 or powernv9 specifies the POWER chip. > -display none \ I use -nograpĥics. > -initrd images/ppc64le/rootfs.cpio \ > -kernel zImage.epapr \ > -m 2G \ you can add adapters now on QEMU-5.0: -device ich9-ahci,id=sata0,bus=pcie.1,addr=0x0 \ -drive file=./ubuntu-ppc64le-powernv.qcow2,if=none,id=drive0,format=qcow2,cache=none \ -device ide-hd,bus=sata0.0,unit=0,drive=drive0,id=ide,bootindex=1 \ -device e1000e,netdev=net0,mac=C0:FF:EE:00:01:03,bus=pcie.2,addr=0x0 \ -netdev bridge,helper=/usr/libexec/qemu-bridge-helper,br=virbr0,id=net0 you can also add : -drive file=./witherspoon.pnor,format=raw,if=mtd to map a PNOR on the LPC address space. I have sent a patch fixing the issue you reported but you will need to add -nodefaults now. I think this is the good direction. It would be interesting for me if you could test it. Thanks, C.
diff --git a/include/hw/ppc/pnv.h b/include/hw/ppc/pnv.h index 07c56c05ad30..90f1343ed07c 100644 --- a/include/hw/ppc/pnv.h +++ b/include/hw/ppc/pnv.h @@ -198,7 +198,7 @@ static inline bool pnv_is_power9(PnvMachineState *pnv) */ void pnv_dt_bmc_sensors(IPMIBmc *bmc, void *fdt); void pnv_bmc_powerdown(IPMIBmc *bmc); -int pnv_bmc_hiomap(IPMIBmc *bmc); +IPMIBmc *pnv_bmc_create(void); /* * POWER8 MMIO base addresses diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index c3ac0d6d5b4a..f0adb06c8d65 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -551,27 +551,10 @@ static void pnv_powerdown_notify(Notifier *n, void *opaque) static void pnv_reset(MachineState *machine) { - PnvMachineState *pnv = PNV_MACHINE(machine); void *fdt; - Object *obj; qemu_devices_reset(); - /* - * OpenPOWER systems have a BMC, which can be defined on the - * command line with: - * - * -device ipmi-bmc-sim,id=bmc0 - * - * This is the internal simulator but it could also be an external - * BMC. - */ - obj = object_resolve_path_type("", "ipmi-bmc-sim", NULL); - if (obj) { - pnv->bmc = IPMI_BMC(obj); - pnv_bmc_hiomap(pnv->bmc); - } - fdt = pnv_dt_create(machine); /* Pack resulting tree */ @@ -629,6 +612,16 @@ static bool pnv_match_cpu(const char *default_type, const char *cpu_type) return ppc_default->pvr_match(ppc_default, ppc->pvr); } +static void pnv_ipmi_bt_init(ISABus *bus, IPMIBmc *bmc, uint32_t irq) +{ + Object *obj; + + obj = OBJECT(isa_create(bus, "isa-ipmi-bt")); + object_property_set_link(obj, OBJECT(bmc), "bmc", &error_fatal); + object_property_set_int(obj, irq, "irq", &error_fatal); + object_property_set_bool(obj, true, "realized", &error_fatal); +} + static void pnv_init(MachineState *machine) { PnvMachineState *pnv = PNV_MACHINE(machine); @@ -751,6 +744,9 @@ static void pnv_init(MachineState *machine) } g_free(chip_typename); + /* Create the machine BMC simulator */ + pnv->bmc = pnv_bmc_create(); + /* Instantiate ISA bus on chip 0 */ pnv->isa_bus = pnv_isa_create(pnv->chips[0], &error_fatal); @@ -760,6 +756,9 @@ static void pnv_init(MachineState *machine) /* Create an RTC ISA device too */ mc146818_rtc_init(pnv->isa_bus, 2000, NULL); + /* Create the IPMI BT device for communication with the BMC */ + pnv_ipmi_bt_init(pnv->isa_bus, pnv->bmc, 10); + /* * OpenPOWER systems use a IPMI SEL Event message to notify the * host to powerdown diff --git a/hw/ppc/pnv_bmc.c b/hw/ppc/pnv_bmc.c index aa5c89586c63..07fa1e1c7e45 100644 --- a/hw/ppc/pnv_bmc.c +++ b/hw/ppc/pnv_bmc.c @@ -17,6 +17,8 @@ */ #include "qemu/osdep.h" +#include "qemu-common.h" +#include "qapi/error.h" #include "target/ppc/cpu.h" #include "qemu/log.h" #include "hw/ipmi/ipmi.h" @@ -211,8 +213,20 @@ static const IPMINetfn hiomap_netfn = { .cmd_handlers = hiomap_cmds }; -int pnv_bmc_hiomap(IPMIBmc *bmc) +/* + * Instantiate the machine BMC. PowerNV uses the QEMU internal + * simulator but it could also be external. + */ +IPMIBmc *pnv_bmc_create(void) { - return ipmi_sim_register_netfn(IPMI_BMC_SIMULATOR(bmc), - IPMI_NETFN_OEM, &hiomap_netfn); + Object *obj; + + obj = object_new(TYPE_IPMI_BMC_SIMULATOR); + object_property_set_bool(obj, true, "realized", &error_fatal); + + /* Install the HIOMAP protocol handlers to access the PNOR */ + ipmi_sim_register_netfn(IPMI_BMC_SIMULATOR(obj), IPMI_NETFN_OEM, + &hiomap_netfn); + + return IPMI_BMC(obj); }
The BMC of the OpenPOWER systems monitors the machine state using sensors, controls the power and controls the access to the PNOR flash device containing the firmware image required to boot the host. QEMU models the power cycle process, access to the sensors and access to the PNOR device. But, for these features to be available, the QEMU PowerNV machine needs two extras devices on the command line, an IPMI BT device for communication and a BMC backend device: -device ipmi-bmc-sim,id=bmc0 -device isa-ipmi-bt,bmc=bmc0,irq=10 The BMC properties are then defined accordingly in the device tree and OPAL self adapts. If a BMC device and an IPMI BT device are not available, OPAL does not try to communicate with the BMC in any manner. This is not how real systems behave. To be closer to the default behavior, create an IPMI BMC simulator device and an IPMI BT device at machine initialization time. We loose the ability to define an external BMC device but there are benefits: - a better match with real systems, - a better test coverage of the OPAL code, - system powerdown and reset commands that work, - a QEMU device tree compliant with the specifications (*). (*) Still needs a MBOX device. Signed-off-by: Cédric Le Goater <clg@kaod.org> --- Changes since v1: - renamed ipmi_bt_init() to pnv_ipmi_bt_init() include/hw/ppc/pnv.h | 2 +- hw/ppc/pnv.c | 33 ++++++++++++++++----------------- hw/ppc/pnv_bmc.c | 20 +++++++++++++++++--- 3 files changed, 34 insertions(+), 21 deletions(-)