| Message ID | 20191122083704.29267-1-mh@glandium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] revision: clear the topo-walk flags in reset_revision_walk | expand |
On 11/22/2019 3:37 AM, Mike Hommey wrote: > Not doing so can lead to wrong topo-walks when using the revision walk API > consecutively. > > Signed-off-by: Mike Hommey <mh@glandium.org> > --- > revision.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > As mentioned in 20191108025007.bphr7ynvskeoe6tb@glandium.org, it feels > like maybe TOPO_WALK_EXPLORED and TOPO_WALK_INDEGREE should be in > ALL_REV_FLAGS too? > > diff --git a/revision.c b/revision.c > index 0e39b2b8a5..765a56ae33 100644 > --- a/revision.c > +++ b/revision.c > @@ -3098,7 +3098,7 @@ static void set_children(struct rev_info *revs) > > void reset_revision_walk(void) > { > - clear_object_flags(SEEN | ADDED | SHOWN); > + clear_object_flags(SEEN | ADDED | SHOWN | TOPO_WALK_EXPLORED | TOPO_WALK_INDEGREE); Looks good. Thanks for catching and fixing this! -Stolee
diff --git a/revision.c b/revision.c index 0e39b2b8a5..765a56ae33 100644 --- a/revision.c +++ b/revision.c @@ -3098,7 +3098,7 @@ static void set_children(struct rev_info *revs) void reset_revision_walk(void) { - clear_object_flags(SEEN | ADDED | SHOWN); + clear_object_flags(SEEN | ADDED | SHOWN | TOPO_WALK_EXPLORED | TOPO_WALK_INDEGREE); } static int mark_uninteresting(const struct object_id *oid,
Not doing so can lead to wrong topo-walks when using the revision walk API consecutively. Signed-off-by: Mike Hommey <mh@glandium.org> --- revision.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) As mentioned in 20191108025007.bphr7ynvskeoe6tb@glandium.org, it feels like maybe TOPO_WALK_EXPLORED and TOPO_WALK_INDEGREE should be in ALL_REV_FLAGS too?