| Message ID | 20191122104505.8986-6-vidyas@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for PCIe endpoint mode in Tegra194 | expand |
On Fri, Nov 22, 2019 at 04:15:04PM +0530, Vidya Sagar wrote: > Enable GPIO controllers nodes for P2972-0000 platform which are required > by other controllers in the SoC for example when PCIe C5 controller > operates in endpoint mode. > > Signed-off-by: Vidya Sagar <vidyas@nvidia.com> > --- > arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) The GPIO controllers are enabled by default, so there's no need to explicitly enable them. Thierry > > diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts > index 353a6a22196d..7eb64b816e08 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts > +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts > @@ -37,6 +37,14 @@ > status = "okay"; > }; > > + gpio@2200000 { > + status = "okay"; > + }; > + > + gpio@c2f0000 { > + status = "okay"; > + }; > + > pwm@c340000 { > status = "okay"; > }; > -- > 2.17.1 >
On 11/22/2019 6:50 PM, Thierry Reding wrote: > On Fri, Nov 22, 2019 at 04:15:04PM +0530, Vidya Sagar wrote: >> Enable GPIO controllers nodes for P2972-0000 platform which are required >> by other controllers in the SoC for example when PCIe C5 controller >> operates in endpoint mode. >> >> Signed-off-by: Vidya Sagar <vidyas@nvidia.com> >> --- >> arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 8 ++++++++ >> 1 file changed, 8 insertions(+) > > The GPIO controllers are enabled by default, so there's no need to > explicitly enable them. Yup. I'll remove this patch. Since I didn't see 'status' entry in GPIO nodes in tegra194.dtsi file, I thought it means 'disabled'. But, contrary to my understanding, absence of 'status' entry seems to mean 'okay'. - Vidya Sagar > > Thierry > >> >> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts >> index 353a6a22196d..7eb64b816e08 100644 >> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts >> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts >> @@ -37,6 +37,14 @@ >> status = "okay"; >> }; >> >> + gpio@2200000 { >> + status = "okay"; >> + }; >> + >> + gpio@c2f0000 { >> + status = "okay"; >> + }; >> + >> pwm@c340000 { >> status = "okay"; >> }; >> -- >> 2.17.1 >>
diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts index 353a6a22196d..7eb64b816e08 100644 --- a/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts @@ -37,6 +37,14 @@ status = "okay"; }; + gpio@2200000 { + status = "okay"; + }; + + gpio@c2f0000 { + status = "okay"; + }; + pwm@c340000 { status = "okay"; };
Enable GPIO controllers nodes for P2972-0000 platform which are required by other controllers in the SoC for example when PCIe C5 controller operates in endpoint mode. Signed-off-by: Vidya Sagar <vidyas@nvidia.com> --- arch/arm64/boot/dts/nvidia/tegra194-p2972-0000.dts | 8 ++++++++ 1 file changed, 8 insertions(+)