| Message ID | 20191123155508.15769-1-jpittman@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3] xfsprogs: add missing line feeds in libxfs/rdwr.c | expand |
On Sat, Nov 23, 2019 at 4:55 PM John Pittman <jpittman@redhat.com> wrote: > > In libxfs/rdwr.c, there are several fprintf() calls that are > missing trailing line feeds. This translates to the following > CLI prompt being on the same line as the message. Add missing > line feeds, alleviating the issue. > > Fixes: 0a7942b38215 ("libxfs: don't discard dirty buffers") > Signed-off-by: John Pittman <jpittman@redhat.com> > --- > libxfs/rdwr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c > index 7080cd9c..3f69192d 100644 > --- a/libxfs/rdwr.c > +++ b/libxfs/rdwr.c > @@ -651,7 +651,7 @@ __libxfs_getbufr(int blen) > pthread_mutex_unlock(&xfs_buf_freelist.cm_mutex); > bp->b_ops = NULL; > if (bp->b_flags & LIBXFS_B_DIRTY) > - fprintf(stderr, "found dirty buffer (bulk) on free list!"); > + fprintf(stderr, "found dirty buffer (bulk) on free list!\n"); > > return bp; > } > @@ -1224,7 +1224,7 @@ libxfs_brelse( > return; > if (bp->b_flags & LIBXFS_B_DIRTY) > fprintf(stderr, > - "releasing dirty buffer to free list!"); > + "releasing dirty buffer to free list!\n"); > > pthread_mutex_lock(&xfs_buf_freelist.cm_mutex); > list_add(&bp->b_node.cn_mru, &xfs_buf_freelist.cm_list); > @@ -1245,7 +1245,7 @@ libxfs_bulkrelse( > list_for_each_entry(bp, list, b_node.cn_mru) { > if (bp->b_flags & LIBXFS_B_DIRTY) > fprintf(stderr, > - "releasing dirty buffer (bulk) to free list!"); > + "releasing dirty buffer (bulk) to free list!\n"); > count++; > } > > -- > 2.17.2 > Hi John, thanks for the update. Reviewed-by: Pavel Reichl <preichl@redhat.com>
On Sat, Nov 23, 2019 at 10:55:08AM -0500, John Pittman wrote: > In libxfs/rdwr.c, there are several fprintf() calls that are > missing trailing line feeds. This translates to the following > CLI prompt being on the same line as the message. Add missing > line feeds, alleviating the issue. > > Fixes: 0a7942b38215 ("libxfs: don't discard dirty buffers") > Signed-off-by: John Pittman <jpittman@redhat.com> Looks good. Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> > --- > libxfs/rdwr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c > index 7080cd9c..3f69192d 100644 > --- a/libxfs/rdwr.c > +++ b/libxfs/rdwr.c > @@ -651,7 +651,7 @@ __libxfs_getbufr(int blen) > pthread_mutex_unlock(&xfs_buf_freelist.cm_mutex); > bp->b_ops = NULL; > if (bp->b_flags & LIBXFS_B_DIRTY) > - fprintf(stderr, "found dirty buffer (bulk) on free list!"); > + fprintf(stderr, "found dirty buffer (bulk) on free list!\n"); > > return bp; > } > @@ -1224,7 +1224,7 @@ libxfs_brelse( > return; > if (bp->b_flags & LIBXFS_B_DIRTY) > fprintf(stderr, > - "releasing dirty buffer to free list!"); > + "releasing dirty buffer to free list!\n"); > > pthread_mutex_lock(&xfs_buf_freelist.cm_mutex); > list_add(&bp->b_node.cn_mru, &xfs_buf_freelist.cm_list); > @@ -1245,7 +1245,7 @@ libxfs_bulkrelse( > list_for_each_entry(bp, list, b_node.cn_mru) { > if (bp->b_flags & LIBXFS_B_DIRTY) > fprintf(stderr, > - "releasing dirty buffer (bulk) to free list!"); > + "releasing dirty buffer (bulk) to free list!\n"); > count++; > } > > -- > 2.17.2 >
On Sat, Nov 23, 2019 at 10:55:08AM -0500, John Pittman wrote: > In libxfs/rdwr.c, there are several fprintf() calls that are > missing trailing line feeds. This translates to the following > CLI prompt being on the same line as the message. Add missing > line feeds, alleviating the issue. > > Fixes: 0a7942b38215 ("libxfs: don't discard dirty buffers") > Signed-off-by: John Pittman <jpittman@redhat.com> Despite my Reviewed-by previously, next patches, please don't forget to also provide the changelog for your Vx patches. > --- ^ Changelogs should go below this line, so they are not propagated to the git tree, but it's really helpful to understand why you needed to send new versions. Cheers. > libxfs/rdwr.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c > index 7080cd9c..3f69192d 100644 > --- a/libxfs/rdwr.c > +++ b/libxfs/rdwr.c > @@ -651,7 +651,7 @@ __libxfs_getbufr(int blen) > pthread_mutex_unlock(&xfs_buf_freelist.cm_mutex); > bp->b_ops = NULL; > if (bp->b_flags & LIBXFS_B_DIRTY) > - fprintf(stderr, "found dirty buffer (bulk) on free list!"); > + fprintf(stderr, "found dirty buffer (bulk) on free list!\n"); > > return bp; > } > @@ -1224,7 +1224,7 @@ libxfs_brelse( > return; > if (bp->b_flags & LIBXFS_B_DIRTY) > fprintf(stderr, > - "releasing dirty buffer to free list!"); > + "releasing dirty buffer to free list!\n"); > > pthread_mutex_lock(&xfs_buf_freelist.cm_mutex); > list_add(&bp->b_node.cn_mru, &xfs_buf_freelist.cm_list); > @@ -1245,7 +1245,7 @@ libxfs_bulkrelse( > list_for_each_entry(bp, list, b_node.cn_mru) { > if (bp->b_flags & LIBXFS_B_DIRTY) > fprintf(stderr, > - "releasing dirty buffer (bulk) to free list!"); > + "releasing dirty buffer (bulk) to free list!\n"); > count++; > } > > -- > 2.17.2 >
diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c index 7080cd9c..3f69192d 100644 --- a/libxfs/rdwr.c +++ b/libxfs/rdwr.c @@ -651,7 +651,7 @@ __libxfs_getbufr(int blen) pthread_mutex_unlock(&xfs_buf_freelist.cm_mutex); bp->b_ops = NULL; if (bp->b_flags & LIBXFS_B_DIRTY) - fprintf(stderr, "found dirty buffer (bulk) on free list!"); + fprintf(stderr, "found dirty buffer (bulk) on free list!\n"); return bp; } @@ -1224,7 +1224,7 @@ libxfs_brelse( return; if (bp->b_flags & LIBXFS_B_DIRTY) fprintf(stderr, - "releasing dirty buffer to free list!"); + "releasing dirty buffer to free list!\n"); pthread_mutex_lock(&xfs_buf_freelist.cm_mutex); list_add(&bp->b_node.cn_mru, &xfs_buf_freelist.cm_list); @@ -1245,7 +1245,7 @@ libxfs_bulkrelse( list_for_each_entry(bp, list, b_node.cn_mru) { if (bp->b_flags & LIBXFS_B_DIRTY) fprintf(stderr, - "releasing dirty buffer (bulk) to free list!"); + "releasing dirty buffer (bulk) to free list!\n"); count++; }
In libxfs/rdwr.c, there are several fprintf() calls that are missing trailing line feeds. This translates to the following CLI prompt being on the same line as the message. Add missing line feeds, alleviating the issue. Fixes: 0a7942b38215 ("libxfs: don't discard dirty buffers") Signed-off-by: John Pittman <jpittman@redhat.com> --- libxfs/rdwr.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)