[v3,04/13] scsi: qla2xxx: Drop superfluous INIT_WORK of del_work
diff mbox series

Message ID 20191125165702.1013-5-r.bolshakov@yadro.com
State Accepted
Commit 600954e6f2df695434887dfc6a99a098859990cf
Headers show
Series
  • scsi: qla2xxx: Bug fixes
Related show

Commit Message

Roman Bolshakov Nov. 25, 2019, 4:56 p.m. UTC
del_work is already initialized inside qla2x00_alloc_fcport, there's no
need to overwrite it. Indeed, it might prevent complete traversal of
workqueue list.

Fixes: a01c77d2cbc45 ("scsi: qla2xxx: Move session delete to driver work queue")
Cc: Quinn Tran <qutran@marvell.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
 drivers/scsi/qla2xxx/qla_target.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Bart Van Assche Nov. 26, 2019, 8:56 p.m. UTC | #1
On 11/25/19 8:56 AM, Roman Bolshakov wrote:
> del_work is already initialized inside qla2x00_alloc_fcport, there's no
> need to overwrite it. Indeed, it might prevent complete traversal of
> workqueue list.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Patch
diff mbox series

diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index 74cfcb13fe8a..eeb069d52f3d 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -1265,7 +1265,6 @@  void qlt_schedule_sess_for_deletion(struct fc_port *sess)
 	    "Scheduling sess %p for deletion %8phC\n",
 	    sess, sess->port_name);
 
-	INIT_WORK(&sess->del_work, qla24xx_delete_sess_fn);
 	WARN_ON(!queue_work(sess->vha->hw->wq, &sess->del_work));
 }