[v3,07/13] scsi: qla2xxx: Don't call qlt_async_event twice
diff mbox series

Message ID 20191125165702.1013-8-r.bolshakov@yadro.com
State Accepted
Commit 2c2f4bed9b6299e6430a65a29b5d27b8763fdf25
Headers show
Series
  • scsi: qla2xxx: Bug fixes
Related show

Commit Message

Roman Bolshakov Nov. 25, 2019, 4:56 p.m. UTC
MBA_PORT_UPDATE generates duplicate log lines in target mode because
qlt_async_event is called twice. Drop the calls within the case as
the function will be called right after the switch statement.

Cc: Quinn Tran <qutran@marvell.com>
Acked-by: Himanshu Madhani <hmadhani@marvel.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
---
 drivers/scsi/qla2xxx/qla_isr.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Roman Bolshakov Nov. 25, 2019, 5 p.m. UTC | #1
On Mon, Nov 25, 2019 at 07:56:56PM +0300, Roman Bolshakov wrote:
> MBA_PORT_UPDATE generates duplicate log lines in target mode because
> qlt_async_event is called twice. Drop the calls within the case as
> the function will be called right after the switch statement.
> 
> Cc: Quinn Tran <qutran@marvell.com>
> Acked-by: Himanshu Madhani <hmadhani@marvel.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Tested-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> ---

The Acked-by tag should contain:

Acked-by: Himanshu Madhani <hmadhani@marvell.com>

Patch
diff mbox series

diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
index 1b8f297449cf..c6274178b0b0 100644
--- a/drivers/scsi/qla2xxx/qla_isr.c
+++ b/drivers/scsi/qla2xxx/qla_isr.c
@@ -1061,8 +1061,6 @@  qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
 			ql_dbg(ql_dbg_async, vha, 0x5011,
 			    "Asynchronous PORT UPDATE ignored %04x/%04x/%04x.\n",
 			    mb[1], mb[2], mb[3]);
-
-			qlt_async_event(mb[0], vha, mb);
 			break;
 		}
 
@@ -1079,8 +1077,6 @@  qla2x00_async_event(scsi_qla_host_t *vha, struct rsp_que *rsp, uint16_t *mb)
 		set_bit(LOOP_RESYNC_NEEDED, &vha->dpc_flags);
 		set_bit(LOCAL_LOOP_UPDATE, &vha->dpc_flags);
 		set_bit(VP_CONFIG_OK, &vha->vp_flags);
-
-		qlt_async_event(mb[0], vha, mb);
 		break;
 
 	case MBA_RSCN_UPDATE:		/* State Change Registration */