[v4,18/27] t7700: drop redirections to /dev/null

Message ID	c50c192429c73146b64a8c7637e89554fee4e24d.1574731022.git.liu.denton@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=BbQ7=ZS=vger.kernel.org=git-owner@kernel.org> Date: Mon, 25 Nov 2019 17:18:27 -0800 From: Denton Liu <liu.denton@gmail.com> To: Git Mailing List <git@vger.kernel.org> Cc: Eric Sunshine <sunshine@sunshineco.com>, Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net> Subject: [PATCH v4 18/27] t7700: drop redirections to /dev/null Message-ID: <c50c192429c73146b64a8c7637e89554fee4e24d.1574731022.git.liu.denton@gmail.com> References: <cover.1574449072.git.liu.denton@gmail.com> <cover.1574731022.git.liu.denton@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <cover.1574731022.git.liu.denton@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: git-owner@vger.kernel.org Precedence: bulk
Series	t: test cleanup stemming from experimentally enabling pipefail \| expand [v4,00/27] t: test cleanup stemming from experimentally enabling pipefail [v4,01/27] lib-bash.sh: move `then` onto its own line [v4,02/27] apply-one-time-sed.sh: modernize style [v4,03/27] t0014: remove git command upstream of pipe [v4,04/27] t0090: stop losing return codes of git commands [v4,05/27] t3301: stop losing return codes of git commands [v4,06/27] t3600: use test_line_count() where possible [v4,07/27] t3600: stop losing return codes of git commands [v4,08/27] t3600: comment on inducing SIGPIPE in `git rm` [v4,09/27] t4015: stop losing return codes of git commands [v4,10/27] t4015: use test_write_lines() [v4,11/27] t4138: stop losing return codes of git commands [v4,12/27] t5317: stop losing return codes of git commands [v4,13/27] t5317: use ! grep to check for no matching lines [v4,14/27] t5703: simplify one-time-sed generation logic [v4,15/27] t5703: stop losing return codes of git commands [v4,16/27] t7501: remove spaces after redirect operators [v4,17/27] t7501: stop losing return codes of git commands [v4,18/27] t7700: drop redirections to /dev/null [v4,19/27] t7700: remove spaces after redirect operators [v4,20/27] t7700: move keywords onto their own line [v4,21/27] t7700: s/test -f/test_path_is_file/ [v4,22/27] t7700: consolidate code into test_no_missing_in_packs() [v4,23/27] squash! t7700: consolidate code into test_no_missing_in_packs() [v4,24/27] t7700: consolidate code into test_has_duplicate_object() [v4,25/27] t7700: replace egrep with grep [v4,26/27] t7700: make references to SHA-1 generic [v4,27/27] t7700: stop losing return codes of git commands

Message ID

c50c192429c73146b64a8c7637e89554fee4e24d.1574731022.git.liu.denton@gmail.com (mailing list archive)

State

New, archived

Headers

Date: Mon, 25 Nov 2019 17:18:27 -0800
From: Denton Liu <liu.denton@gmail.com>
To: Git Mailing List <git@vger.kernel.org>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
        Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: [PATCH v4 18/27] t7700: drop redirections to /dev/null
Message-ID: 
 <c50c192429c73146b64a8c7637e89554fee4e24d.1574731022.git.liu.denton@gmail.com>
References: <cover.1574449072.git.liu.denton@gmail.com>
 <cover.1574731022.git.liu.denton@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1574731022.git.liu.denton@gmail.com>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: git-owner@vger.kernel.org
Precedence: bulk

Series

t: test cleanup stemming from experimentally enabling pipefail | expand

Commit Message

Denton Liu Nov. 26, 2019, 1:18 a.m. UTC

Since output is silenced when running without `-v` and debugging output
is useful with `-v`, remove redirections to /dev/null as it is not
useful.

In one case where the output of stdout is consumed, redirect the output
of test_commit to stderr.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 t/t7700-repack.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/t/t7700-repack.sh b/t/t7700-repack.sh
index 4e855bc21b..e1a689d6a9 100755
--- a/t/t7700-repack.sh
+++ b/t/t7700-repack.sh
@@ -5,7 +5,7 @@  test_description='git repack works correctly'
 . ./test-lib.sh
 
 commit_and_pack() {
-	test_commit "$@" >/dev/null &&
+	test_commit "$@" 1>&2 &&
 	SHA1=$(git pack-objects --all --unpacked --incremental .git/objects/pack/pack </dev/null) &&
 	echo pack-${SHA1}.pack
 }
@@ -19,7 +19,7 @@  test_expect_success 'objects in packs marked .keep are not repacked' '
 	# Create two packs
 	# The first pack will contain all of the objects except one
 	git rev-list --objects --all | grep -v file2 |
-		git pack-objects pack > /dev/null &&
+		git pack-objects pack &&
 	# The second pack will contain the excluded object
 	packsha1=$(git rev-list --objects --all | grep file2 |
 		git pack-objects pack) &&
@@ -235,7 +235,7 @@  test_expect_success 'incremental repack does not complain' '
 
 test_expect_success 'bitmaps can be disabled on bare repos' '
 	git -c repack.writeBitmaps=false -C bare.git repack -ad &&
-	bitmap=$(ls bare.git/objects/pack/*.bitmap 2>/dev/null || :) &&
+	bitmap=$(ls bare.git/objects/pack/*.bitmap || :) &&
 	test -z "$bitmap"
 '

[v4,18/27] t7700: drop redirections to /dev/null

Commit Message

Patch