From patchwork Tue Nov 26 09:14:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 11261669 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BF90A913 for ; Tue, 26 Nov 2019 09:14:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8D6020678 for ; Tue, 26 Nov 2019 09:14:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8D6020678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 89C9889D77; Tue, 26 Nov 2019 09:14:26 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD9F689D67 for ; Tue, 26 Nov 2019 09:14:24 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id t26so2366883wmi.4 for ; Tue, 26 Nov 2019 01:14:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=58z6PSOMQti9hB6rMQJ8CVxVdVi5QpCvXcK4eM0Ybsk=; b=fBe0s/wtc+H4mxoN3G5uOHkrPQVGVHyKOfAkARIwtef1ZwN4CWhPy1gUUBUJ2ci8jJ p9fHSnmJ8FkGQ403ByhNjuntLAnSPUJD+gw7hmTDuoHPQyy9qzJr8BL0rvQITKpV7JGJ ZOYazHQ/+uMgCeChvTcXh5s+Y874RIpM8lPRcdSYvVOMJLXGCg1WxVvCyuD6Njbz3b+y J6IgG76LOADLIcGROqzocAJKazPiq4A13mekiP9n1w/y8qSXbckSiqEi63yC/RVkq/sP sPVU59RCcyZGsJ1Or4nuECbtVbTupsrTZCLveCQhYggL/vesE9LwexUF+Ydjaxw/ZmEE f1Xw== X-Gm-Message-State: APjAAAVZrROHPPVttN5so3B82gBcQ6mvIkCwVtf5Jtl7KlTwwszX7qqy tTvuSa4m/xMp9PFcM5mP617QdCQTZ4w= X-Google-Smtp-Source: APXvYqxJ4wsYb51RXOxipePE9LEky3jPXir04HY2V2Xd6Bdg10wZF/mjX6A6ylxKgfYwAVEjkYtQRw== X-Received: by 2002:a7b:c347:: with SMTP id l7mr3256761wmj.48.1574759663031; Tue, 26 Nov 2019 01:14:23 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id j17sm14167450wrr.75.2019.11.26.01.14.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 01:14:22 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 2/2] drm/fourcc: Fill out all block sizes for P210 Date: Tue, 26 Nov 2019 10:14:14 +0100 Message-Id: <20191126091414.226070-2-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191126091414.226070-1-daniel.vetter@ffwll.ch> References: <20191126091414.226070-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=58z6PSOMQti9hB6rMQJ8CVxVdVi5QpCvXcK4eM0Ybsk=; b=SpoLGIloXoHImop2tl3rz3BLBEun0/IghfAPV9pRbgNxpaPR4s+GW6LtSV0f41E6DG btpplTK+7ybotOo/wD2srLdNN0JBeC9580x33NnGIAYVYflQpmVwKqUlTMJntcRQsMQK gyXGVrwaTW5yT7XwlOsTM5V6FY60r+EXuQuOo= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Daniel Vetter , Liviu Dudau , Ayan Kumar Halder , Alyssa Rosenzweig Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 0 means 1 as the default, but it's mighty confusing if the block size for the first plane is spelled out explicitly, but not for the 2nd plane. No cc: stable because this is just confusion, but 0 functional issue. Fixes: 7ba0fee247ee ("drm/fourcc: Add AFBC yuv fourccs for Mali") Cc: Brian Starkey Cc: Ayan Kumar Halder Cc: Liviu Dudau Cc: Alyssa Rosenzweig Cc: Maarten Lankhorst Cc: Maxime Ripard Signed-off-by: Daniel Vetter Acked-by: Liviu Dudau --- drivers/gpu/drm/drm_fourcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c index fe79ce857c8a..b234bfaeda06 100644 --- a/drivers/gpu/drm/drm_fourcc.c +++ b/drivers/gpu/drm/drm_fourcc.c @@ -263,7 +263,7 @@ const struct drm_format_info *__drm_format_info(u32 format) .hsub = 2, .vsub = 2, .is_yuv = true}, { .format = DRM_FORMAT_P210, .depth = 0, .num_planes = 2, .char_per_block = { 2, 4, 0 }, - .block_w = { 1, 0, 0 }, .block_h = { 1, 0, 0 }, .hsub = 2, + .block_w = { 1, 1, 0 }, .block_h = { 1, 1, 0 }, .hsub = 2, .vsub = 1, .is_yuv = true }, { .format = DRM_FORMAT_VUY101010, .depth = 0, .num_planes = 1, .cpp = { 0, 0, 0 }, .hsub = 1, .vsub = 1,