From patchwork Tue Nov 26 13:42:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 11262433 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 19C471390 for ; Tue, 26 Nov 2019 13:44:42 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E56622068E for ; Tue, 26 Nov 2019 13:44:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QtakxB63" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E56622068E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:55034 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZb8z-0003vD-0q for patchwork-qemu-devel@patchwork.kernel.org; Tue, 26 Nov 2019 08:44:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41752) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZb6w-0001Kd-UE for qemu-devel@nongnu.org; Tue, 26 Nov 2019 08:42:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZb6v-0001G3-W1 for qemu-devel@nongnu.org; Tue, 26 Nov 2019 08:42:34 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:23730 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iZb6v-0001Fr-Sv for qemu-devel@nongnu.org; Tue, 26 Nov 2019 08:42:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574775753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=m/dSl8gZ5jOtPI5gmWMa//FCuVvD3263xK4p+4+iDvQ=; b=QtakxB63D3hK72r5iCl5pWZRsmzFl8+2yRSzASa40wY6BYQ1k5GEqMiPKCx0Pe2tFqzgIn +Il6f/e2t5epskfX4w+miheG7niz27ZZz0KmFBGFktLoJfx5T/j70cL3tG8sDJ8asQWSKn T0emLpoyRHy5ZsOTzBpxnQ9A5EZ2MwU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-217-Xo_aRWgtNMSb4S0yin6Gxg-1; Tue, 26 Nov 2019 08:42:30 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 56B9E801E72; Tue, 26 Nov 2019 13:42:29 +0000 (UTC) Received: from linux.fritz.box.com (ovpn-117-171.ams2.redhat.com [10.36.117.171]) by smtp.corp.redhat.com (Postfix) with ESMTP id 392E5600CC; Tue, 26 Nov 2019 13:42:27 +0000 (UTC) From: Kevin Wolf To: qemu-block@nongnu.org Subject: [PATCH] blockjob: Fix error message for negative speed Date: Tue, 26 Nov 2019 14:42:22 +0100 Message-Id: <20191126134222.16340-1-kwolf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: Xo_aRWgtNMSb4S0yin6Gxg-1 X-Mimecast-Spam-Score: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" The error message for a negative speed uses QERR_INVALID_PARAMETER, which implies that the 'speed' option doesn't even exist: {"error": {"class": "GenericError", "desc": "Invalid parameter 'speed'"}} Make it use QERR_INVALID_PARAMETER_VALUE instead: {"error": {"class": "GenericError", "desc": "Parameter 'speed' expects a non-negative value"}} Signed-off-by: Kevin Wolf Reviewed-by: Alberto Garcia --- blockjob.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/blockjob.c b/blockjob.c index c6e20e2fcd..5d63b1e89d 100644 --- a/blockjob.c +++ b/blockjob.c @@ -261,7 +261,8 @@ void block_job_set_speed(BlockJob *job, int64_t speed, Error **errp) return; } if (speed < 0) { - error_setg(errp, QERR_INVALID_PARAMETER, "speed"); + error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "speed", + "a non-negative value"); return; }