drm/rect: update kerneldoc for drm_rect_clip_scaled()
diff mbox series

Message ID 20191126145213.380079-1-daniel.vetter@ffwll.ch
State New
Headers show
Series
  • drm/rect: update kerneldoc for drm_rect_clip_scaled()
Related show

Commit Message

Daniel Vetter Nov. 26, 2019, 2:52 p.m. UTC
This was forgotten in f96bdf564f3e ("drm/rect: Handle rounding errors
in drm_rect_clip_scaled, v3.")

Spotted while reviewing patches from Ville touching this area.

Fixes: f96bdf564f3e ("drm/rect: Handle rounding errors in drm_rect_clip_scaled, v3.")
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/drm_rect.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Ville Syrjala Nov. 26, 2019, 3:10 p.m. UTC | #1
On Tue, Nov 26, 2019 at 03:52:13PM +0100, Daniel Vetter wrote:
> This was forgotten in f96bdf564f3e ("drm/rect: Handle rounding errors
> in drm_rect_clip_scaled, v3.")
> 
> Spotted while reviewing patches from Ville touching this area.
> 
> Fixes: f96bdf564f3e ("drm/rect: Handle rounding errors in drm_rect_clip_scaled, v3.")
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/drm_rect.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_rect.c b/drivers/gpu/drm/drm_rect.c
> index b8363aaa9032..e6e640f2d5e3 100644
> --- a/drivers/gpu/drm/drm_rect.c
> +++ b/drivers/gpu/drm/drm_rect.c
> @@ -73,11 +73,13 @@ static u32 clip_scaled(u32 src, u32 dst, u32 clip)
>   * @clip: clip rectangle
>   *
>   * Clip rectangle @dst by rectangle @clip. Clip rectangle @src by the
> - * same amounts multiplied by @hscale and @vscale.
> + * the corresponding amounts, retaining the vertical and horizontal scaling
> + * factors from @src to @dst.
>   *
>   * RETURNS:
> + *
>   * %true if rectangle @dst is still visible after being clipped,
> - * %false otherwise
> + * %false otherwise.
>   */
>  bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst,
>  			  const struct drm_rect *clip)
> -- 
> 2.24.0
Daniel Vetter Nov. 28, 2019, 12:15 p.m. UTC | #2
On Tue, Nov 26, 2019 at 05:10:14PM +0200, Ville Syrjälä wrote:
> On Tue, Nov 26, 2019 at 03:52:13PM +0100, Daniel Vetter wrote:
> > This was forgotten in f96bdf564f3e ("drm/rect: Handle rounding errors
> > in drm_rect_clip_scaled, v3.")
> > 
> > Spotted while reviewing patches from Ville touching this area.
> > 
> > Fixes: f96bdf564f3e ("drm/rect: Handle rounding errors in drm_rect_clip_scaled, v3.")
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Benjamin Gaignard <benjamin.gaignard@st.com>
> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks for taking a look, patch pushed.
-Daniel

> 
> > ---
> >  drivers/gpu/drm/drm_rect.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/drm_rect.c b/drivers/gpu/drm/drm_rect.c
> > index b8363aaa9032..e6e640f2d5e3 100644
> > --- a/drivers/gpu/drm/drm_rect.c
> > +++ b/drivers/gpu/drm/drm_rect.c
> > @@ -73,11 +73,13 @@ static u32 clip_scaled(u32 src, u32 dst, u32 clip)
> >   * @clip: clip rectangle
> >   *
> >   * Clip rectangle @dst by rectangle @clip. Clip rectangle @src by the
> > - * same amounts multiplied by @hscale and @vscale.
> > + * the corresponding amounts, retaining the vertical and horizontal scaling
> > + * factors from @src to @dst.
> >   *
> >   * RETURNS:
> > + *
> >   * %true if rectangle @dst is still visible after being clipped,
> > - * %false otherwise
> > + * %false otherwise.
> >   */
> >  bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst,
> >  			  const struct drm_rect *clip)
> > -- 
> > 2.24.0
> 
> -- 
> Ville Syrjälä
> Intel

Patch
diff mbox series

diff --git a/drivers/gpu/drm/drm_rect.c b/drivers/gpu/drm/drm_rect.c
index b8363aaa9032..e6e640f2d5e3 100644
--- a/drivers/gpu/drm/drm_rect.c
+++ b/drivers/gpu/drm/drm_rect.c
@@ -73,11 +73,13 @@  static u32 clip_scaled(u32 src, u32 dst, u32 clip)
  * @clip: clip rectangle
  *
  * Clip rectangle @dst by rectangle @clip. Clip rectangle @src by the
- * same amounts multiplied by @hscale and @vscale.
+ * the corresponding amounts, retaining the vertical and horizontal scaling
+ * factors from @src to @dst.
  *
  * RETURNS:
+ *
  * %true if rectangle @dst is still visible after being clipped,
- * %false otherwise
+ * %false otherwise.
  */
 bool drm_rect_clip_scaled(struct drm_rect *src, struct drm_rect *dst,
 			  const struct drm_rect *clip)