diff mbox series

[PATCH-for-4.2?,v2,1/2] tests/boot_linux_console: Fetch assets from Debian snapshot archives

Message ID 20191126223810.20180-2-philmd@redhat.com (mailing list archive)
State New, archived
Headers show
Series tests/acceptance: Fix the m68k/q800 Linux test | expand

Commit Message

Philippe Mathieu-Daudé Nov. 26, 2019, 10:38 p.m. UTC
The kernel packaged was fetched from an unstable repository.
Use the stable snapshot archive instead.

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2:
- Rebased
- Dropped Alex's Tested-by tag, since commit 2ecde8b2fb got merged
  since and it changed the tested kernel version.
---
 tests/acceptance/boot_linux_console.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Willian Rampazzo Nov. 27, 2019, 2:51 p.m. UTC | #1
On Tue, Nov 26, 2019 at 7:38 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> The kernel packaged was fetched from an unstable repository.
> Use the stable snapshot archive instead.
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2:
> - Rebased
> - Dropped Alex's Tested-by tag, since commit 2ecde8b2fb got merged
>   since and it changed the tested kernel version.
> ---
>  tests/acceptance/boot_linux_console.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> index 7e41cebd47..752f776f68 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -479,7 +479,8 @@ class BootLinuxConsole(Test):
>          :avocado: tags=arch:m68k
>          :avocado: tags=machine:q800
>          """
> -        deb_url = ('http://ftp.ports.debian.org/debian-ports/pool-m68k/main'
> +        deb_url = ('https://snapshot.debian.org/archive/debian-ports'
> +                   '/20191021T083923Z/pool-m68k/main'
>                     '/l/linux/kernel-image-5.3.0-1-m68k-di_5.3.7-1_m68k.udeb')
>          deb_hash = '044954bb9be4160a3ce81f8bc1b5e856b75cccd1'
>          try:

Tested-by: Willian Rampazzo <wrampazz@redhat.com>

The code was tested and works as expected.

---
Willian
Cleber Rosa Dec. 6, 2019, 2:46 p.m. UTC | #2
On Tue, Nov 26, 2019 at 11:38:09PM +0100, Philippe Mathieu-Daudé wrote:
> The kernel packaged was fetched from an unstable repository.
> Use the stable snapshot archive instead.
> 
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2:
> - Rebased
> - Dropped Alex's Tested-by tag, since commit 2ecde8b2fb got merged
>   since and it changed the tested kernel version.
> ---
>  tests/acceptance/boot_linux_console.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> index 7e41cebd47..752f776f68 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -479,7 +479,8 @@ class BootLinuxConsole(Test):
>          :avocado: tags=arch:m68k
>          :avocado: tags=machine:q800
>          """
> -        deb_url = ('http://ftp.ports.debian.org/debian-ports/pool-m68k/main'
> +        deb_url = ('https://snapshot.debian.org/archive/debian-ports'
> +                   '/20191021T083923Z/pool-m68k/main'
>                     '/l/linux/kernel-image-5.3.0-1-m68k-di_5.3.7-1_m68k.udeb')
>          deb_hash = '044954bb9be4160a3ce81f8bc1b5e856b75cccd1'
>          try:
> -- 
> 2.21.0
> 

Works great, sorry for not picking it up earlier.  Now with rc-4, I'll
check with Peter if we can still have this on 4.2 and send a PR.

Thanks!
- Cleber.
Philippe Mathieu-Daudé Dec. 6, 2019, 3:07 p.m. UTC | #3
On Fri, Dec 6, 2019 at 3:46 PM Cleber Rosa <crosa@redhat.com> wrote:
> On Tue, Nov 26, 2019 at 11:38:09PM +0100, Philippe Mathieu-Daudé wrote:
> > The kernel packaged was fetched from an unstable repository.
> > Use the stable snapshot archive instead.
> >
> > Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > v2:
> > - Rebased
> > - Dropped Alex's Tested-by tag, since commit 2ecde8b2fb got merged
> >   since and it changed the tested kernel version.
> > ---
> >  tests/acceptance/boot_linux_console.py | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> > index 7e41cebd47..752f776f68 100644
> > --- a/tests/acceptance/boot_linux_console.py
> > +++ b/tests/acceptance/boot_linux_console.py
> > @@ -479,7 +479,8 @@ class BootLinuxConsole(Test):
> >          :avocado: tags=arch:m68k
> >          :avocado: tags=machine:q800
> >          """
> > -        deb_url = ('http://ftp.ports.debian.org/debian-ports/pool-m68k/main'
> > +        deb_url = ('https://snapshot.debian.org/archive/debian-ports'
> > +                   '/20191021T083923Z/pool-m68k/main'
> >                     '/l/linux/kernel-image-5.3.0-1-m68k-di_5.3.7-1_m68k.udeb')
> >          deb_hash = '044954bb9be4160a3ce81f8bc1b5e856b75cccd1'
> >          try:
> > --
> > 2.21.0
> >
>
> Works great, sorry for not picking it up earlier.  Now with rc-4, I'll
> check with Peter if we can still have this on 4.2 and send a PR.

Nobody complained and this is not a critical bugfix, so I'd now defer
it, to not delay 5.0 any longer.

> Thanks!
> - Cleber.
diff mbox series

Patch

diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
index 7e41cebd47..752f776f68 100644
--- a/tests/acceptance/boot_linux_console.py
+++ b/tests/acceptance/boot_linux_console.py
@@ -479,7 +479,8 @@  class BootLinuxConsole(Test):
         :avocado: tags=arch:m68k
         :avocado: tags=machine:q800
         """
-        deb_url = ('http://ftp.ports.debian.org/debian-ports/pool-m68k/main'
+        deb_url = ('https://snapshot.debian.org/archive/debian-ports'
+                   '/20191021T083923Z/pool-m68k/main'
                    '/l/linux/kernel-image-5.3.0-1-m68k-di_5.3.7-1_m68k.udeb')
         deb_hash = '044954bb9be4160a3ce81f8bc1b5e856b75cccd1'
         try: