| Message ID | 20191127124433.34301-1-yukuai3@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | f427939391f290cbeabe0231eb8a116429d823f0 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | bcma: remove set but not used variable 'sizel' | expand |
yu kuai <yukuai3@huawei.com> wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/bcma/scan.c: In function ‘bcma_erom_get_addr_desc’: > > drivers/bcma/scan.c:222:20: warning: variable ‘sizel’ set but > not used [-Wunused-but-set-variable] > > It is never used, and so can be removed. > > Fixes: 8369ae33b705 ("bcma: add Broadcom specific AMBA bus driver") > Signed-off-by: yu kuai <yukuai3@huawei.com> Patch applied to wireless-drivers-next.git, thanks. f427939391f2 bcma: remove set but not used variable 'sizel'
diff --git a/drivers/bcma/scan.c b/drivers/bcma/scan.c index 4a2d1b235fb5..1f2de714b401 100644 --- a/drivers/bcma/scan.c +++ b/drivers/bcma/scan.c @@ -219,7 +219,7 @@ static s32 bcma_erom_get_mst_port(struct bcma_bus *bus, u32 __iomem **eromptr) static u32 bcma_erom_get_addr_desc(struct bcma_bus *bus, u32 __iomem **eromptr, u32 type, u8 port) { - u32 addrl, addrh, sizel, sizeh = 0; + u32 addrl, addrh, sizeh = 0; u32 size; u32 ent = bcma_erom_get_ent(bus, eromptr); @@ -239,12 +239,9 @@ static u32 bcma_erom_get_addr_desc(struct bcma_bus *bus, u32 __iomem **eromptr, if ((ent & SCAN_ADDR_SZ) == SCAN_ADDR_SZ_SZD) { size = bcma_erom_get_ent(bus, eromptr); - sizel = size & SCAN_SIZE_SZ; if (size & SCAN_SIZE_SG32) sizeh = bcma_erom_get_ent(bus, eromptr); - } else - sizel = SCAN_ADDR_SZ_BASE << - ((ent & SCAN_ADDR_SZ) >> SCAN_ADDR_SZ_SHIFT); + } return addrl; }
Fixes gcc '-Wunused-but-set-variable' warning: drivers/bcma/scan.c: In function ‘bcma_erom_get_addr_desc’: drivers/bcma/scan.c:222:20: warning: variable ‘sizel’ set but not used [-Wunused-but-set-variable] It is never used, and so can be removed. Fixes: 8369ae33b705 ("bcma: add Broadcom specific AMBA bus driver") Signed-off-by: yu kuai <yukuai3@huawei.com> --- drivers/bcma/scan.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)