diff mbox series

[CI] drm/i915/tgl: Drop preemption to see if that helps

Message ID 20191128092120.3783242-1-chris@chris-wilson.co.uk (mailing list archive)
State New, archived
Headers show
Series [CI] drm/i915/tgl: Drop preemption to see if that helps | expand

Commit Message

Chris Wilson Nov. 28, 2019, 9:21 a.m. UTC
---
 drivers/gpu/drm/i915/gt/intel_lrc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Chris Wilson Nov. 28, 2019, 12:19 p.m. UTC | #1
Quoting Patchwork (2019-11-28 12:06:45)
> == Series Details ==
> 
> Series: drm/i915/tgl: Drop preemption to see if that helps
> URL   : https://patchwork.freedesktop.org/series/70153/
> State : success
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7436 -> Patchwork_15483
> ====================================================
> 
> Summary
> -------
> 
>   **SUCCESS**
> 
>   No regressions found.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15483/index.html

Not mentioned is that fi-tgl-u died in the same place on
gem_ctx_create@basic-files, so preemption is not the key to unlocking
the mystery.
-Chris
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 4cd0d46b5da6..37c8ee9801d0 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -3773,8 +3773,11 @@  void intel_execlists_set_default_submission(struct intel_engine_cs *engine)
 			engine->flags |= I915_ENGINE_HAS_PREEMPTION;
 	}
 
-	if (INTEL_GEN(engine->i915) >= 12)
+	if (INTEL_GEN(engine->i915) >= 12) {
 		engine->flags |= I915_ENGINE_HAS_RELATIVE_MMIO;
+		engine->flags &= ~I915_ENGINE_HAS_PREEMPTION;
+		engine->flags &= ~I915_ENGINE_HAS_SEMAPHORES;
+	}
 }
 
 static void execlists_destroy(struct intel_engine_cs *engine)