crypto: arm64/ghash-neon - bump priority to 150
diff mbox series

Message ID 20191128125531.5165-1-ardb@kernel.org
State Accepted
Delegated to: Herbert Xu
Headers show
Series
  • crypto: arm64/ghash-neon - bump priority to 150
Related show

Commit Message

Ard Biesheuvel Nov. 28, 2019, 12:55 p.m. UTC
The SIMD based GHASH implementation for arm64 is typically much faster
than the generic one, and doesn't use any lookup tables, so it is
clearly preferred when available. So bump the priority to reflect that.

Fixes: 5a22b198cd527447 ("crypto: arm64/ghash - register PMULL variants ...")
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
---
 arch/arm64/crypto/ghash-ce-glue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Herbert Xu Dec. 11, 2019, 9:40 a.m. UTC | #1
On Thu, Nov 28, 2019 at 01:55:31PM +0100, Ard Biesheuvel wrote:
> The SIMD based GHASH implementation for arm64 is typically much faster
> than the generic one, and doesn't use any lookup tables, so it is
> clearly preferred when available. So bump the priority to reflect that.
> 
> Fixes: 5a22b198cd527447 ("crypto: arm64/ghash - register PMULL variants ...")
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
>  arch/arm64/crypto/ghash-ce-glue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied.  Thanks.

Patch
diff mbox series

diff --git a/arch/arm64/crypto/ghash-ce-glue.c b/arch/arm64/crypto/ghash-ce-glue.c
index 522cf004ce65..196aedd0c20c 100644
--- a/arch/arm64/crypto/ghash-ce-glue.c
+++ b/arch/arm64/crypto/ghash-ce-glue.c
@@ -259,7 +259,7 @@  static int ghash_setkey(struct crypto_shash *tfm,
 static struct shash_alg ghash_alg[] = {{
 	.base.cra_name		= "ghash",
 	.base.cra_driver_name	= "ghash-neon",
-	.base.cra_priority	= 100,
+	.base.cra_priority	= 150,
 	.base.cra_blocksize	= GHASH_BLOCK_SIZE,
 	.base.cra_ctxsize	= sizeof(struct ghash_key),
 	.base.cra_module	= THIS_MODULE,