iio: atlas-ph-sensor: Drop GPIO include
diff mbox series

Message ID 20191202091837.82150-1-linus.walleij@linaro.org
State New
Headers show
Series
  • iio: atlas-ph-sensor: Drop GPIO include
Related show

Commit Message

Linus Walleij Dec. 2, 2019, 9:18 a.m. UTC
The driver includes <linux/gpio.h> yet fails to use symbols
from any the header so drop the include.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/iio/chemical/atlas-ph-sensor.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jonathan Cameron Dec. 7, 2019, 10:16 a.m. UTC | #1
On Mon,  2 Dec 2019 10:18:37 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> The driver includes <linux/gpio.h> yet fails to use symbols
> from any the header so drop the include.
> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
+CC Matt

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to do something or other.

Thanks,

Jonathan

> ---
>  drivers/iio/chemical/atlas-ph-sensor.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
> index 6c175eb1c7a7..b7c20c74239b 100644
> --- a/drivers/iio/chemical/atlas-ph-sensor.c
> +++ b/drivers/iio/chemical/atlas-ph-sensor.c
> @@ -14,7 +14,6 @@
>  #include <linux/err.h>
>  #include <linux/irq.h>
>  #include <linux/irq_work.h>
> -#include <linux/gpio.h>
>  #include <linux/i2c.h>
>  #include <linux/of_device.h>
>  #include <linux/regmap.h>
Matt Ranostay Dec. 7, 2019, 10:05 p.m. UTC | #2
On Sat, Dec 7, 2019 at 2:16 AM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Mon,  2 Dec 2019 10:18:37 +0100
> Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > The driver includes <linux/gpio.h> yet fails to use symbols
> > from any the header so drop the include.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> +CC Matt
>
> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to do something or other.
>

Looks good to me. Probably too late for a Reviewed-by, but here it is anyway

Reviewed-by: Matt Ranostay <matt.ranostay@konsulko.com>

> Thanks,
>
> Jonathan
>
> > ---
> >  drivers/iio/chemical/atlas-ph-sensor.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
> > index 6c175eb1c7a7..b7c20c74239b 100644
> > --- a/drivers/iio/chemical/atlas-ph-sensor.c
> > +++ b/drivers/iio/chemical/atlas-ph-sensor.c
> > @@ -14,7 +14,6 @@
> >  #include <linux/err.h>
> >  #include <linux/irq.h>
> >  #include <linux/irq_work.h>
> > -#include <linux/gpio.h>
> >  #include <linux/i2c.h>
> >  #include <linux/of_device.h>
> >  #include <linux/regmap.h>
>

Patch
diff mbox series

diff --git a/drivers/iio/chemical/atlas-ph-sensor.c b/drivers/iio/chemical/atlas-ph-sensor.c
index 6c175eb1c7a7..b7c20c74239b 100644
--- a/drivers/iio/chemical/atlas-ph-sensor.c
+++ b/drivers/iio/chemical/atlas-ph-sensor.c
@@ -14,7 +14,6 @@ 
 #include <linux/err.h>
 #include <linux/irq.h>
 #include <linux/irq_work.h>
-#include <linux/gpio.h>
 #include <linux/i2c.h>
 #include <linux/of_device.h>
 #include <linux/regmap.h>