| Message ID | 1575368005-29797-4-git-send-email-yamonkar@cadence.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | PHY: Update Cadence Torrent PHY driver with reconfiguration | expand |
Hi, On Tue, Dec 03, 2019 at 11:13:13AM +0100, Yuti Amonkar wrote: > Rename Cadence DP PHY driver from phy-cadence-dp to phy-cadence-torrent > to make it more generic for future use. Modifiy Makefile and Kconfig > accordingly. Also, change driver compatible from "cdns,dp-phy" to > "cdns,torrent-phy". You can't really do that though, this breaks any DT using the old compatible. Maxime
Hi, > -----Original Message----- > From: Maxime Ripard <maxime@cerno.tech> > Sent: Friday, December 13, 2019 15:27 > To: Yuti Suresh Amonkar <yamonkar@cadence.com> > Cc: dri-devel@lists.freedesktop.org; Milind Parab <mparab@cadence.com>; > praneeth@ti.com; Dhananjay Vilasrao Kangude <dkangude@cadence.com>; > jsarha@ti.com; kishon@ti.com; tomi.valkeinen@ti.com; Swapnil Kashinath > Jakhade <sjakhade@cadence.com> > Subject: Re: [PATCH v1 03/15] phy: cadence-dp: Rename to phy-cadence- > torrent > > EXTERNAL MAIL > > > Hi, > > On Tue, Dec 03, 2019 at 11:13:13AM +0100, Yuti Amonkar wrote: > > Rename Cadence DP PHY driver from phy-cadence-dp to > > phy-cadence-torrent to make it more generic for future use. Modifiy > > Makefile and Kconfig accordingly. Also, change driver compatible from > > "cdns,dp-phy" to "cdns,torrent-phy". > > You can't really do that though, this breaks any DT using the old compatible. > This driver has never been functional, and there do not exist any active use case, and hence the compatible string has never been in any of the dt file. > Maxime Thanks & Regards, Yuti Amonkar
On Fri, Dec 13, 2019 at 11:05:56AM +0000, Yuti Suresh Amonkar wrote: > Hi, > > > -----Original Message----- > > From: Maxime Ripard <maxime@cerno.tech> > > Sent: Friday, December 13, 2019 15:27 > > To: Yuti Suresh Amonkar <yamonkar@cadence.com> > > Cc: dri-devel@lists.freedesktop.org; Milind Parab <mparab@cadence.com>; > > praneeth@ti.com; Dhananjay Vilasrao Kangude <dkangude@cadence.com>; > > jsarha@ti.com; kishon@ti.com; tomi.valkeinen@ti.com; Swapnil Kashinath > > Jakhade <sjakhade@cadence.com> > > Subject: Re: [PATCH v1 03/15] phy: cadence-dp: Rename to phy-cadence- > > torrent > > > > EXTERNAL MAIL > > > > > > Hi, > > > > On Tue, Dec 03, 2019 at 11:13:13AM +0100, Yuti Amonkar wrote: > > > Rename Cadence DP PHY driver from phy-cadence-dp to > > > phy-cadence-torrent to make it more generic for future use. Modifiy > > > Makefile and Kconfig accordingly. Also, change driver compatible from > > > "cdns,dp-phy" to "cdns,torrent-phy". > > > > You can't really do that though, this breaks any DT using the old compatible. > > > > This driver has never been functional, and there do not exist any > active use case, and hence the compatible string has never been in > any of the dt file. Ok, I guess that should be made clearer in the commit log then. Thanks! Maxime
diff --git a/drivers/phy/cadence/Kconfig b/drivers/phy/cadence/Kconfig index b2db916d..4595458 100644 --- a/drivers/phy/cadence/Kconfig +++ b/drivers/phy/cadence/Kconfig @@ -3,13 +3,13 @@ # Phy drivers for Cadence PHYs # -config PHY_CADENCE_DP - tristate "Cadence MHDP DisplayPort PHY driver" +config PHY_CADENCE_TORRENT + tristate "Cadence Torrent PHY driver" depends on OF depends on HAS_IOMEM select GENERIC_PHY help - Support for Cadence MHDP DisplayPort PHY. + Support for Cadence Torrent PHY. config PHY_CADENCE_DPHY tristate "Cadence D-PHY Support" diff --git a/drivers/phy/cadence/Makefile b/drivers/phy/cadence/Makefile index 8f89560..6a7ffc6 100644 --- a/drivers/phy/cadence/Makefile +++ b/drivers/phy/cadence/Makefile @@ -1,4 +1,4 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_PHY_CADENCE_DP) += phy-cadence-dp.o +obj-$(CONFIG_PHY_CADENCE_TORRENT) += phy-cadence-torrent.o obj-$(CONFIG_PHY_CADENCE_DPHY) += cdns-dphy.o obj-$(CONFIG_PHY_CADENCE_SIERRA) += phy-cadence-sierra.o diff --git a/drivers/phy/cadence/phy-cadence-dp.c b/drivers/phy/cadence/phy-cadence-torrent.c similarity index 99% rename from drivers/phy/cadence/phy-cadence-dp.c rename to drivers/phy/cadence/phy-cadence-torrent.c index bc10cb2..beb80f7 100644 --- a/drivers/phy/cadence/phy-cadence-dp.c +++ b/drivers/phy/cadence/phy-cadence-torrent.c @@ -521,7 +521,7 @@ static int cdns_dp_phy_probe(struct platform_device *pdev) static const struct of_device_id cdns_dp_phy_of_match[] = { { - .compatible = "cdns,dp-phy" + .compatible = "cdns,torrent-phy" }, {} };
Rename Cadence DP PHY driver from phy-cadence-dp to phy-cadence-torrent to make it more generic for future use. Modifiy Makefile and Kconfig accordingly. Also, change driver compatible from "cdns,dp-phy" to "cdns,torrent-phy". Signed-off-by: Yuti Amonkar <yamonkar@cadence.com> --- drivers/phy/cadence/Kconfig | 6 +++--- drivers/phy/cadence/Makefile | 2 +- drivers/phy/cadence/{phy-cadence-dp.c => phy-cadence-torrent.c} | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) rename drivers/phy/cadence/{phy-cadence-dp.c => phy-cadence-torrent.c} (99%)