ASoC: Intel: bytcr_rt5640: Update quirk for Teclast X89
diff mbox series

Message ID 20191203221442.2657-1-hdegoede@redhat.com
State Accepted
Commit 7eccc05c7101f34cc36afe9405d15de6d4099fb4
Headers show
Series
  • ASoC: Intel: bytcr_rt5640: Update quirk for Teclast X89
Related show

Commit Message

Hans de Goede Dec. 3, 2019, 10:14 p.m. UTC
When the Teclast X89 quirk was added we did not have jack-detection
support yet.

Note the over-current detection limit is set to 2mA instead of the usual
1.5mA because this tablet tends to give false-positive button-presses
when it is set to 1.5mA.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/soc/intel/boards/bytcr_rt5640.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Pierre-Louis Bossart Dec. 4, 2019, 12:36 a.m. UTC | #1
On 12/3/19 4:14 PM, Hans de Goede wrote:
> When the Teclast X89 quirk was added we did not have jack-detection
> support yet.
> 
> Note the over-current detection limit is set to 2mA instead of the usual
> 1.5mA because this tablet tends to give false-positive button-presses
> when it is set to 1.5mA.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Thanks Hans!

> ---
>   sound/soc/intel/boards/bytcr_rt5640.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index dd2b5ad08659..243f683bc02a 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -707,13 +707,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>   					BYT_RT5640_MCLK_EN),
>   	},
>   	{
> +		/* Teclast X89 */
>   		.matches = {
>   			DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
>   			DMI_MATCH(DMI_BOARD_NAME, "tPAD"),
>   		},
>   		.driver_data = (void *)(BYT_RT5640_IN3_MAP |
> -					BYT_RT5640_MCLK_EN |
> -					BYT_RT5640_SSP0_AIF1),
> +					BYT_RT5640_JD_SRC_JD1_IN4P |
> +					BYT_RT5640_OVCD_TH_2000UA |
> +					BYT_RT5640_OVCD_SF_1P0 |
> +					BYT_RT5640_SSP0_AIF1 |
> +					BYT_RT5640_MCLK_EN),
>   	},
>   	{	/* Toshiba Satellite Click Mini L9W-B */
>   		.matches = {
>

Patch
diff mbox series

diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index dd2b5ad08659..243f683bc02a 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -707,13 +707,17 @@  static const struct dmi_system_id byt_rt5640_quirk_table[] = {
 					BYT_RT5640_MCLK_EN),
 	},
 	{
+		/* Teclast X89 */
 		.matches = {
 			DMI_MATCH(DMI_BOARD_VENDOR, "TECLAST"),
 			DMI_MATCH(DMI_BOARD_NAME, "tPAD"),
 		},
 		.driver_data = (void *)(BYT_RT5640_IN3_MAP |
-					BYT_RT5640_MCLK_EN |
-					BYT_RT5640_SSP0_AIF1),
+					BYT_RT5640_JD_SRC_JD1_IN4P |
+					BYT_RT5640_OVCD_TH_2000UA |
+					BYT_RT5640_OVCD_SF_1P0 |
+					BYT_RT5640_SSP0_AIF1 |
+					BYT_RT5640_MCLK_EN),
 	},
 	{	/* Toshiba Satellite Click Mini L9W-B */
 		.matches = {