| Message ID | 20191204010851.160284-1-maowenan@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 11d06df7b9f29ec5898901c2c94a58f4ecf60446 |
| Delegated to: | Paul Burton |
| Headers | show |
| Series | [-next] MIPS: Loongson2ef: drop pointless static qualifier in loongson_suspend_enter() | expand |
Hello, Mao Wenan wrote: > There is no need to have the 'T *v' variable static > since new value always be assigned before use it. Applied to mips-next. > commit 11d06df7b9f2 > https://git.kernel.org/mips/c/11d06df7b9f2 > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Mao Wenan <maowenan@huawei.com> > Signed-off-by: Paul Burton <paulburton@kernel.org> Thanks, Paul [ This message was auto-generated; if you believe anything is incorrect then please email paulburton@kernel.org to report it. ]
diff --git a/arch/mips/loongson2ef/common/pm.c b/arch/mips/loongson2ef/common/pm.c index 11f4cfd581fb..bcb7ae9777cf 100644 --- a/arch/mips/loongson2ef/common/pm.c +++ b/arch/mips/loongson2ef/common/pm.c @@ -91,7 +91,7 @@ static inline void stop_perf_counters(void) static void loongson_suspend_enter(void) { - static unsigned int cached_cpu_freq; + unsigned int cached_cpu_freq; /* setup wakeup events via enabling the IRQs */ setup_wakeup_events();
There is no need to have the 'T *v' variable static since new value always be assigned before use it. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Mao Wenan <maowenan@huawei.com> --- arch/mips/loongson2ef/common/pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)