| Message ID | 20191204020209.10363-1-maowenan@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] rtc: mt6397: drop free_irq of devm_xx allocated irq | expand |
On Wed, Dec 04, 2019 at 10:02:09AM +0800, Mao Wenan wrote: > rtc->irq is requested by devm_request_threaded_irq, > and request_threaded_irq. IRQs requested with this > function will be automatically freed on driver detach. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Mao Wenan <maowenan@huawei.com> > --- > drivers/rtc/rtc-mt6397.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c > index 5249fc99fd5f..d6a10111137a 100644 > --- a/drivers/rtc/rtc-mt6397.c > +++ b/drivers/rtc/rtc-mt6397.c > @@ -293,7 +293,6 @@ static int mtk_rtc_probe(struct platform_device *pdev) > return 0; > > out_free_irq: > - free_irq(rtc->irq, rtc); > return ret; Please get rid of the error label as well. regards, dan carpenter
diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index 5249fc99fd5f..d6a10111137a 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -293,7 +293,6 @@ static int mtk_rtc_probe(struct platform_device *pdev) return 0; out_free_irq: - free_irq(rtc->irq, rtc); return ret; }
rtc->irq is requested by devm_request_threaded_irq, and request_threaded_irq. IRQs requested with this function will be automatically freed on driver detach. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Mao Wenan <maowenan@huawei.com> --- drivers/rtc/rtc-mt6397.c | 1 - 1 file changed, 1 deletion(-)