MAINTAINERS: rockchip: Track more files
diff mbox series

Message ID 20191204090710.11646-1-miquel.raynal@bootlin.com
State New
Headers show
Series
  • MAINTAINERS: rockchip: Track more files
Related show

Commit Message

Miquel Raynal Dec. 4, 2019, 9:07 a.m. UTC
The current list misses a lot of drivers not prefixed or suffixed by
"rockchip". For instance, there are plenty drivers called rk808 and
rk805 which are currently not tracked (clk, regulator, pinctrl, RTC,
MFD, includes, bindings). Add them to the list under the Rockchip
entry.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---

Hi Heiko,

You are right we should try to check more often your tree. Also, here
is a patch so that you are Cc'ed for all Rockchip related patches
because the current list is not exhaustive at all (not sure it is
voluntary or not though).

Cheers,
Miquèl

 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Kever Yang Dec. 9, 2019, 8:18 a.m. UTC | #1
Hi Miquel,

On 2019/12/4 下午5:07, Miquel Raynal wrote:
> The current list misses a lot of drivers not prefixed or suffixed by
> "rockchip". For instance, there are plenty drivers called rk808 and
> rk805 which are currently not tracked (clk, regulator, pinctrl, RTC,
> MFD, includes, bindings). Add them to the list under the Rockchip
> entry.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>
> Hi Heiko,
>
> You are right we should try to check more often your tree. Also, here
> is a patch so that you are Cc'ed for all Rockchip related patches
> because the current list is not exhaustive at all (not sure it is
> voluntary or not though).
>
> Cheers,
> Miquèl
>
>   MAINTAINERS | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cba1095547fd..a9564e6cb872 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2198,12 +2198,16 @@ L:	linux-rockchip@lists.infradead.org
>   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git
>   S:	Maintained
>   F:	Documentation/devicetree/bindings/i2c/i2c-rk3x.txt
> +F:	Documentation/devicetree/bindings/*/*rk80*
>   F:	arch/arm/boot/dts/rk3*
>   F:	arch/arm/boot/dts/rv1108*
>   F:	arch/arm/mach-rockchip/
> +F:	include/*/*/rk808.h
> +F:	include/*/*/*/rk808.h
>   F:	drivers/clk/rockchip/
>   F:	drivers/i2c/busses/i2c-rk3x.c
>   F:	drivers/*/*rockchip*
> +F:	drivers/*/*rk80*
>   F:	drivers/*/*/*rockchip*
>   F:	sound/soc/rockchip/
>   N:	rockchip
For the Rockchip PMIC, is it better to have a NEW MAINTAINER entry like 
"ROCKCHIP PMIC DRIVER"
which share the same mailing list linux-rockchip@, because there is not 
only rk808,
but also rk805, rk809, rk817, rk818, and may be more to come.

BTW, we should use 'rk8' instead of 'rk80' to match all the Rockchip PMICs.


Thanks,
- Kever
Heiko Stuebner Dec. 13, 2019, 10:27 a.m. UTC | #2
Am Montag, 9. Dezember 2019, 09:18:00 CET schrieb Kever Yang:
> Hi Miquel,
> 
> On 2019/12/4 下午5:07, Miquel Raynal wrote:
> > The current list misses a lot of drivers not prefixed or suffixed by
> > "rockchip". For instance, there are plenty drivers called rk808 and
> > rk805 which are currently not tracked (clk, regulator, pinctrl, RTC,
> > MFD, includes, bindings). Add them to the list under the Rockchip
> > entry.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >
> > Hi Heiko,
> >
> > You are right we should try to check more often your tree. Also, here
> > is a patch so that you are Cc'ed for all Rockchip related patches
> > because the current list is not exhaustive at all (not sure it is
> > voluntary or not though).
> >
> > Cheers,
> > Miquèl
> >
> >   MAINTAINERS | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index cba1095547fd..a9564e6cb872 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -2198,12 +2198,16 @@ L:	linux-rockchip@lists.infradead.org
> >   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git
> >   S:	Maintained
> >   F:	Documentation/devicetree/bindings/i2c/i2c-rk3x.txt
> > +F:	Documentation/devicetree/bindings/*/*rk80*
> >   F:	arch/arm/boot/dts/rk3*
> >   F:	arch/arm/boot/dts/rv1108*
> >   F:	arch/arm/mach-rockchip/
> > +F:	include/*/*/rk808.h
> > +F:	include/*/*/*/rk808.h
> >   F:	drivers/clk/rockchip/
> >   F:	drivers/i2c/busses/i2c-rk3x.c
> >   F:	drivers/*/*rockchip*
> > +F:	drivers/*/*rk80*
> >   F:	drivers/*/*/*rockchip*
> >   F:	sound/soc/rockchip/
> >   N:	rockchip
> For the Rockchip PMIC, is it better to have a NEW MAINTAINER entry like 
> "ROCKCHIP PMIC DRIVER"
> which share the same mailing list linux-rockchip@, because there is not 
> only rk808,
> but also rk805, rk809, rk817, rk818, and may be more to come.
> 
> BTW, we should use 'rk8' instead of 'rk80' to match all the Rockchip PMICs.

yep, I agree with Kever on this ... also that new pmic-related entry should
not really link to a git tree as patches for it will get distributed through
multiple trees (mfd, regulator, rtc) most of the time.

Miquel can you do a v2 please?

Thanks
Heiko
Miquel Raynal Dec. 13, 2019, 10:35 a.m. UTC | #3
Hi Heiko,

Heiko Stuebner <heiko@sntech.de> wrote on Fri, 13 Dec 2019 11:27:29
+0100:

> Am Montag, 9. Dezember 2019, 09:18:00 CET schrieb Kever Yang:
> > Hi Miquel,
> > 
> > On 2019/12/4 下午5:07, Miquel Raynal wrote:  
> > > The current list misses a lot of drivers not prefixed or suffixed by
> > > "rockchip". For instance, there are plenty drivers called rk808 and
> > > rk805 which are currently not tracked (clk, regulator, pinctrl, RTC,
> > > MFD, includes, bindings). Add them to the list under the Rockchip
> > > entry.
> > >
> > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > > ---
> > >
> > > Hi Heiko,
> > >
> > > You are right we should try to check more often your tree. Also, here
> > > is a patch so that you are Cc'ed for all Rockchip related patches
> > > because the current list is not exhaustive at all (not sure it is
> > > voluntary or not though).
> > >
> > > Cheers,
> > > Miquèl
> > >
> > >   MAINTAINERS | 4 ++++
> > >   1 file changed, 4 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index cba1095547fd..a9564e6cb872 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -2198,12 +2198,16 @@ L:	linux-rockchip@lists.infradead.org
> > >   T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git
> > >   S:	Maintained
> > >   F:	Documentation/devicetree/bindings/i2c/i2c-rk3x.txt
> > > +F:	Documentation/devicetree/bindings/*/*rk80*
> > >   F:	arch/arm/boot/dts/rk3*
> > >   F:	arch/arm/boot/dts/rv1108*
> > >   F:	arch/arm/mach-rockchip/
> > > +F:	include/*/*/rk808.h
> > > +F:	include/*/*/*/rk808.h
> > >   F:	drivers/clk/rockchip/
> > >   F:	drivers/i2c/busses/i2c-rk3x.c
> > >   F:	drivers/*/*rockchip*
> > > +F:	drivers/*/*rk80*
> > >   F:	drivers/*/*/*rockchip*
> > >   F:	sound/soc/rockchip/
> > >   N:	rockchip  
> > For the Rockchip PMIC, is it better to have a NEW MAINTAINER entry like 
> > "ROCKCHIP PMIC DRIVER"
> > which share the same mailing list linux-rockchip@, because there is not 
> > only rk808,
> > but also rk805, rk809, rk817, rk818, and may be more to come.
> > 
> > BTW, we should use 'rk8' instead of 'rk80' to match all the Rockchip PMICs.  
> 
> yep, I agree with Kever on this ... also that new pmic-related entry should
> not really link to a git tree as patches for it will get distributed through
> multiple trees (mfd, regulator, rtc) most of the time.

I think it is important that the maintainer receive all Rockchip
related patches, as he has the bigger picture in mind. Of course it is
possible to add an additional MAINTAINER entry for Rockchip PMIC
drivers specifically.

So in the end, I will s/rk80/rk8/, shall I remove a specific entry from
the 4 added?

> 
> Miquel can you do a v2 please?

Of course, this is planned, I'm just a bit late in my e-mail backlog!

Cheers,
Miquèl

Patch
diff mbox series

diff --git a/MAINTAINERS b/MAINTAINERS
index cba1095547fd..a9564e6cb872 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2198,12 +2198,16 @@  L:	linux-rockchip@lists.infradead.org
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git
 S:	Maintained
 F:	Documentation/devicetree/bindings/i2c/i2c-rk3x.txt
+F:	Documentation/devicetree/bindings/*/*rk80*
 F:	arch/arm/boot/dts/rk3*
 F:	arch/arm/boot/dts/rv1108*
 F:	arch/arm/mach-rockchip/
+F:	include/*/*/rk808.h
+F:	include/*/*/*/rk808.h
 F:	drivers/clk/rockchip/
 F:	drivers/i2c/busses/i2c-rk3x.c
 F:	drivers/*/*rockchip*
+F:	drivers/*/*rk80*
 F:	drivers/*/*/*rockchip*
 F:	sound/soc/rockchip/
 N:	rockchip