| Message ID | 20191204130907.19799-1-aford173@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [V2] media: ov5640: Fix check for PLL1 exceeding max allowed rate | expand |
Hi Adam, On Wed, Dec 4, 2019 at 10:11 AM Adam Ford <aford173@gmail.com> wrote: > > The PLL calculation routine checks the wrong variable name 'rate' > when it should be called '_rate' when checking to see whether or > not the PLL1 output frequency exceeds 1GHz. > > This patch changes it to the correct variable '_rate' > > Acked-by: Jacopo Mondi <jacopo@jmondi.org> > Signed-off-by: Adam Ford <aford173@gmail.com> Maybe add a Fixes tag too?
Hi Adam, On Wed, Dec 04, 2019 at 07:09:07AM -0600, Adam Ford wrote: > The PLL calculation routine checks the wrong variable name 'rate' > when it should be called '_rate' when checking to see whether or > not the PLL1 output frequency exceeds 1GHz. > > This patch changes it to the correct variable '_rate' > > Acked-by: Jacopo Mondi <jacopo@jmondi.org> > Signed-off-by: Adam Ford <aford173@gmail.com> Why have you dropped the fixes tag you had in v1? Fixes: aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate") I'm not the one who collects patches, so maybe wait for Sakari or Hans to tell you if you need to resend or not :) Thanks j > --- > V2: No code change. Only change commit description to be less confusing. > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c > index 5e495c833d32..bb968e764f31 100644 > --- a/drivers/media/i2c/ov5640.c > +++ b/drivers/media/i2c/ov5640.c > @@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor, > * We have reached the maximum allowed PLL1 output, > * increase sysdiv. > */ > - if (!rate) > + if (!_rate) > break; > > /* > -- > 2.20.1 >
On Wed, Dec 4, 2019 at 7:23 AM Jacopo Mondi <jacopo@jmondi.org> wrote: > > Hi Adam, > > On Wed, Dec 04, 2019 at 07:09:07AM -0600, Adam Ford wrote: > > The PLL calculation routine checks the wrong variable name 'rate' > > when it should be called '_rate' when checking to see whether or > > not the PLL1 output frequency exceeds 1GHz. > > > > This patch changes it to the correct variable '_rate' > > > > Acked-by: Jacopo Mondi <jacopo@jmondi.org> > > Signed-off-by: Adam Ford <aford173@gmail.com> > > Why have you dropped the fixes tag you had in v1? > > Fixes: aa2882481cad ("media: ov5640: Adjust the clock based on the expected rate") > > I'm not the one who collects patches, so maybe wait for Sakari or Hans > to tell you if you need to resend or not :) It wasn't intentional. I couldn't find the original patch nor could I find it in patchwork, so I re-did it from scratch and forgot. (I have too many different computers) I already sent a V3 before I read your e-mail. Sorry about that. adam > > Thanks > j > > > --- > > V2: No code change. Only change commit description to be less confusing. > > > > diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c > > index 5e495c833d32..bb968e764f31 100644 > > --- a/drivers/media/i2c/ov5640.c > > +++ b/drivers/media/i2c/ov5640.c > > @@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor, > > * We have reached the maximum allowed PLL1 output, > > * increase sysdiv. > > */ > > - if (!rate) > > + if (!_rate) > > break; > > > > /* > > -- > > 2.20.1 > >
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 5e495c833d32..bb968e764f31 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -874,7 +874,7 @@ static unsigned long ov5640_calc_sys_clk(struct ov5640_dev *sensor, * We have reached the maximum allowed PLL1 output, * increase sysdiv. */ - if (!rate) + if (!_rate) break; /*