[2/2] arm: omap2plus_defconfig: enable NET_SWITCHDEV
diff mbox series

Message ID 20191204174533.32207-3-grygorii.strashko@ti.com
State New
Headers show
Series
  • net: ethernet: ti: cpsw_switchdev: fix unmet direct dependencies detected for NET_SWITCHDEV
Related show

Commit Message

Grygorii Strashko Dec. 4, 2019, 5:45 p.m. UTC
The TI_CPSW_SWITCHDEV definition in Kconfig was changed from "select
NET_SWITCHDEV" to "depends on NET_SWITCHDEV", and therefore it is required
to explicitelly enable NET_SWITCHDEV config option in omap2plus_defconfig.

Fixes: 3727d259ddaf ("arm: omap2plus_defconfig: enable new cpsw switchdev driver")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 arch/arm/configs/omap2plus_defconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Grygorii Strashko Dec. 6, 2019, 11:07 a.m. UTC | #1
Hi Tony,

On 04/12/2019 19:45, Grygorii Strashko wrote:
> The TI_CPSW_SWITCHDEV definition in Kconfig was changed from "select
> NET_SWITCHDEV" to "depends on NET_SWITCHDEV", and therefore it is required
> to explicitelly enable NET_SWITCHDEV config option in omap2plus_defconfig.
> 
> Fixes: 3727d259ddaf ("arm: omap2plus_defconfig: enable new cpsw switchdev driver")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
>   arch/arm/configs/omap2plus_defconfig | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> index 89cce8d4bc6b..7bbef86a4e76 100644
> --- a/arch/arm/configs/omap2plus_defconfig
> +++ b/arch/arm/configs/omap2plus_defconfig
> @@ -92,6 +92,7 @@ CONFIG_IP_PNP_BOOTP=y
>   CONFIG_IP_PNP_RARP=y
>   CONFIG_NETFILTER=y
>   CONFIG_PHONET=m
> +CONFIG_NET_SWITCHDEV=y
>   CONFIG_CAN=m
>   CONFIG_CAN_C_CAN=m
>   CONFIG_CAN_C_CAN_PLATFORM=m
> @@ -182,6 +183,7 @@ CONFIG_SMSC911X=y
>   # CONFIG_NET_VENDOR_STMICRO is not set
>   CONFIG_TI_DAVINCI_EMAC=y
>   CONFIG_TI_CPSW=y
> +CONFIG_TI_CPSW_SWITCHDEV=y
>   CONFIG_TI_CPTS=y
>   # CONFIG_NET_VENDOR_VIA is not set
>   # CONFIG_NET_VENDOR_WIZNET is not set
> @@ -554,4 +556,3 @@ CONFIG_DEBUG_INFO_DWARF4=y
>   CONFIG_MAGIC_SYSRQ=y
>   CONFIG_SCHEDSTATS=y
>   # CONFIG_DEBUG_BUGVERBOSE is not set
> -CONFIG_TI_CPSW_SWITCHDEV=y
> 

Could it be applied as fix, as without it cpsw switch driver will not be built,
so no networking on am571x-idk
Tony Lindgren Dec. 6, 2019, 3:50 p.m. UTC | #2
* Grygorii Strashko <grygorii.strashko@ti.com> [191206 11:08]:
> Hi Tony,
> 
> On 04/12/2019 19:45, Grygorii Strashko wrote:
> > The TI_CPSW_SWITCHDEV definition in Kconfig was changed from "select
> > NET_SWITCHDEV" to "depends on NET_SWITCHDEV", and therefore it is required
> > to explicitelly enable NET_SWITCHDEV config option in omap2plus_defconfig.
> > 
> > Fixes: 3727d259ddaf ("arm: omap2plus_defconfig: enable new cpsw switchdev driver")
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> > ---
> >   arch/arm/configs/omap2plus_defconfig | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
> > index 89cce8d4bc6b..7bbef86a4e76 100644
> > --- a/arch/arm/configs/omap2plus_defconfig
> > +++ b/arch/arm/configs/omap2plus_defconfig
> > @@ -92,6 +92,7 @@ CONFIG_IP_PNP_BOOTP=y
> >   CONFIG_IP_PNP_RARP=y
> >   CONFIG_NETFILTER=y
> >   CONFIG_PHONET=m
> > +CONFIG_NET_SWITCHDEV=y
> >   CONFIG_CAN=m
> >   CONFIG_CAN_C_CAN=m
> >   CONFIG_CAN_C_CAN_PLATFORM=m
> > @@ -182,6 +183,7 @@ CONFIG_SMSC911X=y
> >   # CONFIG_NET_VENDOR_STMICRO is not set
> >   CONFIG_TI_DAVINCI_EMAC=y
> >   CONFIG_TI_CPSW=y
> > +CONFIG_TI_CPSW_SWITCHDEV=y
> >   CONFIG_TI_CPTS=y
> >   # CONFIG_NET_VENDOR_VIA is not set
> >   # CONFIG_NET_VENDOR_WIZNET is not set
> > @@ -554,4 +556,3 @@ CONFIG_DEBUG_INFO_DWARF4=y
> >   CONFIG_MAGIC_SYSRQ=y
> >   CONFIG_SCHEDSTATS=y
> >   # CONFIG_DEBUG_BUGVERBOSE is not set
> > -CONFIG_TI_CPSW_SWITCHDEV=y
> > 
> 
> Could it be applied as fix, as without it cpsw switch driver will not be built,
> so no networking on am571x-idk

OK I'll be applying it into fixes.

Thanks,

Tony

Patch
diff mbox series

diff --git a/arch/arm/configs/omap2plus_defconfig b/arch/arm/configs/omap2plus_defconfig
index 89cce8d4bc6b..7bbef86a4e76 100644
--- a/arch/arm/configs/omap2plus_defconfig
+++ b/arch/arm/configs/omap2plus_defconfig
@@ -92,6 +92,7 @@  CONFIG_IP_PNP_BOOTP=y
 CONFIG_IP_PNP_RARP=y
 CONFIG_NETFILTER=y
 CONFIG_PHONET=m
+CONFIG_NET_SWITCHDEV=y
 CONFIG_CAN=m
 CONFIG_CAN_C_CAN=m
 CONFIG_CAN_C_CAN_PLATFORM=m
@@ -182,6 +183,7 @@  CONFIG_SMSC911X=y
 # CONFIG_NET_VENDOR_STMICRO is not set
 CONFIG_TI_DAVINCI_EMAC=y
 CONFIG_TI_CPSW=y
+CONFIG_TI_CPSW_SWITCHDEV=y
 CONFIG_TI_CPTS=y
 # CONFIG_NET_VENDOR_VIA is not set
 # CONFIG_NET_VENDOR_WIZNET is not set
@@ -554,4 +556,3 @@  CONFIG_DEBUG_INFO_DWARF4=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_SCHEDSTATS=y
 # CONFIG_DEBUG_BUGVERBOSE is not set
-CONFIG_TI_CPSW_SWITCHDEV=y