[2/2] btrfs-progs: mkfs-tests: Change $dev1 to TEST_DEV
diff mbox series

Message ID 20191205153647.31961-2-marcos.souza.org@gmail.com
State New
Headers show
Series
  • [1/2] btrfs-progs: mkfs-tests: Set $csum so mkfs.btrfs does not fail
Related show

Commit Message

Marcos Paulo de Souza Dec. 5, 2019, 3:36 p.m. UTC
From: Marcos Paulo de Souza <mpdesouza@suse.com>

It seems to be a typo, since $dev1 was not set, and we are dealing with
TEST_DEV and not with loop devices.

Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
---
 tests/mkfs-tests/020-basic-checksums-mount/test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nikolay Borisov Dec. 10, 2019, 8:34 a.m. UTC | #1
On 5.12.19 г. 17:36 ч., Marcos Paulo de Souza wrote:
> From: Marcos Paulo de Souza <mpdesouza@suse.com>
> 
> It seems to be a typo, since $dev1 was not set, and we are dealing with
> TEST_DEV and not with loop devices.
> 
> Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> ---
>  tests/mkfs-tests/020-basic-checksums-mount/test.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/mkfs-tests/020-basic-checksums-mount/test.sh b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> index b7252786..42bf5fab 100755
> --- a/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> +++ b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
> @@ -17,7 +17,7 @@ test_mkfs_mount_checksum()
>  	run_check $SUDO_HELPER "$TOP/btrfs" inspect-internal dump-super "$TEST_DEV"
>  	run_check $SUDO_HELPER "$TOP/btrfs" check "$TEST_DEV"
>  
> -	run_check $SUDO_HELPER mount "$dev1" "$TEST_MNT"
> +	run_check $SUDO_HELPER mount "$TEST_DEV" "$TEST_MNT"
>  	run_check "$TOP/btrfs" filesystem df "$TEST_MNT"
>  	run_check $SUDO_HELPER "$TOP/btrfs" filesystem usage "$TEST_MNT"
>  	run_check $SUDO_HELPER "$TOP/btrfs" device usage "$TEST_MNT"
>

Patch
diff mbox series

diff --git a/tests/mkfs-tests/020-basic-checksums-mount/test.sh b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
index b7252786..42bf5fab 100755
--- a/tests/mkfs-tests/020-basic-checksums-mount/test.sh
+++ b/tests/mkfs-tests/020-basic-checksums-mount/test.sh
@@ -17,7 +17,7 @@  test_mkfs_mount_checksum()
 	run_check $SUDO_HELPER "$TOP/btrfs" inspect-internal dump-super "$TEST_DEV"
 	run_check $SUDO_HELPER "$TOP/btrfs" check "$TEST_DEV"
 
-	run_check $SUDO_HELPER mount "$dev1" "$TEST_MNT"
+	run_check $SUDO_HELPER mount "$TEST_DEV" "$TEST_MNT"
 	run_check "$TOP/btrfs" filesystem df "$TEST_MNT"
 	run_check $SUDO_HELPER "$TOP/btrfs" filesystem usage "$TEST_MNT"
 	run_check $SUDO_HELPER "$TOP/btrfs" device usage "$TEST_MNT"