ASoC: tas2552: add missed regulator_bulk_disable in remove
diff mbox series

Message ID 20191206075239.18125-1-hslester96@gmail.com
State New
Headers show
Series
  • ASoC: tas2552: add missed regulator_bulk_disable in remove
Related show

Commit Message

Chuhong Yuan Dec. 6, 2019, 7:52 a.m. UTC
The driver forgets to call regulator_bulk_disable() in remove like that
in probe failure.
Add the missed call to fix it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
 sound/soc/codecs/tas2552.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mark Brown Dec. 9, 2019, 4:25 p.m. UTC | #1
On Fri, Dec 06, 2019 at 03:52:39PM +0800, Chuhong Yuan wrote:
> The driver forgets to call regulator_bulk_disable() in remove like that
> in probe failure.
> Add the missed call to fix it.

Another runtime PM interaction here.

Patch
diff mbox series

diff --git a/sound/soc/codecs/tas2552.c b/sound/soc/codecs/tas2552.c
index 56671f21cfe5..0e19ec76aae0 100644
--- a/sound/soc/codecs/tas2552.c
+++ b/sound/soc/codecs/tas2552.c
@@ -616,6 +616,9 @@  static void tas2552_component_remove(struct snd_soc_component *component)
 	pm_runtime_put(component->dev);
 
 	gpiod_set_value(tas2552->enable_gpio, 0);
+
+	regulator_bulk_disable(ARRAY_SIZE(tas2552->supplies),
+					tas2552->supplies);
 };
 
 #ifdef CONFIG_PM