drm/panfrost: no need to display probe deferred error
diff mbox series

Message ID 20191205221102.28248-1-peron.clem@gmail.com
State New
Headers show
Series
  • drm/panfrost: no need to display probe deferred error
Related show

Commit Message

Clément Péron Dec. 5, 2019, 10:11 p.m. UTC
Panfrost driver is shouting an error if the regulator init
return an -EPROBE_DEFFER. This is a not a real error and
it doesn't require to be display.

Check if the error is not an EPROBE_DEFFER before displaying it.

Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 drivers/gpu/drm/panfrost/panfrost_device.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Steven Price Dec. 6, 2019, 10:02 a.m. UTC | #1
On 05/12/2019 22:11, Clément Péron wrote:
> Panfrost driver is shouting an error if the regulator init
> return an -EPROBE_DEFFER. This is a not a real error and
> it doesn't require to be display.
> 
> Check if the error is not an EPROBE_DEFFER before displaying it.
> 
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
>  drivers/gpu/drm/panfrost/panfrost_device.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index 238fb6d54df4..00cef062c35d 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -92,7 +92,8 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
>  	pfdev->regulator = devm_regulator_get(pfdev->dev, "mali");
>  	if (IS_ERR(pfdev->regulator)) {
>  		ret = PTR_ERR(pfdev->regulator);
> -		dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
>  		return ret;
>  	}
>  
> @@ -130,7 +131,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
>  
>  	err = panfrost_regulator_init(pfdev);
>  	if (err) {
> -		dev_err(pfdev->dev, "regulator init failed %d\n", err);
> +		if (err != -EPROBE_DEFER)
> +			dev_err(pfdev->dev, "regulator init failed %d\n", err);

You could actually drop this dev_err() altogether -
panfrost_regulator_init() will always produce it's own dev_err() output
if it returns non-zero.

Either way:

Reviewed-by: Steven Price <steven.price@arm.com>

>  		goto err_out0;
>  	}
>  
>

Patch
diff mbox series

diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
index 238fb6d54df4..00cef062c35d 100644
--- a/drivers/gpu/drm/panfrost/panfrost_device.c
+++ b/drivers/gpu/drm/panfrost/panfrost_device.c
@@ -92,7 +92,8 @@  static int panfrost_regulator_init(struct panfrost_device *pfdev)
 	pfdev->regulator = devm_regulator_get(pfdev->dev, "mali");
 	if (IS_ERR(pfdev->regulator)) {
 		ret = PTR_ERR(pfdev->regulator);
-		dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
+		if (ret != -EPROBE_DEFER)
+			dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
 		return ret;
 	}
 
@@ -130,7 +131,8 @@  int panfrost_device_init(struct panfrost_device *pfdev)
 
 	err = panfrost_regulator_init(pfdev);
 	if (err) {
-		dev_err(pfdev->dev, "regulator init failed %d\n", err);
+		if (err != -EPROBE_DEFER)
+			dev_err(pfdev->dev, "regulator init failed %d\n", err);
 		goto err_out0;
 	}