From patchwork Thu Dec 5 23:42:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 11275749 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1845114BD for ; Fri, 6 Dec 2019 08:18:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 005F92467A for ; Fri, 6 Dec 2019 08:18:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 005F92467A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=umn.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 60ED488C5A; Fri, 6 Dec 2019 08:17:36 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mta-p7.oit.umn.edu (mta-p7.oit.umn.edu [134.84.196.207]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8DA206E185 for ; Thu, 5 Dec 2019 23:42:41 +0000 (UTC) Received: from localhost (unknown [127.0.0.1]) by mta-p7.oit.umn.edu (Postfix) with ESMTP id 47TXMN2JXxz9vcGf for ; Thu, 5 Dec 2019 23:42:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p7.oit.umn.edu ([127.0.0.1]) by localhost (mta-p7.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cU8halPkEI5T for ; Thu, 5 Dec 2019 17:42:40 -0600 (CST) Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p7.oit.umn.edu (Postfix) with ESMTPS id 47TXMN13Zyz9vcHC for ; Thu, 5 Dec 2019 17:42:40 -0600 (CST) Received: by mail-yb1-f198.google.com with SMTP id d131so3862681ybb.9 for ; Thu, 05 Dec 2019 15:42:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pdZdRYJjEUXDLjH6ecgkCpYlUe5NSw8y98ikYjaziR0=; b=J6Y/buSYleFGWWDvOl6UWxlx+PkHXSt6V3nkGC6+fsNks8i+lSZ9BJ5E5FDJt7MZnG sDINVQamTyeTNJ62jjdYpj+WXQAXpzhDKZE8RGIw47ajb6Xkj54QN/6jGMly/yyWhoQY eK1aE0eEAGjd17n8OgcrIA5HJN3wTel+wLSDlx0z+IBCFrcQF1nQ256GmOUI0jPUH8uk XE8WUqPRQDnIw7kEqBg3F+qPB77m+3r7SAGx7PZ5tLJqdEEdgE0MurAURyKzUzyplD85 tm91uiDcVtW/wSj7JqbQf0c5/IDGFpxmNnMGthe7XlOaKHXeANyOkHGBL2U+Mlka57tO xoRA== X-Gm-Message-State: APjAAAW0fzyRBM3sBwsb97O4x+A5lvbt1m3JNjTf0H5vyJt7h9+TDiQL k3wYy8ZR+vvYkWB05FOVxLBDaV404ybT/FyZ68f4/UuKnmjDBjU/1d/sUpW+xKJDxKqDg+sRou6 QarCArfMKNQoeXKvgDxVbe3ClMMEKcvQ6 X-Received: by 2002:a81:24d4:: with SMTP id k203mr8565853ywk.308.1575589359476; Thu, 05 Dec 2019 15:42:39 -0800 (PST) X-Google-Smtp-Source: APXvYqx+x4PNK70e3ElY7ROALSM9ZNL3VxTDfROlKpZSqQ1+jPpCF1o7EJYZ7UIRDoZlqzpTBuX5Qw== X-Received: by 2002:a81:24d4:: with SMTP id k203mr8565837ywk.308.1575589359236; Thu, 05 Dec 2019 15:42:39 -0800 (PST) Received: from cs-u-syssec1.dtc.umn.edu (cs-u-syssec1.cs.umn.edu. [128.101.106.66]) by smtp.gmail.com with ESMTPSA id v186sm5388395ywv.34.2019.12.05.15.42.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2019 15:42:38 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Subject: [PATCH] drm/qxl: remove unnecessary BUG_ON check for handle Date: Thu, 5 Dec 2019 17:42:31 -0600 Message-Id: <20191205234231.10849-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 X-Mailman-Approved-At: Fri, 06 Dec 2019 08:17:34 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=pdZdRYJjEUXDLjH6ecgkCpYlUe5NSw8y98ikYjaziR0=; b=h0F9bA9gPBWqhHGztxcSe9ZaACWK7AXiD76k291yefwX093tjV7CdXxN4t9bTx+RaT T42W+y97udOSBhOlx/nzcZQYOLyo806uKWVtIoJhFul7qGm+4Tt45DkKKiHfGjbIyGR7 0egnwSs320Qax6mGNYh1klTbVdb5KN5oYfdh/7J3sALZmZBOnPygEw/drcQuFc3LZQaZ QnZ0SuMcchPcB4zGcIr6su/rxJmaW+GvmDPx2QZ8S2sCSx+C8Ih2Lox/kSPEdfcfafXU DDHIAv2aIgKHoc1QIp3HVU2uDX82d7Vt9K8zyx++Gpv9TL8Q1eb+DgII9rwJ2iiGwIv+ P4Vg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , kjlu@umn.edu, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, Gerd Hoffmann , spice-devel@lists.freedesktop.org, Dave Airlie MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In qxl_gem_object_create_with_handle(), handle's memory is not allocated on the heap. Checking for failure of handle via BUG_ON is unnecessary. This patch eliminates the check. Signed-off-by: Aditya Pakki --- drivers/gpu/drm/qxl/qxl_gem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/qxl/qxl_gem.c b/drivers/gpu/drm/qxl/qxl_gem.c index 69f37db1027a..45b779a8bc22 100644 --- a/drivers/gpu/drm/qxl/qxl_gem.c +++ b/drivers/gpu/drm/qxl/qxl_gem.c @@ -84,7 +84,6 @@ int qxl_gem_object_create_with_handle(struct qxl_device *qdev, int r; BUG_ON(!qobj); - BUG_ON(!handle); r = qxl_gem_object_create(qdev, size, 0, domain,