[-next] watchdog: tqmx86_wdt: Fix build error
diff mbox series

Message ID 20191206124259.25880-1-yuehaibing@huawei.com
State Accepted
Headers show
Series
  • [-next] watchdog: tqmx86_wdt: Fix build error
Related show

Commit Message

YueHaibing Dec. 6, 2019, 12:42 p.m. UTC
If TQMX86_WDT is y and WATCHDOG_CORE is m, building fails:

drivers/watchdog/tqmx86_wdt.o: In function `tqmx86_wdt_probe':
tqmx86_wdt.c:(.text+0x46e): undefined reference to `watchdog_init_timeout'
tqmx86_wdt.c:(.text+0x4e0): undefined reference to `devm_watchdog_register_device'

Select WATCHDOG_CORE to fix this.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: e3c21e088f89 ("watchdog: tqmx86: Add watchdog driver for the IO controller")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/watchdog/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Guenter Roeck Dec. 6, 2019, 2:05 p.m. UTC | #1
On 12/6/19 4:42 AM, YueHaibing wrote:
> If TQMX86_WDT is y and WATCHDOG_CORE is m, building fails:
> 
> drivers/watchdog/tqmx86_wdt.o: In function `tqmx86_wdt_probe':
> tqmx86_wdt.c:(.text+0x46e): undefined reference to `watchdog_init_timeout'
> tqmx86_wdt.c:(.text+0x4e0): undefined reference to `devm_watchdog_register_device'
> 
> Select WATCHDOG_CORE to fix this.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: e3c21e088f89 ("watchdog: tqmx86: Add watchdog driver for the IO controller")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   drivers/watchdog/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 1679e0d..20bd967 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1444,6 +1444,7 @@ config SMSC37B787_WDT
>   config TQMX86_WDT
>   	tristate "TQ-Systems TQMX86 Watchdog Timer"
>   	depends on X86
> +	select WATCHDOG_CORE
>   	help
>   	This is the driver for the hardware watchdog timer in the TQMX86 IO
>   	controller found on some of their ComExpress Modules.
>

Patch
diff mbox series

diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 1679e0d..20bd967 100644
--- a/drivers/watchdog/Kconfig
+++ b/drivers/watchdog/Kconfig
@@ -1444,6 +1444,7 @@  config SMSC37B787_WDT
 config TQMX86_WDT
 	tristate "TQ-Systems TQMX86 Watchdog Timer"
 	depends on X86
+	select WATCHDOG_CORE
 	help
 	This is the driver for the hardware watchdog timer in the TQMX86 IO
 	controller found on some of their ComExpress Modules.