| Message ID | 1575649974-31472-6-git-send-email-fabrizio.castro@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kieran Bingham |
| Headers | show |
| Series | Add dual-LVDS panel support to EK874 | expand |
Hi Fabrizio, Thank you for the patch. On Fri, Dec 06, 2019 at 04:32:52PM +0000, Fabrizio Castro wrote: > Primary and companion encoders need to set the same mode for > things to work properly. > > rcar_lvds_mode_set gets called into for the primary encoder only, > therefore initialize the companion encoder mode while sorting > the primary encoder mode out. > > Fixes: fa440d870358 ("drm: rcar-du: lvds: Add support for dual-link mode") > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Would you mind rebasing this on top of "drm: rcar-du: lvds: Get mode from state" ? > --- > v3->v4: > * New patch extracted from patch: > "drm: rcar-du: lvds: Add dual-LVDS panels support" > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index cb2147c..eed5611 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -614,6 +614,18 @@ static void rcar_lvds_mode_set(struct drm_bridge *bridge, > lvds->display_mode = *adjusted_mode; > > rcar_lvds_get_lvds_mode(lvds); > + if (lvds->companion) { > + struct rcar_lvds *companion_lvds = bridge_to_rcar_lvds( > + lvds->companion); > + > + /* > + * FIXME: We should not be messing with the companion encoder > + * private data from the primary encoder, but since > + * rcar_lvds_mode_set gets called into for the primary encoder > + * only, we don't have much of a choice for now. > + */ > + companion_lvds->mode = lvds->mode; > + } > } > > static int rcar_lvds_attach(struct drm_bridge *bridge)
Hi Laurent, Thank you for your feedback! > From: devicetree-owner@vger.kernel.org <devicetree-owner@vger.kernel.org> On Behalf Of Laurent Pinchart > Sent: 13 December 2019 21:42 > Subject: Re: [PATCH v4 5/7] drm: rcar-du: lvds: Fix mode for companion encoder > > Hi Fabrizio, > > Thank you for the patch. > > On Fri, Dec 06, 2019 at 04:32:52PM +0000, Fabrizio Castro wrote: > > Primary and companion encoders need to set the same mode for > > things to work properly. > > > > rcar_lvds_mode_set gets called into for the primary encoder only, > > therefore initialize the companion encoder mode while sorting > > the primary encoder mode out. > > > > Fixes: fa440d870358 ("drm: rcar-du: lvds: Add support for dual-link mode") > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > Would you mind rebasing this on top of "drm: rcar-du: lvds: Get mode > from state" ? It looks like dropping this patch and rebasing on top of your v2 for "drm: rcar-du: lvds: Get mode from state" does the trick now. Will put a dependency to your patch in v5. Cheers, Fab > > > --- > > v3->v4: > > * New patch extracted from patch: > > "drm: rcar-du: lvds: Add dual-LVDS panels support" > > --- > > drivers/gpu/drm/rcar-du/rcar_lvds.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > > index cb2147c..eed5611 100644 > > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > > @@ -614,6 +614,18 @@ static void rcar_lvds_mode_set(struct drm_bridge *bridge, > > lvds->display_mode = *adjusted_mode; > > > > rcar_lvds_get_lvds_mode(lvds); > > + if (lvds->companion) { > > + struct rcar_lvds *companion_lvds = bridge_to_rcar_lvds( > > + lvds->companion); > > + > > + /* > > + * FIXME: We should not be messing with the companion encoder > > + * private data from the primary encoder, but since > > + * rcar_lvds_mode_set gets called into for the primary encoder > > + * only, we don't have much of a choice for now. > > + */ > > + companion_lvds->mode = lvds->mode; > > + } > > } > > > > static int rcar_lvds_attach(struct drm_bridge *bridge) > > -- > Regards, > > Laurent Pinchart
diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c index cb2147c..eed5611 100644 --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c @@ -614,6 +614,18 @@ static void rcar_lvds_mode_set(struct drm_bridge *bridge, lvds->display_mode = *adjusted_mode; rcar_lvds_get_lvds_mode(lvds); + if (lvds->companion) { + struct rcar_lvds *companion_lvds = bridge_to_rcar_lvds( + lvds->companion); + + /* + * FIXME: We should not be messing with the companion encoder + * private data from the primary encoder, but since + * rcar_lvds_mode_set gets called into for the primary encoder + * only, we don't have much of a choice for now. + */ + companion_lvds->mode = lvds->mode; + } } static int rcar_lvds_attach(struct drm_bridge *bridge)
Primary and companion encoders need to set the same mode for things to work properly. rcar_lvds_mode_set gets called into for the primary encoder only, therefore initialize the companion encoder mode while sorting the primary encoder mode out. Fixes: fa440d870358 ("drm: rcar-du: lvds: Add support for dual-link mode") Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> --- v3->v4: * New patch extracted from patch: "drm: rcar-du: lvds: Add dual-LVDS panels support" --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)