[1/2] arm64: dts: lx2160a: add MDIO descriptions
diff mbox series

Message ID E1ieHiP-0004wT-2O@rmk-PC.armlinux.org.uk
State New
Headers show
Series
  • Add support for Solidrun CEX7 platforms
Related show

Commit Message

Russell King Dec. 9, 2019, noon UTC
Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
the SolidRun Clearfog CX platform.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Shawn Guo Dec. 11, 2019, 7:33 a.m. UTC | #1
On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> the SolidRun Clearfog CX platform.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 0bd98f179bfa..617e1f1a2339 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -863,6 +863,26 @@
>  			fsl,extts-fifo;
>  		};
>  
> +		emdio1: mdio@8b96000 {
> +			compatible = "fsl,fman-memac-mdio";
> +			reg = <0x00 0x8b96000 0x00 0x1000>;
> +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> +			little-endian;
> +			#address-cells = <0x01>;
> +			#size-cells = <0x00>;
> +			status = "disabled";
> +		};
> +
> +		emdio2: mdio@8b97000 {
> +			compatible = "fsl,fman-memac-mdio";
> +			reg = <0x00 0x8b97000 0x00 0x1000>;
> +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> +			little-endian;
> +			#address-cells = <0x01>;
> +			#size-cells = <0x00>;
> +			status = "disabled";
> +		};
> +

Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
emdio2 was missing from there.

Shawn

[1] https://lkml.org/lkml/2019/12/4/675

>  		fsl_mc: fsl-mc@80c000000 {
>  			compatible = "fsl,qoriq-mc";
>  			reg = <0x00000008 0x0c000000 0 0x40>,
> -- 
> 2.20.1
>
Russell King - ARM Linux admin Dec. 16, 2019, 11:02 a.m. UTC | #2
On Wed, Dec 11, 2019 at 03:33:31PM +0800, Shawn Guo wrote:
> On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> > Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> > the SolidRun Clearfog CX platform.
> > 
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > ---
> >  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > index 0bd98f179bfa..617e1f1a2339 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > @@ -863,6 +863,26 @@
> >  			fsl,extts-fifo;
> >  		};
> >  
> > +		emdio1: mdio@8b96000 {
> > +			compatible = "fsl,fman-memac-mdio";
> > +			reg = <0x00 0x8b96000 0x00 0x1000>;
> > +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > +			little-endian;
> > +			#address-cells = <0x01>;
> > +			#size-cells = <0x00>;
> > +			status = "disabled";
> > +		};
> > +
> > +		emdio2: mdio@8b97000 {
> > +			compatible = "fsl,fman-memac-mdio";
> > +			reg = <0x00 0x8b97000 0x00 0x1000>;
> > +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> > +			little-endian;
> > +			#address-cells = <0x01>;
> > +			#size-cells = <0x00>;
> > +			status = "disabled";
> > +		};
> > +
> 
> Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
> emdio2 was missing from there.
> 
> Shawn
> 
> [1] https://lkml.org/lkml/2019/12/4/675

Okay, I'll wait until after the next merge window before resubmitting.
Thanks.
Russell King - ARM Linux admin Dec. 16, 2019, 11:34 a.m. UTC | #3
On Mon, Dec 16, 2019 at 11:02:53AM +0000, Russell King - ARM Linux admin wrote:
> On Wed, Dec 11, 2019 at 03:33:31PM +0800, Shawn Guo wrote:
> > On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> > > Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> > > the SolidRun Clearfog CX platform.
> > > 
> > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > > ---
> > >  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > index 0bd98f179bfa..617e1f1a2339 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > @@ -863,6 +863,26 @@
> > >  			fsl,extts-fifo;
> > >  		};
> > >  
> > > +		emdio1: mdio@8b96000 {
> > > +			compatible = "fsl,fman-memac-mdio";
> > > +			reg = <0x00 0x8b96000 0x00 0x1000>;
> > > +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > > +			little-endian;
> > > +			#address-cells = <0x01>;
> > > +			#size-cells = <0x00>;
> > > +			status = "disabled";
> > > +		};
> > > +
> > > +		emdio2: mdio@8b97000 {
> > > +			compatible = "fsl,fman-memac-mdio";
> > > +			reg = <0x00 0x8b97000 0x00 0x1000>;
> > > +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> > > +			little-endian;
> > > +			#address-cells = <0x01>;
> > > +			#size-cells = <0x00>;
> > > +			status = "disabled";
> > > +		};
> > > +
> > 
> > Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
> > emdio2 was missing from there.
> > 
> > Shawn
> > 
> > [1] https://lkml.org/lkml/2019/12/4/675
> 
> Okay, I'll wait until after the next merge window before resubmitting.
> Thanks.

Just to be clear: the reasons are:
1) Ioana's patch was _not_ copied to linux-arm-kernel as it should have
   been.
2) I can't download the patch off lkml.org to sanely rebase on top of it
3) I'm not hunting around to try and find it on another archive site
4) I'm not digging about in random git trees trying to find it.

This makes it unnecessarily difficult to progress these patches.
Russell King - ARM Linux admin Dec. 16, 2019, 12:34 p.m. UTC | #4
On Mon, Dec 16, 2019 at 11:34:56AM +0000, Russell King - ARM Linux admin wrote:
> On Mon, Dec 16, 2019 at 11:02:53AM +0000, Russell King - ARM Linux admin wrote:
> > On Wed, Dec 11, 2019 at 03:33:31PM +0800, Shawn Guo wrote:
> > > On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> > > > Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> > > > the SolidRun Clearfog CX platform.
> > > > 
> > > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > > > ---
> > > >  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
> > > >  1 file changed, 20 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > index 0bd98f179bfa..617e1f1a2339 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > @@ -863,6 +863,26 @@
> > > >  			fsl,extts-fifo;
> > > >  		};
> > > >  
> > > > +		emdio1: mdio@8b96000 {
> > > > +			compatible = "fsl,fman-memac-mdio";
> > > > +			reg = <0x00 0x8b96000 0x00 0x1000>;
> > > > +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > > > +			little-endian;
> > > > +			#address-cells = <0x01>;
> > > > +			#size-cells = <0x00>;
> > > > +			status = "disabled";
> > > > +		};
> > > > +
> > > > +		emdio2: mdio@8b97000 {
> > > > +			compatible = "fsl,fman-memac-mdio";
> > > > +			reg = <0x00 0x8b97000 0x00 0x1000>;
> > > > +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> > > > +			little-endian;
> > > > +			#address-cells = <0x01>;
> > > > +			#size-cells = <0x00>;
> > > > +			status = "disabled";
> > > > +		};
> > > > +
> > > 
> > > Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
> > > emdio2 was missing from there.
> > > 
> > > Shawn
> > > 
> > > [1] https://lkml.org/lkml/2019/12/4/675
> > 
> > Okay, I'll wait until after the next merge window before resubmitting.
> > Thanks.
> 
> Just to be clear: the reasons are:
> 1) Ioana's patch was _not_ copied to linux-arm-kernel as it should have
>    been.
> 2) I can't download the patch off lkml.org to sanely rebase on top of it
> 3) I'm not hunting around to try and find it on another archive site
> 4) I'm not digging about in random git trees trying to find it.
> 
> This makes it unnecessarily difficult to progress these patches.

Okay, I finally found it at:

https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/patch/?id=6e1b8fae892daa7ffb48570264b8e43b3f807e9a

Note that that was unnecessarily difficult - google was unable to find
it.  Ioana's patch should have been copied to linux-arm-kernel as per
MAINTAINERS, but wasn't.  Is copying the appropriate mailing lists for
a patch now optional?
Shawn Guo Dec. 23, 2019, 1:41 a.m. UTC | #5
On Mon, Dec 16, 2019 at 12:34:42PM +0000, Russell King - ARM Linux admin wrote:
> Okay, I finally found it at:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/patch/?id=6e1b8fae892daa7ffb48570264b8e43b3f807e9a
> 
> Note that that was unnecessarily difficult - google was unable to find
> it.  Ioana's patch should have been copied to linux-arm-kernel as per
> MAINTAINERS, but wasn't.  Is copying the appropriate mailing lists for
> a patch now optional?

Absolutely no.  I will remind people to copy appropriate mailing lists
when sending patches.  Sorry.

Shawn

Patch
diff mbox series

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
index 0bd98f179bfa..617e1f1a2339 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
@@ -863,6 +863,26 @@ 
 			fsl,extts-fifo;
 		};
 
+		emdio1: mdio@8b96000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b96000 0x00 0x1000>;
+			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+
+		emdio2: mdio@8b97000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b97000 0x00 0x1000>;
+			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+
 		fsl_mc: fsl-mc@80c000000 {
 			compatible = "fsl,qoriq-mc";
 			reg = <0x00000008 0x0c000000 0 0x40>,