diff mbox series

[v3,2/2] thermal: armada: clear reset in armadaxp_init

Message ID BN8PR10MB33797EECAC557B5018A0A6628C580@BN8PR10MB3379.namprd10.prod.outlook.com (mailing list archive)
State Accepted, archived
Delegated to: Zhang Rui
Headers show
Series [v3,1/2] thermal: armada: fix register offsets for AXP | expand

Commit Message

Zachary Hays Dec. 9, 2019, 6:57 p.m. UTC 
The reset bit needs to be cleared in the init sequence otherwise it
holds the block in reset.

Signed-off-by: Zachary Hays <zhays@lexmark.com>
---
v2: update commit title and add "Signed-off-by"
v3: resend for clarification
---
 drivers/thermal/armada_thermal.c | 3 +++
 1 file changed, 3 insertions(+)

--
2.7.4

Comments

Miquel Raynal Dec. 16, 2019, 8:08 a.m. UTC | #1 
Hi Zak,

Zak Hays <zak.hays@lexmark.com> wrote on Mon, 9 Dec 2019 18:57:23 +0000:

> The reset bit needs to be cleared in the init sequence otherwise it
> holds the block in reset.
> 
> Signed-off-by: Zachary Hays <zhays@lexmark.com>

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miquèl
diff mbox series

Patch

diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index 88363812033c..8c4d1244ee7a 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c
@@ -155,6 +155,9 @@  static void armadaxp_init(struct platform_device *pdev,

        regmap_write(priv->syscon, data->syscon_control1_off, reg);

+       reg &= ~PMU_TDC0_SW_RST_MASK;
+       regmap_write(priv->syscon, data->syscon_control1_off, reg);
+
        /* Enable the sensor */
        regmap_read(priv->syscon, data->syscon_status_off, &reg);
        reg &= ~PMU_TM_DISABLE_MASK;