From patchwork Mon Dec 9 19:46:07 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dennis Zhou X-Patchwork-Id: 11280185 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2A4CC138D for ; Mon, 9 Dec 2019 19:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F38F52073D for ; Mon, 9 Dec 2019 19:46:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575920798; bh=Lnkmmop+Vni7TWwWjKKDhJNj9iv7UBQlwGyW8Qz0pbE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:In-Reply-To: References:List-ID:From; b=HiRFDSolQIuq3aNs3WWMaQOPo8XsAhPDAXKwz8H5mm8h6PSuL6aROrXNvi2+hE/UF jB1mwfQybNw7d9XN87A1pBPZ9sWrz+z475709PlNw7vSsslY/SDO5OwGMjnzp72XOB WBHb+1ki8UDZ5mk7RyJK3uQvb8M6PAFA2nehwVSI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbfLITqg (ORCPT ); Mon, 9 Dec 2019 14:46:36 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:36993 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726928AbfLITqe (ORCPT ); Mon, 9 Dec 2019 14:46:34 -0500 Received: by mail-pl1-f194.google.com with SMTP id c23so936370plz.4 for ; Mon, 09 Dec 2019 11:46:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=F14OZFzQXvrrV4g8hdVBekK/FaE5I6IU2gcfkyyyj9M=; b=dWjoevsSR6SM9mpaRkp4NV7X6wzFiL9ad77Ov5IDpD2gZtT/za3r5kEi8FkUeMRNmj mgU339e9IABv8XFaRJalTtGWmiMwHv8dMD0nmS6Nru2fzXMuHmU70EfZMjecOalOkGSY HPQs5w4lpGw+lSLuv7rOWKAYpKEVRAluvsjm8VmNBl7m+EusAivjT3Nj+Glf6QRcalzN /b0pPGw1Rf3K1OM2y2K86lauc540vD2LPITU8yS7GoLCiUfKZJbafYZ/hl2/0Xq2y0DL 3a4CKD8SDGz7mykHatlbpDqHY8LrmYKr9L+ucr/v3RzcamFbytTzFv1xoN3CGTRWS2wa 1Gpg== X-Gm-Message-State: APjAAAV7F5CWOQ4sNw4gTbb7A6MfteibAH/1SX52Z3FqpOZhWhj+a2mR 4ytlkqS8CYa6q4D0/0TbOLI= X-Google-Smtp-Source: APXvYqwDT5F/8vs4gq8y83WnvoDtgEfdLw9PdUKUMNFEeeqEy8UT5lldgkYlAe9ovIz0mX/xQCGjRw== X-Received: by 2002:a17:902:d68f:: with SMTP id v15mr8441406ply.95.1575920793966; Mon, 09 Dec 2019 11:46:33 -0800 (PST) Received: from dennisz-mbp.thefacebook.com ([199.201.64.138]) by smtp.gmail.com with ESMTPSA id b190sm282956pfg.66.2019.12.09.11.46.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 09 Dec 2019 11:46:33 -0800 (PST) From: Dennis Zhou To: David Sterba , Chris Mason , Josef Bacik , Omar Sandoval Cc: kernel-team@fb.com, linux-btrfs@vger.kernel.org, Dennis Zhou Subject: [PATCH 22/22] btrfs: make smaller extents more likely to go into bitmaps Date: Mon, 9 Dec 2019 11:46:07 -0800 Message-Id: X-Mailer: git-send-email 2.13.5 In-Reply-To: References: In-Reply-To: References: Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org It's less than ideal for small extents to eat into our extent budget, so force extents <= 32KB into the bitmaps save for the first handful. Signed-off-by: Dennis Zhou Reviewed-by: Josef Bacik --- fs/btrfs/free-space-cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c index 6a313946a8da..42db751aa896 100644 --- a/fs/btrfs/free-space-cache.c +++ b/fs/btrfs/free-space-cache.c @@ -2108,8 +2108,8 @@ static bool use_bitmap(struct btrfs_free_space_ctl *ctl, * of cache left then go ahead an dadd them, no sense in adding * the overhead of a bitmap if we don't have to. */ - if (info->bytes <= fs_info->sectorsize * 4) { - if (ctl->free_extents * 2 <= ctl->extents_thresh) + if (info->bytes <= fs_info->sectorsize * 8) { + if (ctl->free_extents * 3 <= ctl->extents_thresh) return false; } else { return false;