| Message ID | 20191209234544.128302-1-ebiggers@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fs/direct-io.c: include fs/internal.h for missing prototype | expand |
On Mon 09-12-19 15:45:44, Eric Biggers wrote: > From: Eric Biggers <ebiggers@google.com> > > Include fs/internal.h to address the following 'sparse' warning: > > fs/direct-io.c:591:5: warning: symbol 'sb_init_dio_done_wq' was not declared. Should it be static? > > Signed-off-by: Eric Biggers <ebiggers@google.com> Makes sense. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > > Hi Andrew, please consider applying this straightforward cleanup. > This has been sent to Al four times with no response. > > fs/direct-io.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fs/direct-io.c b/fs/direct-io.c > index 0ec4f270139f6..00b4d15bb811a 100644 > --- a/fs/direct-io.c > +++ b/fs/direct-io.c > @@ -39,6 +39,8 @@ > #include <linux/atomic.h> > #include <linux/prefetch.h> > > +#include "internal.h" > + > /* > * How many user pages to map in one call to get_user_pages(). This determines > * the size of a structure in the slab cache > -- > 2.24.0.393.g34dc348eaf-goog >
diff --git a/fs/direct-io.c b/fs/direct-io.c index 0ec4f270139f6..00b4d15bb811a 100644 --- a/fs/direct-io.c +++ b/fs/direct-io.c @@ -39,6 +39,8 @@ #include <linux/atomic.h> #include <linux/prefetch.h> +#include "internal.h" + /* * How many user pages to map in one call to get_user_pages(). This determines * the size of a structure in the slab cache