[02/15,resend] ASoC: soc-core: remove snd_soc_disconnect_sync()
diff mbox series

Message ID 87eexdyq6p.wl-kuninori.morimoto.gx@renesas.com
State New
Headers show
  • ASoC: soc-core cleanup step6
Related show

Commit Message

Kuninori Morimoto Dec. 10, 2019, 12:33 a.m. UTC
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Sound card disconnecting operation was needed when "sound driver" was
unbinded without unbinding "sound card".
In such case, sound driver should be stopped even though it was
playbacking/capturing. Otherwise clock open/close counter mismatch happen.

One headache was that we can't skip unbind in error case because unbind
operation doesn't check return value from each drivers.
snd_soc_disconnect_sync() was added for these purpose, and Renesas
sound card only is used it.

But now, ALSA SoC automatically disconnect sound card when sound driver
was unbinded. Thus, snd_soc_disconnect_sync() is no longer needed.
This patch removes it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
 sound/soc/sh/rcar/core.c |  2 --
 sound/soc/soc-core.c     | 12 ------------
 2 files changed, 14 deletions(-)

diff mbox series

diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
index fc32cbb..35a6592 100644
--- a/sound/soc/sh/rcar/core.c
+++ b/sound/soc/sh/rcar/core.c
@@ -1808,8 +1808,6 @@  static int rsnd_remove(struct platform_device *pdev)
 	int ret = 0, i;
-	snd_soc_disconnect_sync(&pdev->dev);
 	for_each_rsnd_dai(rdai, priv, i) {
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 435a365..eeddd2c 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1444,18 +1444,6 @@  static int soc_probe_link_components(struct snd_soc_card *card)
 	return 0;
-void snd_soc_disconnect_sync(struct device *dev)
-	struct snd_soc_component *component =
-			snd_soc_lookup_component(dev, NULL);
-	if (!component || !component->card)
-		return;
-	snd_card_disconnect_sync(component->card->snd_card);
 static int soc_link_dai_pcm_new(struct snd_soc_dai **dais, int num_dais,
 				struct snd_soc_pcm_runtime *rtd)