From patchwork Tue Dec 10 10:14:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Przemys=C5=82aw_Gaj?= X-Patchwork-Id: 11281801 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3FC32138C for ; Tue, 10 Dec 2019 10:15:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1ABCD2053B for ; Tue, 10 Dec 2019 10:15:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MYH2p8lX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cadence.com header.i=@cadence.com header.b="fwnGCMYq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=cadence.com header.i=@cadence.com header.b="4iA3svFT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1ABCD2053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cadence.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-i3c-bounces+linux-i3c=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6S2dMaU4+8YKbG6vRL/MU50LftMqHc7QOb7rMriL4Ug=; b=MYH2p8lXrkjk9b +slwTdGoii0hFpnle/be1Gm6DKVs8q5hn/TWk7uv26uXNDqXXdk47eLpwHuQHG3hKhEwHtc3xD8to DM9IdX9n9lQ8WhmTAmdvosYovmX6KTX8Y66sFoSQbrMVFzD19MNkGFbQIry9f1FxCwcFcJXRvZHzn 6cX2sB1+PAPm0AUtOxTg9ZomgvIsl9rIvKv+2KVd9DwHdqoBncwzaxSAaNH+R810LaUgV/jWe6vLE isE+r8TYgbsjiZFGjEd8O8BgM2tlsreQXli+xcqzwsXrhBIpwhLCtjI7jQ5du+N+RcwBNxPLe0WTX ePClB5c9jmLFlTTuhhvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iecYX-00084w-QA; Tue, 10 Dec 2019 10:15:49 +0000 Received: from mx0a-0014ca01.pphosted.com ([208.84.65.235]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iecYV-00083x-Ea for linux-i3c@lists.infradead.org; Tue, 10 Dec 2019 10:15:48 +0000 Received: from pps.filterd (m0042385.ppops.net [127.0.0.1]) by mx0a-0014ca01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xBAADLgJ025727; Tue, 10 Dec 2019 02:15:46 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=proofpoint; bh=cq2c7r/7isRzyQQWckpwBeP7eb7dRAANXAltrpO4BAI=; b=fwnGCMYqCgzg+GZ1GDN5EyHVOXp1xsFYTJhWfQbRgOhekpTkO2oEIZEis+n2kMCjAjp9 rWpsU8YR5kqydBH6IwY3R6pZUmzDqKzZxiqREpKhozNAbB8eEjIVYSb0lm7iSoY2mWkh DwSKYAk2+q/XKSA3AnfGNQn1OyQpB24G/idBvLVQD5yIbpc7mE5KvSkyRUXCVVyk0Kov rWATLgWPxk2REq2SCV8F473nggkGiYZfyDj81ZLKnvPAgI3PKlxupFpgJxSDGMBQcAC9 3W0eErluZaGc7SC0BgU5rpObaNnamauWUBQn+DbiTiaqFD2rU3N5MEqeqx7cbCIXtkKd JA== Received: from nam02-bl2-obe.outbound.protection.outlook.com (mail-bl2nam02lp2053.outbound.protection.outlook.com [104.47.38.53]) by mx0a-0014ca01.pphosted.com with ESMTP id 2wra709bnh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Dec 2019 02:15:46 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GhO1W2dUD0dMgYoQPZxJkvNCtprw4OcBI5vTU5XJIApVhgyb42KnoqXKTajEtuj9Egwn6RVBV/Hu5TM7BwIeWB6jYP+ZN2Ho+cEh9Lwd2FKtq+Xi8cx08MDzqlfFvmk0XDGOwI6HavipKDC9Np6RuFYh/Xer9tHKJ+9hRS6kdu5CLulR72Ppz89nMEqu3qeEG+VJRk/tHGIYf8d2QfpLU2ry9wJj9dctlnHNWv6ZS5/0F5txzixEkWLyxXy75c565uHxs1LDUJMEyn0UoA3E83aEVl0CFZ+kLeKBSGhCBo0/KnSSP3TPmuCqVLH22EcVZBu6EIWGhli85PvMjQuZCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cq2c7r/7isRzyQQWckpwBeP7eb7dRAANXAltrpO4BAI=; b=LIlf1ioXBs6snznayAz3h6rruMuI1YhmFWKlXv8zzTjYfMw54l+JwRCtawoPB0Ken5hanpmWd2L/kzbUN90QfwCvh7cZ3ckE8dfhANqN2MtNeUcJjmrDp67PdgJbQrKzRKc8uW9VcuStl41gutyCBzYxoARDaOiZuPEVe0sjKU1W3aIt3zTvEUIRdbrEVF1OWH0bKBCsND9tsbRm4qOuopTwe9rb7VSZXAZN+ydcBoOZMSIxXvq2/PQlU0fSamsgXa2tvwZHMAtBjOZkifxtu/7KHrswgDkdKy6BSYCjY0UJRSoP3cbxXDFlCn4+Zc4bcKy0NIdhJHctG3VMA0lujQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 64.207.220.243) smtp.rcpttodomain=kernel.org smtp.mailfrom=cadence.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=cadence.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cq2c7r/7isRzyQQWckpwBeP7eb7dRAANXAltrpO4BAI=; b=4iA3svFTqlp8wFZmzJBRQ3Ay4C26g4W5moEqiLF6PfIgy2u//dWlKUG7it6Wm4ni+EgjwUn0dRaE7OB4KjU5qobdfcOrJxXrHUswgvAbod75e6/ZHViaNfATHsi/DMTZmB3yCj1uG1fPdwfYYom9YGzGiR8C6s2x6B6c2buWWas= Received: from BYAPR07CA0042.namprd07.prod.outlook.com (2603:10b6:a03:60::19) by BY5PR07MB6627.namprd07.prod.outlook.com (2603:10b6:a03:1af::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.14; Tue, 10 Dec 2019 10:15:44 +0000 Received: from DM6NAM12FT027.eop-nam12.prod.protection.outlook.com (2a01:111:f400:fe59::209) by BYAPR07CA0042.outlook.office365.com (2603:10b6:a03:60::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2516.12 via Frontend Transport; Tue, 10 Dec 2019 10:15:44 +0000 Received-SPF: Pass (protection.outlook.com: domain of cadence.com designates 64.207.220.243 as permitted sender) receiver=protection.outlook.com; client-ip=64.207.220.243; helo=wcmailrelayl01.cadence.com; Received: from wcmailrelayl01.cadence.com (64.207.220.243) by DM6NAM12FT027.mail.protection.outlook.com (10.13.178.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.18 via Frontend Transport; Tue, 10 Dec 2019 10:15:41 +0000 Received: from maileu3.global.cadence.com (maileu3.cadence.com [10.160.88.99]) by wcmailrelayl01.cadence.com (8.14.7/8.14.4) with ESMTP id xBAAFZPL102957 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=OK); Tue, 10 Dec 2019 02:15:37 -0800 X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com Received: from maileu3.global.cadence.com (10.160.88.99) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 10 Dec 2019 11:15:35 +0100 Received: from vleu-orange.cadence.com (10.160.88.83) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 10 Dec 2019 11:15:35 +0100 Received: from vleu-orange.cadence.com (localhost.localdomain [127.0.0.1]) by vleu-orange.cadence.com (8.14.4/8.14.4) with ESMTP id xBAAFZhH009301; Tue, 10 Dec 2019 11:15:35 +0100 Received: (from pgaj@localhost) by vleu-orange.cadence.com (8.14.4/8.14.4/Submit) id xBAAFZIF009300; Tue, 10 Dec 2019 11:15:35 +0100 From: =?utf-8?q?Przemys=C5=82aw_Gaj?= To: Subject: [PATCH v4 3/6] i3c: master: make sure the PID is set before registering the device Date: Tue, 10 Dec 2019 11:14:59 +0100 Message-ID: <20191210101502.8401-4-pgaj@cadence.com> X-Mailer: git-send-email 2.14.0 In-Reply-To: <20191210101502.8401-1-pgaj@cadence.com> References: <20191210101502.8401-1-pgaj@cadence.com> MIME-Version: 1.0 X-OrganizationHeadersPreserved: maileu3.global.cadence.com X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:64.207.220.243; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(376002)(136003)(346002)(39860400002)(396003)(36092001)(199004)(189003)(426003)(336012)(6916009)(86362001)(356004)(6666004)(478600001)(2616005)(36756003)(5820100001)(107886003)(1076003)(4326008)(8676002)(4744005)(316002)(26005)(186003)(54906003)(81156014)(81166006)(8936002)(5660300002)(36906005)(70586007)(70206006)(66574012)(2870700001)(2906002)(42186006); DIR:OUT; SFP:1101; SCL:1; SRVR:BY5PR07MB6627; H:wcmailrelayl01.cadence.com; FPR:; SPF:Pass; LANG:en; PTR:ErrorRetry; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc27ec37-8af6-40db-4bbc-08d77d59e955 X-MS-TrafficTypeDiagnostic: BY5PR07MB6627: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4714; X-Forefront-PRVS: 02475B2A01 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R0Yd4Ln1oxdlb61KnQ4UVU8/3r4EfWZAVpE8l76KBc3BkvquiVvWBgvkkgjdAwQZ1SdqJyBn6knQUJdJhgQYuJU2JAZU58OCCTi61ho90clDarNB7PkBRo6qn5H8Dj0gFEHB1zGT1xE8Qmp+CUqoOGVohmqnnlxcJw3aH3214BocBBRxmGiM90Cnp0jDoPIrhhYPNJZQxwfF3CxL+jqKTVUSmvlms8R4GY3MmSnqSiYvY65RVnmiMd/G3VXGRSkDMILxm6F/wtWtdx9irYYTDoCZ8XxJtLa1K3rEpWQ3aHCR8xWxYagZxfy2tXLEtqm5sEKjioX5U4CM56yp/M1qq24ly1Pp4r1IRqGehoqdko9/LoDt5ws5M+qsP5yZVQcTWNZQGu0C2iR+knxEDGVtTOztt2SRblbgR+jKeQn7Xp+LEynr2wVl86VpaLRzfpI3iJYvVrzg8id1LOHD8IE+94PY823VvaxQC23Ikr46wi8abkdioQGvD5aI3Ger0dkq X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2019 10:15:41.3324 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc27ec37-8af6-40db-4bbc-08d77d59e955 X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9; Ip=[64.207.220.243]; Helo=[wcmailrelayl01.cadence.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR07MB6627 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-10_01:2019-12-10,2019-12-10 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 mlxlogscore=999 suspectscore=1 malwarescore=0 phishscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 adultscore=0 clxscore=1015 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1912100090 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_021547_490477_D4DEEFB6 X-CRM114-Status: GOOD ( 11.47 ) X-Spam-Score: -0.9 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [208.84.65.235 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-i3c@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux I3C List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-i3c@lists.infradead.org, =?utf-8?q?Przemys=C5=82aw_Gaj?= , rafalc@cadence.com, vitor.soares@synopsys.com Sender: "linux-i3c" Errors-To: linux-i3c-bounces+linux-i3c=patchwork.kernel.org@lists.infradead.org If SETDASA failed for some reason or Provisioned ID (PID) retrieval failed PID may not be set. Check that condition before registering the device. Signed-off-by: Przemysław Gaj --- drivers/i3c/master.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index fab6e0609fca..4b3d1c0f778d 100755 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1450,7 +1450,8 @@ i3c_master_register_new_i3c_devs(struct i3c_master_controller *master) return; i3c_bus_for_each_i3cdev(&master->bus, desc) { - if (desc->dev || !desc->info.dyn_addr || desc == master->this) + if (desc->dev || !desc->info.dyn_addr || + desc == master->this || !desc->info.pid) continue; desc->dev = kzalloc(sizeof(*desc->dev), GFP_KERNEL);