| Message ID | 20191210143706.3928480-1-gregkh@linuxfoundation.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [01/10] tty: serial: samsung: allow driver to be built by anyone | expand |
On Tue, Dec 10, 2019 at 03:36:57PM +0100, Greg Kroah-Hartman wrote: > There is no need to tie this driver to only the OMAP platform, s/OMAP/Exynos/ Beside that: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof > especially for build testing. So add COMPILE_TEST as an option allowing > it to be built on any platform. > > Cc: Kukjin Kim <kgene@kernel.org> > Cc: Krzysztof Kozlowski <krzk@kernel.org> > Cc: Hyunki Koo <kkoos00@naver.com> > Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> > Cc: Shinbeom Choi <sbeom.choi@samsung.com> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-serial@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > drivers/tty/serial/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 99f5da3bf913..c835e10bd97e 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -237,7 +237,7 @@ config SERIAL_CLPS711X_CONSOLE > > config SERIAL_SAMSUNG > tristate "Samsung SoC serial support" > - depends on PLAT_SAMSUNG || ARCH_EXYNOS > + depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST > select SERIAL_CORE > help > Support for the on-chip UARTs on the Samsung S3C24XX series CPUs, > -- > 2.24.0 >
On Tue, Dec 10, 2019 at 03:46:56PM +0100, Krzysztof Kozlowski wrote: > On Tue, Dec 10, 2019 at 03:36:57PM +0100, Greg Kroah-Hartman wrote: > > There is no need to tie this driver to only the OMAP platform, > > s/OMAP/Exynos/ Oops, sorry, was thinking of another driver :) > Beside that: > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Thanks for the review, will fix up the text in here when I apply this. greg k-h
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 99f5da3bf913..c835e10bd97e 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -237,7 +237,7 @@ config SERIAL_CLPS711X_CONSOLE config SERIAL_SAMSUNG tristate "Samsung SoC serial support" - depends on PLAT_SAMSUNG || ARCH_EXYNOS + depends on PLAT_SAMSUNG || ARCH_EXYNOS || COMPILE_TEST select SERIAL_CORE help Support for the on-chip UARTs on the Samsung S3C24XX series CPUs,
There is no need to tie this driver to only the OMAP platform, especially for build testing. So add COMPILE_TEST as an option allowing it to be built on any platform. Cc: Kukjin Kim <kgene@kernel.org> Cc: Krzysztof Kozlowski <krzk@kernel.org> Cc: Hyunki Koo <kkoos00@naver.com> Cc: HYUN-KI KOO <hyunki00.koo@samsung.com> Cc: Shinbeom Choi <sbeom.choi@samsung.com> Cc: Jiri Slaby <jslaby@suse.com> Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-serial@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)