| Message ID | 20191210144535.341977-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [next] drm/i915/display: remove duplicated assignment to pointer crtc_state | expand |
On Tue, Dec 10, 2019 at 02:45:35PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Pointer crtc_state is being assigned twice, one of these is redundant > and can be removed. > > Addresses-Coverity: ("Evaluation order violation") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c > index 5c50b7d2db25..f3389d315b19 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -17751,7 +17751,7 @@ intel_modeset_setup_hw_state(struct drm_device *dev, > > for_each_intel_crtc(&dev_priv->drm, crtc) { > struct intel_crtc_state *crtc_state = > - crtc_state = to_intel_crtc_state(crtc->base.state); > + to_intel_crtc_state(crtc->base.state); Thanks. Pushed to drm-intel-next-queued. > > intel_sanitize_crtc(crtc, ctx); > intel_dump_pipe_config(crtc_state, NULL, "[setup_hw_state]"); > -- > 2.24.0
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 5c50b7d2db25..f3389d315b19 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -17751,7 +17751,7 @@ intel_modeset_setup_hw_state(struct drm_device *dev, for_each_intel_crtc(&dev_priv->drm, crtc) { struct intel_crtc_state *crtc_state = - crtc_state = to_intel_crtc_state(crtc->base.state); + to_intel_crtc_state(crtc->base.state); intel_sanitize_crtc(crtc, ctx); intel_dump_pipe_config(crtc_state, NULL, "[setup_hw_state]");