[for-5.6,17/23] ASoC: sprd: Drop superfluous ioctl PCM ops
diff mbox series

Message ID 20191210145406.21419-18-tiwai@suse.de
State Accepted
Commit 01ac8ada97120b582580a7b3059329ddf659d033
Headers show
Series
  • ASoC: PCM API updates (part II)
Related show

Commit Message

Takashi Iwai Dec. 10, 2019, 2:54 p.m. UTC
ASoC PCM core deals the empty ioctl field now as default.
Let's kill the redundant lines.

Cc: Orson Zhai <orsonzhai@gmail.com>
Cc: Baolin Wang <baolin.wang7@gmail.com>
Cc: Chunyan Zhang <zhang.lyra@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/soc/sprd/sprd-pcm-dma.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Orson Zhai Dec. 11, 2019, 12:21 a.m. UTC | #1
On Tue, Dec 10, 2019 at 10:54 PM Takashi Iwai <tiwai@suse.de> wrote:
>
> ASoC PCM core deals the empty ioctl field now as default.
> Let's kill the redundant lines.
>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Baolin Wang <baolin.wang7@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/soc/sprd/sprd-pcm-dma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/sprd/sprd-pcm-dma.c b/sound/soc/sprd/sprd-pcm-dma.c
> index da4b8f5f192b..2284558684bc 100644
> --- a/sound/soc/sprd/sprd-pcm-dma.c
> +++ b/sound/soc/sprd/sprd-pcm-dma.c
> @@ -508,7 +508,6 @@ static const struct snd_soc_component_driver sprd_soc_component = {
>         .name           = DRV_NAME,
>         .open           = sprd_pcm_open,
>         .close          = sprd_pcm_close,
> -       .ioctl          = snd_soc_pcm_lib_ioctl,
>         .hw_params      = sprd_pcm_hw_params,
>         .hw_free        = sprd_pcm_hw_free,
>         .trigger        = sprd_pcm_trigger,
> --
> 2.16.4
>

Got it. Thank you!
-Orson
Baolin Wang Dec. 11, 2019, 1:38 a.m. UTC | #2
On Tue, Dec 10, 2019 at 10:54 PM Takashi Iwai <tiwai@suse.de> wrote:
>
> ASoC PCM core deals the empty ioctl field now as default.
> Let's kill the redundant lines.
>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Baolin Wang <baolin.wang7@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/soc/sprd/sprd-pcm-dma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/sprd/sprd-pcm-dma.c b/sound/soc/sprd/sprd-pcm-dma.c
> index da4b8f5f192b..2284558684bc 100644
> --- a/sound/soc/sprd/sprd-pcm-dma.c
> +++ b/sound/soc/sprd/sprd-pcm-dma.c
> @@ -508,7 +508,6 @@ static const struct snd_soc_component_driver sprd_soc_component = {
>         .name           = DRV_NAME,
>         .open           = sprd_pcm_open,
>         .close          = sprd_pcm_close,
> -       .ioctl          = snd_soc_pcm_lib_ioctl,
>         .hw_params      = sprd_pcm_hw_params,
>         .hw_free        = sprd_pcm_hw_free,
>         .trigger        = sprd_pcm_trigger,
> --

Thanks for your cleaning up.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>

Patch
diff mbox series

diff --git a/sound/soc/sprd/sprd-pcm-dma.c b/sound/soc/sprd/sprd-pcm-dma.c
index da4b8f5f192b..2284558684bc 100644
--- a/sound/soc/sprd/sprd-pcm-dma.c
+++ b/sound/soc/sprd/sprd-pcm-dma.c
@@ -508,7 +508,6 @@  static const struct snd_soc_component_driver sprd_soc_component = {
 	.name		= DRV_NAME,
 	.open		= sprd_pcm_open,
 	.close		= sprd_pcm_close,
-	.ioctl		= snd_soc_pcm_lib_ioctl,
 	.hw_params	= sprd_pcm_hw_params,
 	.hw_free	= sprd_pcm_hw_free,
 	.trigger	= sprd_pcm_trigger,