dt-bindings: pwm: allwinner: Fix missing header in H6 example
diff mbox series

Message ID 20191210174710.10649-1-peron.clem@gmail.com
State Accepted
Headers show
Series
  • dt-bindings: pwm: allwinner: Fix missing header in H6 example
Related show

Commit Message

Clément Péron Dec. 10, 2019, 5:47 p.m. UTC
Latest linux-next doesn't build due to the following error:

Error: Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dts:35.37-38
syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dt.yaml]
Error 1

This is due to missing header in the device-tree yaml example.

Fix this by adding the missing headers.

Fixes: 4ee929b3f08e ("dt-bindings: pwm: allwinner: Add H6 PWM description")
Reported-by: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml       | 3 +++
 1 file changed, 3 insertions(+)

Comments

Maxime Ripard Dec. 11, 2019, 8:06 a.m. UTC | #1
On Tue, Dec 10, 2019 at 06:47:10PM +0100, Clément Péron wrote:
> Latest linux-next doesn't build due to the following error:
>
> Error: Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dts:35.37-38
> syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dt.yaml]
> Error 1
>
> This is due to missing header in the device-tree yaml example.
>
> Fix this by adding the missing headers.
>
> Fixes: 4ee929b3f08e ("dt-bindings: pwm: allwinner: Add H6 PWM description")
> Reported-by: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>

Applied, thanks!
Maxime
Chen-Yu Tsai Dec. 11, 2019, 8:33 a.m. UTC | #2
On Wed, Dec 11, 2019 at 4:06 PM Maxime Ripard <maxime@cerno.tech> wrote:
>
> On Tue, Dec 10, 2019 at 06:47:10PM +0100, Clément Péron wrote:
> > Latest linux-next doesn't build due to the following error:
> >
> > Error: Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dts:35.37-38
> > syntax error
> > FATAL ERROR: Unable to parse input tree
> > make[1]: *** [Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dt.yaml]
> > Error 1
> >
> > This is due to missing header in the device-tree yaml example.
> >
> > Fix this by adding the missing headers.
> >
> > Fixes: 4ee929b3f08e ("dt-bindings: pwm: allwinner: Add H6 PWM description")
> > Reported-by: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
>
> Applied, thanks!
> Maxime

Maybe squash it instead? :)

ChenYu
Maxime Ripard Dec. 11, 2019, 9:20 a.m. UTC | #3
On Wed, Dec 11, 2019 at 04:33:19PM +0800, Chen-Yu Tsai wrote:
> On Wed, Dec 11, 2019 at 4:06 PM Maxime Ripard <maxime@cerno.tech> wrote:
> >
> > On Tue, Dec 10, 2019 at 06:47:10PM +0100, Clément Péron wrote:
> > > Latest linux-next doesn't build due to the following error:
> > >
> > > Error: Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dts:35.37-38
> > > syntax error
> > > FATAL ERROR: Unable to parse input tree
> > > make[1]: *** [Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.example.dt.yaml]
> > > Error 1
> > >
> > > This is due to missing header in the device-tree yaml example.
> > >
> > > Fix this by adding the missing headers.
> > >
> > > Fixes: 4ee929b3f08e ("dt-bindings: pwm: allwinner: Add H6 PWM description")
> > > Reported-by: Rob Herring <robh+dt@kernel.org>
> > > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> >
> > Applied, thanks!
> > Maxime
>
> Maybe squash it instead? :)

Indeed, I just did.

Thanks!
Maxime

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
index a7dc19fc347a..fab89f052450 100644
--- a/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml
@@ -93,6 +93,9 @@  examples:
     };
 
   - |
+    #include <dt-bindings/clock/sun50i-h6-ccu.h>
+    #include <dt-bindings/reset/sun50i-h6-ccu.h>
+
     pwm@300a000 {
       compatible = "allwinner,sun50i-h6-pwm";
       reg = <0x0300a000 0x400>;