| Message ID | 9680649.eAqxiQ8Vpk@kreacher (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | cpuidle: Drop unnecessary type cast in cpuidle_poll_time() | expand |
> -----Original Message----- > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki > Sent: Wednesday, December 11, 2019 6:31 PM > To: Linux PM <linux-pm@vger.kernel.org> > Cc: LKML <linux-kernel@vger.kernel.org>; Daniel Lezcano > <daniel.lezcano@linaro.org> > Subject: [PATCH] cpuidle: Drop unnecessary type cast in cpuidle_poll_time() > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > The data type of the target_residency_ns field in struct cpuidle_state is u64, > so it does not need to be cast into u64. > > Get read of the unnecessary type cast. s/read/rid thanks, rui > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > > On top of the linux-next branch of linux-pm.git from today. > > --- > drivers/cpuidle/cpuidle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-pm/drivers/cpuidle/cpuidle.c > ============================================================== > ===== > --- linux-pm.orig/drivers/cpuidle/cpuidle.c > +++ linux-pm/drivers/cpuidle/cpuidle.c > @@ -381,7 +381,7 @@ u64 cpuidle_poll_time(struct cpuidle_dri > if (dev->states_usage[i].disable) > continue; > > - limit_ns = (u64)drv->states[i].target_residency_ns; > + limit_ns = drv->states[i].target_residency_ns; > break; > } > > >
On Wed, Dec 11, 2019 at 11:33 AM Zhang, Rui <rui.zhang@intel.com> wrote: > > > > -----Original Message----- > > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > > owner@vger.kernel.org] On Behalf Of Rafael J. Wysocki > > Sent: Wednesday, December 11, 2019 6:31 PM > > To: Linux PM <linux-pm@vger.kernel.org> > > Cc: LKML <linux-kernel@vger.kernel.org>; Daniel Lezcano > > <daniel.lezcano@linaro.org> > > Subject: [PATCH] cpuidle: Drop unnecessary type cast in cpuidle_poll_time() > > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > The data type of the target_residency_ns field in struct cpuidle_state is u64, > > so it does not need to be cast into u64. > > > > Get read of the unnecessary type cast. > > s/read/rid Indeed, thanks!
On 11/12/2019 11:30, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > The data type of the target_residency_ns field in struct cpuidle_state > is u64, so it does not need to be cast into u64. > > Get read of the unnecessary type cast. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Index: linux-pm/drivers/cpuidle/cpuidle.c =================================================================== --- linux-pm.orig/drivers/cpuidle/cpuidle.c +++ linux-pm/drivers/cpuidle/cpuidle.c @@ -381,7 +381,7 @@ u64 cpuidle_poll_time(struct cpuidle_dri if (dev->states_usage[i].disable) continue; - limit_ns = (u64)drv->states[i].target_residency_ns; + limit_ns = drv->states[i].target_residency_ns; break; }