input: keyboard: imx_sc_key: Only take the valid data from SCU firmware as key state
diff mbox series

Message ID 1576202909-1661-1-git-send-email-Anson.Huang@nxp.com
State Mainlined
Commit 1021dcf19db1387bc0db26d14bbcba719923a466
Headers show
Series
  • input: keyboard: imx_sc_key: Only take the valid data from SCU firmware as key state
Related show

Commit Message

Anson Huang Dec. 13, 2019, 2:08 a.m. UTC
When reading key state from SCU, the response data from SCU firmware
is 4 bytes due to MU message protocol, but ONLY the first byte is the
key state, other 3 bytes could be some dirty data, so we should ONLY
take the first byte as key state to avoid reporting incorrect state.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 drivers/input/keyboard/imx_sc_key.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Dmitry Torokhov Dec. 13, 2019, 10:03 p.m. UTC | #1
On Fri, Dec 13, 2019 at 10:08:29AM +0800, Anson Huang wrote:
> When reading key state from SCU, the response data from SCU firmware
> is 4 bytes due to MU message protocol, but ONLY the first byte is the
> key state, other 3 bytes could be some dirty data, so we should ONLY
> take the first byte as key state to avoid reporting incorrect state.
> 
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

Applied, thank you.

> ---
>  drivers/input/keyboard/imx_sc_key.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/imx_sc_key.c b/drivers/input/keyboard/imx_sc_key.c
> index 5379952..9f809ae 100644
> --- a/drivers/input/keyboard/imx_sc_key.c
> +++ b/drivers/input/keyboard/imx_sc_key.c
> @@ -78,7 +78,13 @@ static void imx_sc_check_for_events(struct work_struct *work)
>  		return;
>  	}
>  
> -	state = (bool)msg.state;
> +	/*
> +	 * The response data from SCU firmware is 4 bytes,
> +	 * but ONLY the first byte is the key state, other
> +	 * 3 bytes could be some dirty data, so we should
> +	 * ONLY take the first byte as key state.
> +	 */
> +	state = (bool)(msg.state & 0xff);
>  
>  	if (state ^ priv->keystate) {
>  		priv->keystate = state;
> -- 
> 2.7.4
>

Patch
diff mbox series

diff --git a/drivers/input/keyboard/imx_sc_key.c b/drivers/input/keyboard/imx_sc_key.c
index 5379952..9f809ae 100644
--- a/drivers/input/keyboard/imx_sc_key.c
+++ b/drivers/input/keyboard/imx_sc_key.c
@@ -78,7 +78,13 @@  static void imx_sc_check_for_events(struct work_struct *work)
 		return;
 	}
 
-	state = (bool)msg.state;
+	/*
+	 * The response data from SCU firmware is 4 bytes,
+	 * but ONLY the first byte is the key state, other
+	 * 3 bytes could be some dirty data, so we should
+	 * ONLY take the first byte as key state.
+	 */
+	state = (bool)(msg.state & 0xff);
 
 	if (state ^ priv->keystate) {
 		priv->keystate = state;