[liburing] spec: additional Fedora RPM cleanups
diff mbox series

Message ID 20191213101640.1180590-1-stefanha@redhat.com
State New
Headers show
Series
  • [liburing] spec: additional Fedora RPM cleanups
Related show

Commit Message

Stefan Hajnoczi Dec. 13, 2019, 10:16 a.m. UTC
Cole Robinson made some more suggestions:

 * Use %set_build_flags before ./configure to get the default compiler
   flags.

 * Use '%license COPYING' instead of %doc.

 * Do not ship the static library.  This is distro policy and Fedora
   would ship a separate -static package if static libraries are
   desired.

 * Source: should be the URL to the sources.  URL: should be the URL of
   the website or git repo.

 * The devel package needs
   Requires: %{name}%{?_isa} = %{version}-%{release}

Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 liburing.spec | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Comments

Jeff Moyer Dec. 13, 2019, 3:59 p.m. UTC | #1
Stefan Hajnoczi <stefanha@redhat.com> writes:

> Cole Robinson made some more suggestions:
>
>  * Use %set_build_flags before ./configure to get the default compiler
>    flags.
>
>  * Use '%license COPYING' instead of %doc.
>
>  * Do not ship the static library.  This is distro policy and Fedora
>    would ship a separate -static package if static libraries are
>    desired.
>
>  * Source: should be the URL to the sources.  URL: should be the URL of
>    the website or git repo.
>
>  * The devel package needs
>    Requires: %{name}%{?_isa} = %{version}-%{release}
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

LGTM

Acked-by: Jeff Moyer <jmoyer@redhat.com>
Jens Axboe Dec. 18, 2019, 4:13 a.m. UTC | #2
On 12/13/19 3:16 AM, Stefan Hajnoczi wrote:
> Cole Robinson made some more suggestions:
> 
>  * Use %set_build_flags before ./configure to get the default compiler
>    flags.
> 
>  * Use '%license COPYING' instead of %doc.
> 
>  * Do not ship the static library.  This is distro policy and Fedora
>    would ship a separate -static package if static libraries are
>    desired.
> 
>  * Source: should be the URL to the sources.  URL: should be the URL of
>    the website or git repo.
> 
>  * The devel package needs
>    Requires: %{name}%{?_isa} = %{version}-%{release}

Applied, thanks.

Patch
diff mbox series

diff --git a/liburing.spec b/liburing.spec
index e542771..87b16b1 100644
--- a/liburing.spec
+++ b/liburing.spec
@@ -3,8 +3,8 @@  Version: 0.2
 Release: 1%{?dist}
 Summary: Linux-native io_uring I/O access library
 License: LGPLv2+
-Source: %{name}-%{version}.tar.gz
-URL: https://git.kernel.dk/cgit/liburing/snapshot/%{name}-%{version}.tar.gz
+Source: https://git.kernel.dk/cgit/liburing/snapshot/%{name}-%{version}.tar.gz
+URL: https://git.kernel.dk/cgit/liburing/
 BuildRequires: gcc
 
 %description
@@ -13,7 +13,7 @@  manner, for both buffered and O_DIRECT.
 
 %package devel
 Summary: Development files for Linux-native io_uring I/O access library
-Requires: %{name} = %{version}-%{release}
+Requires: %{name}%{_isa} = %{version}-%{release}
 Requires: pkgconfig
 
 %description devel
@@ -24,6 +24,7 @@  for the Linux-native io_uring.
 %autosetup
 
 %build
+%set_build_flags
 ./configure --prefix=%{_prefix} --libdir=/%{_libdir} --mandir=%{_mandir} --includedir=%{_includedir}
 
 %make_build
@@ -33,13 +34,13 @@  for the Linux-native io_uring.
 
 %files
 %attr(0755,root,root) %{_libdir}/liburing.so.*
-%doc COPYING
+%license COPYING
 
 %files devel
 %{_includedir}/liburing/
 %{_includedir}/liburing.h
 %{_libdir}/liburing.so
-%{_libdir}/liburing.a
+%exclude %{_libdir}/liburing.a
 %{_libdir}/pkgconfig/*
 %{_mandir}/man2/*