[2/2] dt-bindings: phy: Use a real life PX30 DSI PHY example
diff mbox series

Message ID 20191213180019.25080-2-miquel.raynal@bootlin.com
State New
Headers show
Series
  • [1/2] dt-bindings: phy: Fix the PX30 DSI PHY compatible in the example
Related show

Commit Message

Miquel Raynal Dec. 13, 2019, 6 p.m. UTC
Update the example phandles to reference actual nodes and give a
working starting point.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
 .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Heiko Stübner Dec. 13, 2019, 6:02 p.m. UTC | #1
Am Freitag, 13. Dezember 2019, 19:00:19 CET schrieb Miquel Raynal:
> Update the example phandles to reference actual nodes and give a
> working starting point.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Rob Herring Dec. 19, 2019, 11:45 p.m. UTC | #2
On Fri, Dec 13, 2019 at 07:00:19PM +0100, Miquel Raynal wrote:
> Update the example phandles to reference actual nodes and give a
> working starting point.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>  .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml       | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> index 72aca81e8959..2e35bfdf47a1 100644
> --- a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
> @@ -60,9 +60,9 @@ examples:
>      dsi_dphy: phy@ff2e0000 {
>          compatible = "rockchip,px30-dsi-dphy";
>          reg = <0x0 0xff2e0000 0x0 0x10000>;
> -        clocks = <&pmucru 13>, <&cru 12>;
> +        clocks = <&pmucru SCLK_MIPIDSIPHY_REF>, <&cru PCLK_MIPIDSIPHY>;
>          clock-names = "ref", "pclk";
> -        resets = <&cru 12>;
> +        resets = <&cru SRST_MIPIDSIPHY_P>;

Without the appropriate include files, this will break building the 
example.

>          reset-names = "apb";
>          #phy-cells = <0>;
>      };
> -- 
> 2.20.1
>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
index 72aca81e8959..2e35bfdf47a1 100644
--- a/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
+++ b/Documentation/devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml
@@ -60,9 +60,9 @@  examples:
     dsi_dphy: phy@ff2e0000 {
         compatible = "rockchip,px30-dsi-dphy";
         reg = <0x0 0xff2e0000 0x0 0x10000>;
-        clocks = <&pmucru 13>, <&cru 12>;
+        clocks = <&pmucru SCLK_MIPIDSIPHY_REF>, <&cru PCLK_MIPIDSIPHY>;
         clock-names = "ref", "pclk";
-        resets = <&cru 12>;
+        resets = <&cru SRST_MIPIDSIPHY_P>;
         reset-names = "apb";
         #phy-cells = <0>;
     };